From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A643B21ABD7 for ; Mon, 11 May 2026 03:48:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778471338; cv=none; b=oIENJn8fqvPIoDWW7KTb9TkAGYk4WWCaYzstTL/NzcU5p3EvqHTWWiCsTSReOU3ktIbXBZUnQqVlzvMzHQ7FjEYaNoENSG+ghYKoADjvZFOBKcOrE2roMPCU8MOq45LFYuPiXET7aBqvaFvh5WHHrVwCdigdXWU/T2RPqeyZ0N0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778471338; c=relaxed/simple; bh=AH7+rllUgr9cRttphcbDn4wOpxLHtvMKyuKiFut/RQ8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NmeG+asYuLi9NWpiLDRmy/zOlJ1Lujtcuc6Bly2e8qKiV+ib6mkgxCi0991U8owxK1nDwAgOzQ7vEmaTi/Nm6MlMYgqjqPvhQ1WPQpPaPYVxCbZtbCDN/nOJJi5P7pe9/+e68MoVcpVI/M1g38YW7ApdfPj0CSE5bfgDoRmj0jc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QEtzdEQn; arc=none smtp.client-ip=209.85.167.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QEtzdEQn" Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-5a860667fabso3445707e87.0 for ; Sun, 10 May 2026 20:48:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778471335; x=1779076135; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rPGkcrGIaEtncHosCoZMqsncXm4lY9+/rYNyGkd4nTY=; b=QEtzdEQn5xTktglBONT918h2BCdaJWZoddW8sXgQRe2LNF0FwVtjUAxF5wo0THFKgw xhJDevH7z1R+TqdYQMgBgSMVDGg1an5wbdeDe8hcZeUwXtEOmqVixZAU61Igji2eKlvr bE56qv4muPzNnNlKoj/xRnJR+vQ795/BcG53ziWOE5G5zmbtzlCDALpfKdbz0Yv1XLlA Xx/4xNoRmeOxAHdHvbGkJ7JpeRME/D274rWQ86e/eTU5PhKV02XXJo5qANZwE6tyfY0M w4rPIAPskftl5uR6V03AHbrPcTCRdcUxR49pAqYgieeflHhZMfJFBFRwYBLNzc2gMH5d MxqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778471335; x=1779076135; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rPGkcrGIaEtncHosCoZMqsncXm4lY9+/rYNyGkd4nTY=; b=oc0kmLBzHmhLau04E++XuVt1si1fhhutjM8+acAhtUxjVVuwxaX3i3gOr7Fsnq4ivl qlbZXpxNhzDnmUkw2yuwh9lZhwco5ApoLCU3Eq5HPRm6r2eGfNK6PIzCYlUCFlt/IAiJ 7AAqmtrcWKrgihwSZo+Lr5h/Vy1oS2cTbQ+sK//IR574+9DwZUbf+b8QVQhTtI06rQTp IFKGAufkzPNWqdNpxRZSgRDfNGIZ4ksxZuHNxhJm9E/qti4/LJRXUfWhVtdP7BSUxHzS PESbQeaPQy6nH6fhGTY7qUC43chCUwZr25zrWRpzJcwEnWLTtqRoS/FQ5clBAmLJRwdW 4u7g== X-Forwarded-Encrypted: i=1; AFNElJ/z3RVuFwMoaDyZIFH2MeTY/KT739/m4zcATnoxpZ1YAd6CMtn04xRFv4wBW1FFx7O9tjcX+Gab1PbWHjg=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3cUwANBt3/cIipF7txOeE723U+F1I8YvFpOBud6HKdrV9Fzy1 W0Tc23GVC6n9W00KJtzoEYiY9uMs2Y7daabez6txCgZYB57wvweS5hEj X-Gm-Gg: Acq92OGAK7Fu0u4bcurL+37D4ySivcH3QpLlfn1gHCY3/Y01od4LBXhpN21I28HHwZ/ Jatplt/hZ7YsOuTtfsmeBNZHHVOfxkwD5VMcgkWwtMt0qoohDoU3+zDz8/71wmncbQ2HZ6fA9Ph txf4FywAKs4wS3w6tmUd+QRMgLmcENNwn0y4YjY1QLJ/St8NKjUDGycyCqsr6t1nDNDDXdP+1Rt ESnaB0cEZflT9dnLUG7dT2IRxgRrW7G3j7hc9Qo0BA+Ulj8kFz3COxq0PDZC3u2dz2fyiBYqKJU OjfegjT6oXN5OzB6S68WYCeA9wDAIRxHO+FypUsoT7OWMIGcHotf/Hft+og37fLFIxr1Z4rdztK GdMY4Sek2QX+WXo0KXEl9H7ITlN8wmsAwLBVYYmPoo7sTXBKe1HeSsKd2lYRwiJNL2D9vk1AOwp qWJCPLa4f20Vvd49+6IYO7DzKl X-Received: by 2002:a05:6512:15a0:b0:5a8:64c7:9592 with SMTP id 2adb3069b0e04-5a8a94c8da5mr4150614e87.37.1778471334459; Sun, 10 May 2026 20:48:54 -0700 (PDT) Received: from archlinux ([185.140.161.214]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a8a955e14csm2318721e87.43.2026.05.10.20.48.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 May 2026 20:48:53 -0700 (PDT) Date: Mon, 11 May 2026 06:48:51 +0300 From: Nikolay Kulikov To: Pramod Maurya Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/4] staging: rtl8723bs: Fix comparison style in IS_CCK_RATE and IS_OFDM_RATE macros Message-ID: References: <20260510175207.563378-1-pramod.nexgen@gmail.com> <20260510175207.563378-3-pramod.nexgen@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260510175207.563378-3-pramod.nexgen@gmail.com> On Sun, May 10, 2026 at 01:52:05PM -0400, Pramod Maurya wrote: > Place the variable on the left side of comparisons, wrap macro > arguments in parentheses to avoid precedence issues, and wrap the > long macro definitions with a line continuation. > > Signed-off-by: Pramod Maurya > --- > drivers/staging/rtl8723bs/include/ieee80211.h | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/include/ieee80211.h b/drivers/staging/rtl8723bs/include/ieee80211.h > index 7a3609d019aa..11825ace95a9 100644 > --- a/drivers/staging/rtl8723bs/include/ieee80211.h > +++ b/drivers/staging/rtl8723bs/include/ieee80211.h > @@ -394,8 +394,10 @@ enum { > }; > > #define IS_HT_RATE(_rate) (_rate >= MGN_MCS0 && _rate <= MGN_MCS31) > -#define IS_CCK_RATE(_rate) (MGN_1M == _rate || _rate == MGN_2M || _rate == MGN_5_5M || _rate == MGN_11M) > -#define IS_OFDM_RATE(_rate) (MGN_6M <= _rate && _rate <= MGN_54M && _rate != MGN_11M) > +#define IS_CCK_RATE(_rate) \ > + ((_rate) == MGN_1M || (_rate) == MGN_2M || (_rate) == MGN_5_5M || (_rate) == MGN_11M) > +#define IS_OFDM_RATE(_rate) \ > + ((_rate) >= MGN_6M && (_rate) <= MGN_54M && (_rate) != MGN_11M) The IS_OFDM_RATE() macro is also not used, peprhaps it would be better to remove it instead of formatting dead code? Of cource, in a separate patch to avoid mixing up different changes. Thanks, Nikolay