From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0DBA21E098 for ; Mon, 11 May 2026 04:22:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778473326; cv=none; b=bIyun+KSElB+3zG9hW6T6Gw2XHZU/Pdets1w7O33UQ86Ef5gbMj2UhaKYamHFa4hrPyzRhnAKOXMtfQjuHt0cLuFP6/tVEzWxJO8N0jnf6Q2gOX1wcwa/QLe/zcWg4Wta0lmRDagpaY3Eqex2TqbncsiyETaYG2k9h1Oea+Xg58= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778473326; c=relaxed/simple; bh=AvACyM2byGdXQEHQnoVFjO4v9Ms6Q+3e10gracPHV8U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cPn69LmPF/FCKwcAFc+YST+QzLe6y1UwKrNRtwUEjlK0e+Ceg5diodgSlwYypahGWwe6BYg5xSqRSWGjXOAUTSoIfy4vp6HyGmbTYpc0LVxy1MWv71jbl5qZ79oGaXddFegi1K6rSkD3P3WYmbBPoBQrlFK8UChuMcHefj19Ldo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1wMI9J-0002gh-Ah; Mon, 11 May 2026 06:21:45 +0200 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wMI9H-000Byt-1i; Mon, 11 May 2026 06:21:44 +0200 Received: from ore by pty.whiteo.stw.pengutronix.de with local (Exim 4.98.2) (envelope-from ) id 1wMI9I-0000000F7aH-0W2c; Mon, 11 May 2026 06:21:44 +0200 Date: Mon, 11 May 2026 06:21:44 +0200 From: Oleksij Rempel To: Breno Leitao Cc: Robin van der Gracht , kernel@pengutronix.de, Oliver Hartkopp , Marc Kleine-Budde , linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH net-next 1/2] can: j1939: convert to getsockopt_iter Message-ID: References: <20260507-getsock_two_can-v1-0-3c2ae9edfadc@debian.org> <20260507-getsock_two_can-v1-1-3c2ae9edfadc@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260507-getsock_two_can-v1-1-3c2ae9edfadc@debian.org> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org On Thu, May 07, 2026 at 02:34:47AM -0700, Breno Leitao wrote: > Convert CAN J1939 socket's getsockopt implementation to use the new > getsockopt_iter callback with sockopt_t. > > Key changes: > - Replace (char __user *optval, int __user *optlen) with sockopt_t *opt > - Use opt->optlen for buffer length (input) and returned size (output) > - Use copy_to_iter() instead of copy_to_user() > - Restructure the chained if/else if (which depended on put_user() being > an expression) into a nested if/else block now that opt->optlen = len > is a statement > - Add linux/uio.h for copy_to_iter() > > Signed-off-by: Breno Leitao LGTM, Thank you! Acked-by: Oleksij Rempel Best Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |