From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 795292C0299 for ; Mon, 11 May 2026 11:32:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778499138; cv=none; b=I7dElcoGRhlDSje/JFTFOrvDNfn5zKmFaUZRI7sga77XrY/UB87tRnbus933WUBc2qQuXz88w5dvvuJvmKA0/0hQ/mxGkmfIa2Gi2lJ/3QWK+m4tNLmS52OiXHj5MePQKgkA8dRJJMO8fxUzcMdAUeaNRnK0osQFIY8ZF0Zf4XU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778499138; c=relaxed/simple; bh=qNNqg0dnTiPNdw7XCSPl1o8PJe8uHezO/mLjClsBB+U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UmABxEq29g5aE/OJkqUGXaY/QYM2R+MwAUkpQ+7UQmTqoZAuS1D5B82BH3vvoEkp8agR4U6Xiog8fb4AoxYqxpyqJChEP/MMYQoHXfGeHLO1V16I7iIY8djcjFYMbujw7pTZ3EFgkv2qNHxe/gNKhzcyf5XN09EiBWy7CAF6oSE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mUh8viXl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mUh8viXl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5BFE1C2BCB0; Mon, 11 May 2026 11:32:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778499138; bh=qNNqg0dnTiPNdw7XCSPl1o8PJe8uHezO/mLjClsBB+U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mUh8viXlk8oQo393EqkU4YkTeVj3ZpVUXp0PN/Ad7bPd9Ezgc8lq3+2nL/ZRxppyj aEPVqg4XfaJvMtLRm6IZp8dvIui5iGZrZGlejvS6S4Vn6r3o0IdiZH5TCM+UNfE2z/ 8vAYGoqba9jYzfa2W2u0sHconpFBsvfBSazyCAGr+uCR3kkRvguHqk/ovbgjQ7bpxC 9VBtGVVzL7XT3bwGB+vg7UIdqAYT5stR/fsd4Tg9tTTSpVU7bgnLKVGXnR/rGdM1Nn CqK0vF8ya8wli7tvt066pA3NbJBe+MdFm3jHEo9YcPJCFXcPTLi+LFgfszgc0j2KY3 xw7LdbQKbr47g== Date: Mon, 11 May 2026 14:32:10 +0300 From: Mike Rapoport To: Pratyush Yadav Cc: Pasha Tatashin , Alexander Graf , Muchun Song , Oscar Salvador , David Hildenbrand , Andrew Morton , Jason Miu , kexec@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/12] kho: generalize radix tree APIs Message-ID: References: <20260429133928.850721-1-pratyush@kernel.org> <20260429133928.850721-2-pratyush@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260429133928.850721-2-pratyush@kernel.org> On Wed, Apr 29, 2026 at 03:39:03PM +0200, Pratyush Yadav wrote: > From: "Pratyush Yadav (Google)" > > The KHO radix tree is a data structure that can track the presence or > absence of an arbitrary key, with nothing inherently tied to KHO memory > preservation tracking. This was one of the design goals of the radix > tree. This was done to enable it to be re-used by other users of KHO. > > Despite that, the radix tree APIs are very closely tied to KHO memory > preservation tracking. Adding a key is done by kho_radix_add_page(), > which encodes it as a page tracking operation and takes in PFN and > order. kho_radix_del_page() does the same. These functions encode the > key internally that goes into the radix tree. kho_radix_walk_tree() does > the same by baking the PFN and order into the callback arguments. > > Generalize the APIs by taking the key directly and doing the encoding at > the callers. Rename the functions to kho_radix_add_key() and > kho_radix_del_key(). In practice, this removes a line each from the > functions and moves the encoding function call to the callers. > Similarly, update kho_radix_tree_walk_callback_t to take the key > directly. > > To keep the naming convention clearer, rename > kho_radix_{encode,decode}_key() to kho_{encode,decode}_radix_key(). > > Signed-off-by: Pratyush Yadav (Google) > --- > include/linux/kho_radix_tree.h | 18 +++---- > kernel/liveupdate/kexec_handover.c | 76 ++++++++++++++---------------- > 2 files changed, 42 insertions(+), 52 deletions(-) > > diff --git a/include/linux/kho_radix_tree.h b/include/linux/kho_radix_tree.h > index 84e918b96e53..f368f3b9f923 100644 > --- a/include/linux/kho_radix_tree.h > +++ b/include/linux/kho_radix_tree.h > @@ -85,7 +85,7 @@ static struct kho_out kho_out = { > }; > > /** > - * kho_radix_encode_key - Encodes a physical address and order into a radix key. > + * kho_encode_radix_key - Encodes a physical address and order into a radix key. Let's keep kho_radix_ prefix for namespasing please. This is the common practice these days. > * @phys: The physical address of the page. > * @order: The order of the page. > * ... > @@ -144,24 +144,21 @@ static unsigned long kho_radix_get_table_index(unsigned long key, > } > > /** > - * kho_radix_add_page - Marks a page as preserved in the radix tree. > + * kho_radix_add_key - Add a key to the radix tree. > * @tree: The KHO radix tree. > - * @pfn: The page frame number of the page to preserve. > - * @order: The order of the page. > + * @key: The key to add. > * > - * This function traverses the radix tree based on the key derived from @pfn > - * and @order. It sets the corresponding bit in the leaf bitmap to mark the > - * page for preservation. If intermediate nodes do not exist along the path, > - * they are allocated and added to the tree. > + * This function traverses the radix tree based on the key provided. It sets the Nit: @key here and in the comments below. > + * corresponding bit in the leaf bitmap to mark the key as present. If > + * intermediate nodes do not exist along the path, they are allocated and added > + * to the tree. > * > * Return: 0 on success, or a negative error code on failure. > */ -- Sincerely yours, Mike.