From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vs1-f47.google.com (mail-vs1-f47.google.com [209.85.217.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E24A037A4B8 for ; Mon, 11 May 2026 07:24:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.217.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778484251; cv=none; b=mGBFFQjzApQTiYOpBxSL/Vz6S9KViRIqIHEvGh9Bp4R2fkSb7g7d+IGYlZUaj6O/3Ao8AcRzITKnGMGVCs8B8OhikrqeYWJYMQ/dDMWwFV/iaYnqE6Wr2AlGlD5soTiCvR417Q18Z2Oqr9FcsMlryWTXWhfuUPw2EjKPNbTJ0lQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778484251; c=relaxed/simple; bh=PP3r/MntpF6E2HPsEiAzHDByBUE9hdbpegtf7BYBCYg=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=Fy8hYK2q5GXt+wYOA0FGOQDOFtlYiYxdP1ANcUX080RlLHeApfEOv9SM4EpForQ8E+n742RzslEc8J95FkuHY3aUkfCbvAlilO7ijjm1ewAUdkTV5UmVFPny+GupW3W6vYbONEqZZ4ljP7aWjflBIaMWq1AREmitn/KWKeKgwHA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fZuHXl81; arc=none smtp.client-ip=209.85.217.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fZuHXl81" Received: by mail-vs1-f47.google.com with SMTP id ada2fe7eead31-6312bdd281eso2669247137.0 for ; Mon, 11 May 2026 00:24:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778484249; x=1779089049; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=HyHzPHZyzl+Vg43QcI8DAMEIEZeDqaoxRsbf4hAiXOc=; b=fZuHXl81vtNLXxdpgEQfODoCcMfzEgRoAV9PXMqww8xcNeWt+PppxdY04GfYJQ2N1m 90Qb8sxD6D0deFiv2Lj//01/JK/bSyaVpj+307ne5j53NP5+IFomHVq5Q2NZbh07Gr5R pBM1bFzUlGLIFIyK1Dl9+G7LKeeNDyfySplL7cSBWndMe8cCOHc3LR+nBQ9IiA+FQUJe cJoiVWW42oS0Zgwej+gb87CGC6bJCziF/9o1ymwiDYcmAkGz1rm/hfAvI6euKIzaGGRs l5rbIQ9a4zBffIJXmE6b/JX7ZrO2/+9CL9XdrFx1/UM6IcP7MAWgOgl2Q2qySWnxNZs2 /jLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778484249; x=1779089049; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HyHzPHZyzl+Vg43QcI8DAMEIEZeDqaoxRsbf4hAiXOc=; b=slbGmrMnwklTk3JsirG18Js2XClNd+dwqBMvyCZ/81fjkYLmg1N6p92Lh8jQUfS35g +RPEVTgSLpvtzU8qjWb5WqHfKPca46bBpi1dG09MW6Kmf2pFJ35IbWhgouqaIbBe3hXg U6065RYBfGyFwaD3Aa+Ajq+H7h5F0MBRbOSdR9GLhzLl22xtU6LQ+YmadkXYbgXJLvcb GpgWnGcT/sRQE8JCJutMapg6eXsQJ8MU0ANjSL//9MVqlKqxjtAWrG4lF5Paron9WK2/ I7HHy0iZgBnU4ZJHEn+lh+lW7F5Bam8SWtJkHFJQoeXU/Sn8M/STfgmvMnVLQtkX8cBu 15jA== X-Forwarded-Encrypted: i=1; AFNElJ/snJMYtJt9QwLRdzIDz2NMb+t0B6jqMzSJrz6BxWhHbZWcX0eIptfYBKGuZQYzWySY+LuerqMIyn+KkSU=@vger.kernel.org X-Gm-Message-State: AOJu0YxsuMtZMbFRuJCkB/nkRd4JjPBcMRNEBp7RRbzW8bQz4c+V3QCF PIvq2/5NVqN54kEK62yMF1sivYYVGRCxzsRvHsDuTx4hrfsjWnXCR2WX X-Gm-Gg: Acq92OHOMYZHkCCEnC3F390FzzRSMVwFrrJjbkMWlovDtcvRMwglSailfzJUjKu8VCX ky4ujBKdwC1zQ5CJlBeNwBbVmKv6tToHdqwmIu1aSIMPuEJ6EEKlf3JfKAU+/s4swtj8rpLUH+u 2wNUnJCll0WIJnvDQsUJIZuEidvW1bHv4Yx2N/EMdewsUP7+HQXYQ0qz4ATzXvWcpCXO8WqykwA DuEezVejnwadIn0Lr62gM4wJZ1EMmpNUo9y0dxb2QqQ3KeJcJkoLaumoKyY2yu5CsBmp0rd0Ny4 uJQfNroBAWTKzo9Yq3nD3iqw0QT7s6tVNsFu22XwnVvFOUGO3Gs1fxJ2bP1ZO+p+Qt5ra8BYcau QBSKW1IylbKsIb2xUG8PkZmuxy0QEDcp2R3R4kVPsUDjz2nsjwJXys56/UkRgLcNP4YZt6z/tBv tQol4lDKyJ5/IKDCTLhkMParccWZ+7 X-Received: by 2002:a05:6102:508b:b0:632:b111:965a with SMTP id ada2fe7eead31-632b1119b04mr1737026137.11.1778484248846; Mon, 11 May 2026 00:24:08 -0700 (PDT) Received: from localhost ([185.141.119.51]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-63140250725sm5583359137.12.2026.05.11.00.24.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2026 00:24:07 -0700 (PDT) Date: Mon, 11 May 2026 10:24:01 +0300 From: Dan Carpenter To: David Howells Cc: Marc Dionne , linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] afs: Fix error code in afs_extract_vl_addrs() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding The error codes on these paths are only set on the first iteration through the loop. Set the correct error code on every iteration. Fixes: 0a5143f2f89c ("afs: Implement VL server rotation") Signed-off-by: Dan Carpenter --- fs/afs/vl_list.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/afs/vl_list.c b/fs/afs/vl_list.c index 3e4966915ea4..003889cf0f18 100644 --- a/fs/afs/vl_list.c +++ b/fs/afs/vl_list.c @@ -92,7 +92,7 @@ static struct afs_addr_list *afs_extract_vl_addrs(struct afs_net *net, { struct afs_addr_list *alist; const u8 *b = *_b; - int ret = -EINVAL; + int ret; alist = afs_alloc_addrlist(nr_addrs); if (!alist) @@ -110,6 +110,7 @@ static struct afs_addr_list *afs_extract_vl_addrs(struct afs_net *net, case DNS_ADDRESS_IS_IPV4: if (end - b < 4) { _leave(" = -EINVAL [short inet]"); + ret = -EINVAL; goto error; } memcpy(x, b, 4); @@ -122,6 +123,7 @@ static struct afs_addr_list *afs_extract_vl_addrs(struct afs_net *net, case DNS_ADDRESS_IS_IPV6: if (end - b < 16) { _leave(" = -EINVAL [short inet6]"); + ret = -EINVAL; goto error; } memcpy(x, b, 16); -- 2.53.0