From: Andrea Righi <arighi@nvidia.com>
To: Tejun Heo <tj@kernel.org>
Cc: David Vernet <void@manifault.com>,
Changwoo Min <changwoo@igalia.com>,
Emil Tsalapatis <emil@etsalapatis.com>,
sched-ext@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 sched_ext/for-7.1-fixes] sched_ext: Fix ops->priv clobber on concurrent attach/detach
Date: Mon, 11 May 2026 09:52:13 +0200 [thread overview]
Message-ID: <agGKravM1oHxiA-V@gpd4> (raw)
In-Reply-To: <0dd41fa159da749a1e3ea88cfdbcca17@kernel.org>
On Sun, May 10, 2026 at 09:47:52PM -1000, Tejun Heo wrote:
> Hello, Andrea.
>
> Applied to sched_ext/for-7.1-fixes.
>
> One followup if you have cycles: scx_alloc_and_add_sched() can still
> fail after rcu_assign_pointer(ops->priv, sch) (sub-sched
> kzalloc/kstrdup and kobject paths). With the new gate, that would
> leave the kdata permanently -EBUSY. Could probably be addressed by
> clearing @ops->priv on those error paths.
Ah! Makes sense, I'll send a follow-up patch.
Thanks,
-Andrea
prev parent reply other threads:[~2026-05-11 7:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 6:18 [PATCH v2 sched_ext/for-7.1-fixes] sched_ext: Fix ops->priv clobber on concurrent attach/detach Andrea Righi
2026-05-11 7:47 ` Tejun Heo
2026-05-11 7:52 ` Andrea Righi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agGKravM1oHxiA-V@gpd4 \
--to=arighi@nvidia.com \
--cc=changwoo@igalia.com \
--cc=emil@etsalapatis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sched-ext@lists.linux.dev \
--cc=tj@kernel.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox