From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DDEA3B9DA0 for ; Mon, 11 May 2026 08:15:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778487305; cv=none; b=An8d4nYGNKKHQNeNFIk15goxbnNNFI9e1GE5vCBtPIiAY6+Y71zSfn6aMJTyKCasJOMXFDe+uf3bb0XAGq7CW9DHNqTWI3R941KPYUemy2C/vCufB9W271gNIpjcfWc4/GS0zEm23if+6fi0+1LFIG/JMAAwHPhc8f2AUR1QsAQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778487305; c=relaxed/simple; bh=LqKogGNmtlMcPmirl4G0HE70pvUVOB5Eux7PViHW0Rc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=a/jKcDrtjGWe/ZB6YyaMAxPY2YHyRFeDbzafdsnvDDYFoAjcwrgTbD5YDeNo8hhpz062pE9KQXrO+omXoAFHV56520HtMEz44u5hPyB8KJCnqlpoNQzuhRwZQJKUu1HpG47yRu7DvVnxOHjutdlJJJfqswbR2u39XI7yB72bYXs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=ir42KuzD; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="ir42KuzD" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fSr+jG7w28PBK0QLpfOlYmN+owMnjbiSdp6FTfFlFWg=; b=ir42KuzD/J3eBKs7FsWEhZRRw+ XPpTES8RZ9LMEkSO/LZhulZ0YgZyqhE6vDs1zohFPrpwIylVylLonqvt/tomQg+yZEKpHcjCvzqHN A9pyW3zjlIqt/3LuYabybdBl/8UoTgO5AXK00hZx6DVpM8xVQHnH5hCOJHnlqj6ewBOGXJDmmehcq 8Kuk1NqNX7m8FeHQuujH2v6pU2CXslQKgasTAHenrTh+kL2jnpPbPAgblRSHIPXhPEabFiQF+cwil o6chUJtPTKh3j9uQu4kyQkC4QxaKbHaYrbFab1rjOzQ0TpojLIPx99DrrZSHnbhKg5eqj8hKWsDDT EgD0W/HA==; Received: from hch by bombadil.infradead.org with local (Exim 4.99.1 #2 (Red Hat Linux)) id 1wMLmz-0000000Cj9J-0KXt; Mon, 11 May 2026 08:14:57 +0000 Date: Mon, 11 May 2026 01:14:57 -0700 From: Christoph Hellwig To: Rohit Chavan Cc: Christoph Hellwig , kbusch@kernel.org, axboe@kernel.dk, sagi@grimberg.me, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvme: use str_enabled_disabled() for digest mismatch messages Message-ID: References: <20260508094734.2032284-1-roheetchavan@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260508094734.2032284-1-roheetchavan@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Fri, May 08, 2026 at 03:17:33PM +0530, Rohit Chavan wrote: > Hi Christoph, > > Thank you for the feedback. > > My intent was to align the code with the standardized string helpers > recently introduced in the kernel to reduce open-coding. However, > I respect your preference for keeping the ternary form in the > NVMe subsystem. I guess it's more of a question for the people adding the helpers, but it should also be in any place converting to it: what's the point? The helpers don't reduce the code size, but increase cognitive load. Not a good trade-off as far as I can tell, but maybe I'm missing something?