From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 666563B776F for ; Mon, 11 May 2026 08:16:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778487409; cv=none; b=Kd8WE0t4CVglAIXBF9tRi615uz+BXSRvDZ6B3RkKEXe0GSLdKIAlcNpgOYjNxjnAjDwpiMRGq2wJf+Cs7ukHDFGfLLa7HcBNRjP0xN9JNgSNO+XUUmXVzzYcmBf57/9RoCHOOZfrCKBHWB4jBKnCeTZgpAl5ogbeWcH3ZIxJOGg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778487409; c=relaxed/simple; bh=YtLBSH2L0Jb3/Z9vPIvhlNgSxfxwvMOZemPH81KphkY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=H2H4SZXTwbhOqM9nupgJmqpNVIoJ2oQM5ePlMyJ5IUtPupD0jlbXYIES6dT24HUmSbwfEN3zPQNczUV2+WbLYFBSsQeslBXXuHiz40SznTZH3QNT3oaSxgUAnIFcrMNLA9jHquA80FSQ2iLyF85WW/ZKBjgSNSSl7bSfCeyvsBg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=hno80n1s; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="hno80n1s" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=rt78FZAYKe0gz/4zfRjF4IigBBCZLzvejiqCOF4t7eo=; b=hno80n1s54JvPBsOphbllzUE7w fWZd3q/H0wrM72vF4SBTJHihkd49LpdfVhgx9dXLWDLug7AgehZWrcqR4tNj6NhOkZqnLBemgoZ/Q 8VhmP+Va/pWp9kPN7kOt3dAZ5oOAEQc7inLY+C7gEqWzlSHA8/n5coUTWiyZ9o8sT/n95wuWCMxtw JmXRzo4wWv7HzZcIe97B5KDPjiaru98o3xuE5TE92u5rksG8dWJTn8MW+YfosfMUNkI/uQoR84RDi AhJ4O+cOLjs7XuaGVjmouIshf4Qs7Mt7d4dGyXQpci6dosRmOSl8kc1A49oRd/JtPgxfaQ/DkWQmz LsXvxu0g==; Received: from hch by bombadil.infradead.org with local (Exim 4.99.1 #2 (Red Hat Linux)) id 1wMLob-0000000CjVL-2MDJ; Mon, 11 May 2026 08:16:37 +0000 Date: Mon, 11 May 2026 01:16:37 -0700 From: Christoph Hellwig To: Sagi Grimberg Cc: AlanCui4080 , linux-nvme@lists.infradead.org, Keith Busch , linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvme: make providing NGUID as UUID usage less scary Message-ID: References: <73735bc1-9821-42d8-9594-1e9cdb03e15a@grimberg.me> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <73735bc1-9821-42d8-9594-1e9cdb03e15a@grimberg.me> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html [the patch seem to be missing some maintainer Ccs] On Mon, May 11, 2026 at 01:19:59AM +0300, Sagi Grimberg wrote: > TBH, I'm not sure why should this be a warning or an info log. This looks > like a debug print to me. It is worse. For some reason the commit seems to imply the uuid replaces the nguid and they can be intermixed. We really need separate sysfs files for the different ids. I gues we need to keep the existing one someone, but it is a mess.