From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37A3B3C9EE0 for ; Mon, 11 May 2026 09:04:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778490280; cv=none; b=QkjFkQePhIJNGD0xhfBbWSKrwhWizirXy43PdykFBYP5MZJUuvLsvYvshnAadFZz7C5ra9MJJbMvIJ2EV20oPNuPtwIWaWlcbFDHgqdVo+U46BgP4PE4YA6gPzgwPPydPQbqHlALgOS/2pUxtEDbmdb4qbw6XhI1Cz8hbPbsgP8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778490280; c=relaxed/simple; bh=PHxUt/BZu52hBJ0XvILTIVRCCcetLa5BJqJayAfrFGk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Xz3fKZAmkyYGS1HxuiMQfIH/4MwWcQ9So9eOxAChAp1b+/1WDfPGR8IR4Eb70ss1UYCQ/6uSo7MxxfhE4Ka/BFT/07RsUHcqfTD+viSV/UIEnIaf+YS8u0wM2RHXAF5600hvGannDT+CVaD+tGJokxOYM3pmgVqyyDfRWdau+yk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b=ueOAiMa+; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b="ueOAiMa+" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-488a9033b2cso37135305e9.2 for ; Mon, 11 May 2026 02:04:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1778490278; x=1779095078; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=utQ0vZd/0ZuAF7qLGsuvxMQfxP2a/tog8cwQawZr+Bs=; b=ueOAiMa+Av9mJFWvTt2SsaZXwNtVzDNeAcOfxJXcY4uJxQbnJ9xXNAbQLoV/pq6wsy wv9DXXLDLNWpBXMpaHG7oKDr4mDt7WLG8igwAVNnak9uld2pqT3Mvuc9nFY3X/b2qxP/ b83yjc7lWJZt9Yb1yrCosKMrzfLo/M2RZqBeYxvFAp1YufGA5XKCq0PN8Wwxy9RLir0j 4epGu6+llW+n5Bn4iULiOaqESx7yqnKGerE6a/thTvfewsfr5b96/ty+MvHRdEZssz1X uefnoaXmeL/kQp8Dma15Xph8iBR+niiIFyslGdBXo1acWgiXGLsUaA1E4BMKa9POOTg6 0MsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778490278; x=1779095078; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=utQ0vZd/0ZuAF7qLGsuvxMQfxP2a/tog8cwQawZr+Bs=; b=oR67jOuZqetVw1+r3O1NHCCudtGHaZx+W/jMJgsMT+vwzSt7kGlAlCQi5KGvofpsDh 8Q8qrHMAqjzBxFP+3FJ1Vi2UmRka1VHKJx886Yzdo6iZoYZzDkqd1vFIlxpfGhV3vEq7 HwhfcVN9Iv4xVFI/iRn8v2cV/InlOdwskw83EziVzbIC+jDIexDqKCmecmqVqhX/yIJe OJlFP2+eT+cA5EYIV6lPwf+9CJy/NBOxPn5ISmP4mdnKlfwxhRwSjCpnFGTMZ+z0xwEO iT4ePGgqcMe8UiYyLLNqZV9TinRgrKdGofNyB4oAWruxc3avLajrAzD3UbymvweElPFc PeIA== X-Forwarded-Encrypted: i=1; AFNElJ+iNW7CBiKuqOoJYRUZazQI4ts0EXyqAF8YS1ARhXr6qJoveji/Ask4lg7IZmd23MSGfvL75l1j0SJTh5s=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2tEEkr7oE/7J2ekucbMnVVUaQ9CSmFwDvDLhpr5CV7M7r7VKO SPS86v2HeJSmkCE//5azXSIsG2nlqTHGnQtHnteg04QTA3GDPq2IKTvSwUJlaniqSZ0= X-Gm-Gg: Acq92OHz8br4ylbCpOQp9v4DkvYzravM7pH+IRw33vcZBEv1mWBpNhWvKtjV4egXjc3 bzhh6qw+samEz4sNLjINbelQfag/xwdsrHMOtdi29qmCEEyafWHiB8V/7XLO8V9wa32Xp/ySM7e OxoHkbQMBVmpzS189+9R0MWnKAIhxUemD3aqo5T16nYqD0x3OuerTGvE8LRZmItj4eMsJAkKU50 Ks4X7NQtjF1AxIrt3sdTZfW1fU7GQY81jlOuOq9Wm728tnPaX+m4LrAPlAp+TSChrWrtzXLYM2N UTKLW1Sd1MA0PEUof9MZQmfmWM2ATI7+UhcKhkUgQfCPFOHC0jm8nDboa0XnYxMTXkVtUR0GUbS af6z82VVuAd8/bVYtYbmGZvG2pT91QEQukbZ229k5/rMgV3GEbgBnBzxuWj9ZEURxcU2YK0KIof iea+iN2yf5s/PeDqJgM9IgMLTx5lFo+OR4yK/7PwQADoHh3+/6HUZw6Y815Ozeg921fZgr3G+BE eHkKaglv/5E9Ng= X-Received: by 2002:a05:600c:698d:b0:489:1ba8:5be9 with SMTP id 5b1f17b1804b1-48e706f0e53mr148064525e9.29.1778490277681; Mon, 11 May 2026 02:04:37 -0700 (PDT) Received: from localhost (p200300f65f114e0841c796eda31a14b3.dip0.t-ipconnect.de. [2003:f6:5f11:4e08:41c7:96ed:a31a:14b3]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-48e702e0c70sm189944335e9.6.2026.05.11.02.04.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2026 02:04:37 -0700 (PDT) Date: Mon, 11 May 2026 11:04:36 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: "Markus Schneider-Pargmann (The Capable Hub)" Cc: Marc Kleine-Budde , Vincent Mailhol , linux-can@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] can: m_can: pci: Remove driver_data Message-ID: References: <20260511-topic-mcan-pci-driverdata-v7-1-v1-1-9b7161c1d1ed@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="x4gihwp3dlwocsjd" Content-Disposition: inline In-Reply-To: <20260511-topic-mcan-pci-driverdata-v7-1-v1-1-9b7161c1d1ed@baylibre.com> --x4gihwp3dlwocsjd Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH] can: m_can: pci: Remove driver_data MIME-Version: 1.0 Hello Markus, On Mon, May 11, 2026 at 10:49:16AM +0200, Markus Schneider-Pargmann (The Ca= pable Hub) wrote: > @@ -183,8 +183,8 @@ static SIMPLE_DEV_PM_OPS(m_can_pci_pm_ops, > m_can_pci_suspend, m_can_pci_resume); > =20 > static const struct pci_device_id m_can_pci_id_table[] =3D { > - { PCI_VDEVICE(INTEL, 0x4bc1), M_CAN_CLOCK_FREQ_EHL, }, > - { PCI_VDEVICE(INTEL, 0x4bc2), M_CAN_CLOCK_FREQ_EHL, }, > + { PCI_VDEVICE(INTEL, 0x4bc1), }, > + { PCI_VDEVICE(INTEL, 0x4bc2), }, nitpick: typically the trailing comma isn't added if the closing curly bracket is on the same line. Otherwise looks good to me Acked-by: Uwe Kleine-K=F6nig (The Capable Hub) (even if you keep the patch as is). Best regards Uwe --x4gihwp3dlwocsjd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmoBm6EACgkQj4D7WH0S /k4bIgf/b7vATLUH2PX4AXOB3Rg+KjWJIpFW1M499smXTxdZoXUfCpE9ayiGwZqj UmZetzUQgOOq35kFz0110rxTkrxtZHyFngyxX46+gWdk2rOY9KKkvvSek/bCbg+x F9jARgjtKcXhUUh4BpTKfZ3GCdu/ekX5sTB718PSYqWwga6gQdnu4mdJ79ofkRXn csIIju4LP9zf9KM7ILIHhHhqbaHD4NaQGOZJ2vu6aiyaSyHW3+x2SuQ/ByfVwgEx 3RpxpyJw2RE4obqiqzNDkToqamm36yGeKSqzN4uQLl5xXgncmJP9v1o6DFtMKPx1 lZz1WcN9GmZ+MWTi3s3D/3YRoJb+uw== =/5zy -----END PGP SIGNATURE----- --x4gihwp3dlwocsjd--