From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AEF2364EB0 for ; Mon, 11 May 2026 11:48:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778500083; cv=none; b=UPIOQC30jBDw52t/2VF2J5IegTP7FlMAMEOFz63A6K8+2nudg+PXvEV+yviNyCmIapBQg6WLJ8N7Eb7FHQ242gmwE5uco+D/i/E3T/kCksklBcSa1gpBBYRMYc5IrW2ZxhWJuCwcE3/couPowRTr/BdsiGNcuWJdkV8YcwaeOi4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778500083; c=relaxed/simple; bh=a01/upDufgIp0Xjp/MMIPDmLlqZSzAcbtUi5lVWoWUA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mJILi3+70nyf60aiyBEfqfkJjwlaSsqLjGD9qunok74b7NIXDosSrrXx3LhTfRXaGEkPySTKujrG/VgPrVQANSm0WtXbLcjDTrZhkpFzja+iGCQ6d22kdxRpQ1h59nYA1SvS8fQXGITZS0pZNafrB8XnM+3sxc+8/hpC9o3BoK8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fe3xEr9A; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fe3xEr9A" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3223C2BCB0; Mon, 11 May 2026 11:47:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778500083; bh=a01/upDufgIp0Xjp/MMIPDmLlqZSzAcbtUi5lVWoWUA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fe3xEr9AzWihxUV7USwOkIUobn90Uj3D56rO9BWkXhDrKfIyqOmm0JdMCPqImocM2 bSMxBsQ2CEs13+7MgRHrC9PvJroEkc9lTzgFUIOQnGmQE/d+a+Y2cc9dtQ2LtjYNqO xUvVQFfwZxB8YLJDIy5vcdt+pnJ0M7kWsMOW+RXAtHf5m8KZgXFYUBJPXQPIb70kaZ yP1baEh3GJ3HRLWtGgG4OIR1iBcC9AtA/5yY2/esmrs5SXiMKuw1mmfvvm3qQUqWWG scRytITxa4q6GvG7pp3y1MvTMisYMf/NPl5QAUidcVOLRCa+B+QaLEWbrS5yYJjPXC RzaNwP62qDUFQ== Date: Mon, 11 May 2026 14:47:56 +0300 From: Mike Rapoport To: Pratyush Yadav Cc: Pasha Tatashin , Alexander Graf , Muchun Song , Oscar Salvador , David Hildenbrand , Andrew Morton , Jason Miu , kexec@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/12] kho: add a struct for radix callbacks Message-ID: References: <20260429133928.850721-1-pratyush@kernel.org> <20260429133928.850721-4-pratyush@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260429133928.850721-4-pratyush@kernel.org> On Wed, Apr 29, 2026 at 03:39:05PM +0200, Pratyush Yadav wrote: > From: "Pratyush Yadav (Google)" > > A future commit will add more callbacks for the KHO radix tree. Add a > struct for collecting the callbacks. > > Signed-off-by: Pratyush Yadav (Google) > --- > include/linux/kho_radix_tree.h | 15 ++++++++++++--- > kernel/liveupdate/kexec_handover.c | 29 ++++++++++++++++------------- > 2 files changed, 28 insertions(+), 16 deletions(-) > > diff --git a/include/linux/kho_radix_tree.h b/include/linux/kho_radix_tree.h > index f368f3b9f923..030da6399d28 100644 > --- a/include/linux/kho_radix_tree.h > +++ b/include/linux/kho_radix_tree.h > @@ -34,14 +34,23 @@ struct kho_radix_tree { > struct mutex lock; /* protects the tree's structure and root pointer */ > }; > > -typedef int (*kho_radix_tree_walk_callback_t)(unsigned long key); > +/** > + * struct kho_radix_walk_cb - Callbacks for KHO radix tree walk. > + * @key: Called on each present key in the radix tree. > + * > + * For each callback, a return value of 0 continues the walk and a non-zero > + * return value is directly returned to the caller. > + */ > +struct kho_radix_walk_cb { > + int (*key)(unsigned long key); > +}; > > #ifdef CONFIG_KEXEC_HANDOVER > > int kho_radix_add_key(struct kho_radix_tree *tree, unsigned long key); > void kho_radix_del_key(struct kho_radix_tree *tree, unsigned long key); > int kho_radix_walk_tree(struct kho_radix_tree *tree, > - kho_radix_tree_walk_callback_t cb); > + const struct kho_radix_walk_cb *cb); > > #else /* #ifdef CONFIG_KEXEC_HANDOVER */ > > @@ -54,7 +63,7 @@ static inline void kho_radix_del_key(struct kho_radix_tree *tree, > unsigned long key) { } > > static inline int kho_radix_walk_tree(struct kho_radix_tree *tree, > - kho_radix_tree_walk_callback_t cb) > + const struct kho_radix_walk_cb *cb) > { > return -EOPNOTSUPP; > } > diff --git a/kernel/liveupdate/kexec_handover.c b/kernel/liveupdate/kexec_handover.c > index 5758dc6fab5d..4a5d1b47799c 100644 > --- a/kernel/liveupdate/kexec_handover.c > +++ b/kernel/liveupdate/kexec_handover.c > @@ -266,16 +266,18 @@ void kho_radix_del_key(struct kho_radix_tree *tree, unsigned long key) > } > EXPORT_SYMBOL_GPL(kho_radix_del_key); > > -static int kho_radix_walk_leaf(struct kho_radix_leaf *leaf, > - unsigned long key, > - kho_radix_tree_walk_callback_t cb) > +static int kho_radix_walk_leaf(struct kho_radix_leaf *leaf, unsigned long key, > + const struct kho_radix_walk_cb *cb) > { > unsigned long *bitmap = (unsigned long *)leaf; > unsigned int i; > int err; > > + if (!cb->key) > + return 0; > + > for_each_set_bit(i, bitmap, PAGE_SIZE * BITS_PER_BYTE) { > - err = cb(key | i); > + err = cb->key(key | i); key(key) reads weird :) Can't say I have a good name, maybe key_action()? > if (err) > return err; > } -- Sincerely yours, Mike.