From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ua1-f52.google.com (mail-ua1-f52.google.com [209.85.222.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E2AE30E847 for ; Mon, 11 May 2026 11:46:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778499996; cv=none; b=QIzVdqJWvob+JD1uFFHFD/f/cl3el0TpAR5xXmSCGfWHeWUeM6qdne+ypDO7fH6SBv0+xbPLY9Qv0sNE5Fv9l/1tCdbBui2lr5e6FqLiiX4fjTcF/IFhRwj5Tam6W9NMZBqVi84tNeyAhgdxrZZi3kl9yDUOLIvX3lo/XzWn3qU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778499996; c=relaxed/simple; bh=pUAYSYUeKdjCjhBlXPieorkg7yLpWil/XC1QJ/SvyK0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kWQyMLACvYm0JFMSKN9w7d3D+7zfWKzOUYMZ8MOW+0645ky4sN9C62d88Bw47HHTGpwvGKAEOlIvy2J/TJLqPDrzSevH8At2AxvbzaMXsU2WU/UARESRL88nNmHlB51EQO05kiTdIVRx5NyG3EXkNp6LwZVwLbbsjbKlzQ9cX/c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ozYcfmRo; arc=none smtp.client-ip=209.85.222.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ozYcfmRo" Received: by mail-ua1-f52.google.com with SMTP id a1e0cc1a2514c-9567aa1a047so1160644241.0 for ; Mon, 11 May 2026 04:46:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778499994; x=1779104794; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OO1IEzTaFF0ZAn9uDb8SVLUtUYQAq1Vq135ZbGyORw4=; b=ozYcfmRoDploISJvgR25KCchdPjhuBFEGOTB60TqUrSaPSDKFJ45+gs3Bw3Xjk6Srg W9AS/MCcRrDn5CKaaPoI89wY53Zp5sk9f8wKPm0uuXJVJ2XBh0v4QwobNVTqrVw1ELUc xdR0ED6xbC3n8K6e3Lzgype9C4ABw5XF75Yop0bg0Z7rdzxk0UR41HR24PJ1mSnCQfiY OYHEFG3H7ssNFvXIFres/MMjGNd+zYiMp4thvWieCjK9z+ALd5+PUDi/z0t1fUJ9/Hop rpQRM3xpsJ46q/hx8A5vqyaq0kmuJf2CiGB7gipe2JgB6ClFXaK5dYFbkaJcRLvUCfMj W0Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778499994; x=1779104794; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OO1IEzTaFF0ZAn9uDb8SVLUtUYQAq1Vq135ZbGyORw4=; b=D/WtjyiuNidp3dN5VST3hYTmvyT7epF1+qF8b6tm/fBbzQzwPZAzUJjaayUW22vaWU 2S2O2fnecYkJiiOOmREga64raZoxWDAI9cPg1vVPobrwA2UYrQciknfPU9BTH1BaNaPg Om1Zegy6cVeqkXTTKdVJNdmrnQNRPqPVo9Nk3+c3JqDWmCBbsea1Q2Vsj5zUnaUaaVyp dNL5akH6pFXx9lCyCeocDkWWpJVzAuJ2cNobhzZ8cUOnIB5yV/hNNkRSuNFd0jmKVNNi UThRo8SPG4SCdV+f94icBC4jWRbAJT0Iwu9rC0E8fkevAHPNzjPtMQOsQVhl66GapeBj PyqA== X-Forwarded-Encrypted: i=1; AFNElJ/ddvIghdxrqOPgdimZZPOLbHKzX9C+uFL1ZpExvRuzeD5KMO0IHnmxy9WS4GCOHPHrX5uF9H3EVifk03s=@vger.kernel.org X-Gm-Message-State: AOJu0YxIcFGZlUVr3ilJwIh2xJ442cWKvtN91rWxeuCwAK5rLZwnLbek c+bksRtlJUCbHtBH65q80AbYWkeX5QvpfMraffEfMdw8PpnRlAmfrASS X-Gm-Gg: Acq92OGUi/1QaLaUpJI0gOPs1YTpjHeBLO9lBryE/P8qOjbnj1Pu1LZJvMxOf3psQO9 a2bmFqhP6syiVh/7GuPz1lHIOu7206NQ2tQ0A7Psv+IVPx0NwLLCZxet/oB4El07L/ZLxEAxxYL F533HV3WnnzMzaVFOwTnR6tXih0mQEOZ2rGPauH3NDfMtHz22j4H+uhf1UNWOZjC+uraPhiC3PT 2+GD7GrgQYZTrf+TqBptr47T+8qSh7qP38L2ifs9WYjDdL2NoZe+7V4bqgWHL0Ph84MAKMmje7J qZB14ExDFNoeELX6D9YtPjwpRx677NIK9ZLhdXlM7w7vl941k0H3M8FK0zLc7DMVF+Cf8gnkas9 CAlddimOBIenK4pmjbdr/9+xyvv1BXmBCLhV7EQzls5FAqbBfsYUIaWMAadZX401HngL/sIv5yy wbpRtCuW8dbIXGio+1kUZ90iEBrFij X-Received: by 2002:a67:e7c5:0:b0:631:487a:23ab with SMTP id ada2fe7eead31-631487a27f2mr5386588137.5.1778499994324; Mon, 11 May 2026 04:46:34 -0700 (PDT) Received: from localhost ([185.141.119.51]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-6314005a6acsm5701621137.5.2026.05.11.04.46.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2026 04:46:33 -0700 (PDT) Date: Mon, 11 May 2026 14:46:28 +0300 From: Dan Carpenter To: Harshit Shaw Cc: deller@gmx.de, tzimmermann@suse.de, chintanlike@gmail.com, andriy.shevchenko@intel.com, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: fbtft: check return value of device_create_file() Message-ID: References: <20260511100140.4794-1-shawharshit116@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260511100140.4794-1-shawharshit116@gmail.com> On Mon, May 11, 2026 at 10:01:40AM +0000, Harshit Shaw wrote: > device_create_file() can fail but its return value was being > ignored in fbtft_sysfs_init(). Check the return value and > emit a warning if sysfs file creation fails. > > Signed-off-by: Harshit Shaw > --- What's the point of this though? How is your warning message more informative than the warning messages printed out by device_create_file()? regards, dan carpenter