From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 629AD33ADB3 for ; Mon, 11 May 2026 13:21:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778505700; cv=none; b=QAyqostNxVf9w2Qg5IThOms8LZicH1lK6cbxSZqfi6qPdOGRtW0qQYT/GpQqgELoOFVMT5H/3/FqngZX3O1GgNcEo4e21tOzlvE8kZZu/GqMk+CkqMzsttqrdC1Kw/IaSd0rqf0VWUl3EgL5/05JUTfqoAOdc9CC5LKwA06u1xc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778505700; c=relaxed/simple; bh=TVx456v4bPVt5hN7INd320N3ng06cE3ZqomA3NeIx0M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Gs1GZCh5xITKYzJl/dGqLTg2ZzKKN7ekPfUgQRAVsGqLAY8cbBCtrCejz6rYd9mfxyIDc9Wo6db9NJv9nYda+aVVuzUZV1fmQSCRGwSHCL/BqL5ve0xu84oeMpoSQQpAZuhbZ1ifuD99nC2THGmV6BqWHWxxjfsaPyE92a3Cfx0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=cjH50qdU; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="cjH50qdU" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2b2e8b95bdbso155ad.0 for ; Mon, 11 May 2026 06:21:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1778505699; x=1779110499; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=odoNhC1jkxHEmpElHSk6/Y6iPKFT+XGqoxzHTbmY1lw=; b=cjH50qdU9EuKFj5eIicCARpiflwYN5hEjnPSkzll9Unr1vVUA+6bLwH4WDfzStd22B vz6eVlHyNrxdRirYJ7z68RWFtVbGQ+bsUN/jrxh1Lkm5Cm5NuWsvUnFgdihbJZ8I6CGy NpuJcox9IVeTOWzyicb0QW6jwyosvlJK3drizsZ5XDX+1sVV8gfCvluU1Er4bDPwdlpt 56p59x9dPZSm90Opi2Rq8XRpxvwm0dVTHUkQqyBHJh7d84mrRgm7Y24FAkyaPx55MpYC CtEd/qWW/uoCjTMPEiyc7W1b/MDdpYTUb+P3wK0A5JcEwJQwzkliJQEfecuxvedaDEgg 4WUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778505699; x=1779110499; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=odoNhC1jkxHEmpElHSk6/Y6iPKFT+XGqoxzHTbmY1lw=; b=JLxsgDGlxErmd/RyhxUmh08U0ytkDUGiF8uHz7pdFPWTvYET5FErCMixryQPuXf8s/ n/EQH0UD579TZ55zL1z6Z8ijAna/mOZgF1Kdd2gX40el8dagz8D46mgCxcSjP/r8h3CE H0hvut1Smsu0WY6VbVLXc4tF59yET5ybVMDM1BPQWAh5jWUTd9FrbuJBQJMpxD/x3/B8 wfxMfmW4OgQBt4ivC96lEka4IK6BCqW3A9i8Rh0WWCpzxSXFGFdsuac26ewyQtM92Uba DOLJyiHxCQA4Qmgptw8GF8VLAonBkIez/CWqCwcuAeAxsKFiVm5BLExXOhq6l46LHfuX ZqhQ== X-Forwarded-Encrypted: i=1; AFNElJ9VAmWIzxooRRAk8uxDPVhO4AnTIxcpNz8muxl9PTCoalsGqi4u1oa2ZXfy0WPq5X1/Hw2jFeBZAOV8eFA=@vger.kernel.org X-Gm-Message-State: AOJu0YyhRHNp0vNi91OjljEPqKvXxA8W7k2Cl1K6KwdmSUZ2/5p2iZ5M XlLs0dizDcvlpM9lLU6Nyg1VkxKoTgGk8qwaQo+vpOlc62+l77qxf/7T89llILmtdg== X-Gm-Gg: Acq92OEbBsNEBhycLG3RoOWiXhFVQy/biIISn+ZiBlRihpwXT0IJ77mBMh8OT9C7dVB 1pEID8OoABGeXxrYPPWG3gSHijxYRIhTMcBZmLKoBMms4y5JRK4fPu0PJC4w2EG0JGzcWAUGUcX j4DMU4cA3V9e9GcFXi07yxF5B5oPSqm7ySgnZFQvi76X1E5o6CHDFk5MMqgxRTNXQw5mBm37WgH OYm16DvTI3+VGNgfgiN1Xwv4d14rIB7IMIWz5IFVumtVAma0N7Wb6dpph1fV52asxBjxvDw8RRU Mx2+X6WjA7RSGmOa8beB/1Yu0e0EE4nfW09OJV079E39hsXv8PTNyfxMj+k59k9gvUPLpbtkisB MAVnkpuySjAJuv41OS/TJFE6V0S7YP1vBC786QVnHZtRbhAWVu41RsxKtBR9xWiZM4f81qU1pWZ WiwnzXniY9RFCW51G3zFV0Sw5fTFP6H/kVws3OR8sU7Eqovv65KZsqZ+sA9hY/aHWUC4Ms X-Received: by 2002:a17:903:1666:b0:2b0:5c88:51e1 with SMTP id d9443c01a7336-2bc747c1c17mr5151525ad.14.1778505698122; Mon, 11 May 2026 06:21:38 -0700 (PDT) Received: from google.com (44.234.124.34.bc.googleusercontent.com. [34.124.234.44]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83965a3e3ecsm20960916b3a.19.2026.05.11.06.21.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2026 06:21:37 -0700 (PDT) Date: Mon, 11 May 2026 13:21:31 +0000 From: Pranjal Shrivastava To: Robin Murphy Cc: Jason Gunthorpe , Nicolin Chen , Will Deacon , Joerg Roedel , Jean-Philippe Brucker , Catalin Marinas , =?utf-8?Q?Miko=C5=82aj?= Lenczewski , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/arm-smmu-v3-sva: Enable Hardware Access and Hardware Dirty bits Message-ID: References: <20260503135413.1108138-1-nicolinc@nvidia.com> <20260508123550.GB9254@nvidia.com> <4e129891-2f52-4bac-8e33-1fdde42fd29a@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4e129891-2f52-4bac-8e33-1fdde42fd29a@arm.com> On Fri, May 08, 2026 at 03:24:32PM +0100, Robin Murphy wrote: > On 2026-05-08 2:57 pm, Pranjal Shrivastava wrote: > > On Fri, May 08, 2026 at 02:31:11PM +0100, Robin Murphy wrote: > > > On 2026-05-08 2:12 pm, Pranjal Shrivastava wrote: > > > > On Fri, May 08, 2026 at 09:35:50AM -0300, Jason Gunthorpe wrote: > > > > > On Thu, May 07, 2026 at 10:30:14PM +0000, Pranjal Shrivastava wrote: > > > > > > > @@ -92,6 +92,16 @@ void arm_smmu_make_sva_cd(struct arm_smmu_cd *target, > > > > > > > target->data[1] = cpu_to_le64(virt_to_phys(mm->pgd) & > > > > > > > CTXDESC_CD_1_TTB0_MASK); > > > > > > > + > > > > > > > + /* > > > > > > > + * Enable Hardware Access and Dirty updates (DBM) if supported. > > > > > > > + * This is safe to enable by default, as PTE_WRITE and PTE_DBM > > > > > > > + * share the same bit. > > > > > > > + */ > > > > > > > + if (master->smmu->features & ARM_SMMU_FEAT_HA) > > > > > > > + target->data[0] |= cpu_to_le64(CTXDESC_CD_0_TCR_HA); > > > > > > > + if (master->smmu->features & ARM_SMMU_FEAT_HD) > > > > > > > + target->data[0] |= cpu_to_le64(CTXDESC_CD_0_TCR_HD); > > > > > > > > > > > > IIUC, we should be setting these if IO_PGTABLE_QUIRK_ARM_HD is present? > > > > > > > > > > SVA does not use IO_PGTABLE at all, and it directly constructs its own > > > > > CD. > > > > > > > > > > No relation between those two flows. > > > > > > > > I understand that but I mean we need to know if the system supports > > > > HTTU ? Like for SMMU we use the IO_PGTABLE_QUIRK, shouldn't we be > > > > checking if the CPU's tables support HTTU? > > > > > > > > Are we assuming that if the SMMU IDR presents HTTU capability the MMU > > > > would also have it? I think an unconditional enablement is risky as we > > > > may not have system-wide HTTU support. > > > > > > > > If we look at arm_smmu_master_sva_supported, the driver already > > > > maintains a strict agreement between the CPU and SMMU for SVA. > > > > It checks sanitized CPU ID registers for things like PARANGE & ASIDBITS, > > > > and it uses system_supports_bbml2_noabort() to decide whether to enable > > > > FEAT_BBML2. > > > > > > > > Shouldn't we follow this exact same pattern for HTTU ? > > > > We should probably be checking cpu_has_hw_af() (from asm/cpufeature.h) > > > > in the SVA support check or here if we wanna enable HTTU. > > > > > > It might make sense to depend on CONFIG_ARM64_HW_AFDBM - when that is > > > enabled, then IIRC we already expect to cope with some CPUs not supporting > > > hardware updates, so it should still be fine for an SMMU to make them even > > > if no CPU does. However, if it's disabled then I'm not sure if missing > > > access flag faults (if SMMU HA silently sets them) might be an issue - for > > > dirty, we'd just never put down the Writeable-Clean permission so enabling > > > SMMU HD wouldn't do anything anyway. > > > > I see, so IIUC, you mean if IS_ENABLED(CONFIG_ARM64_HW_AFDBM) but CPU > > doesn't enable HTTU, it is perfectly safe to let the SMMU do HTT updates, > > Since the fault handlers are already expecting HW-triggered updates? > > > > Which means our check would be something like: > > > > if (IS_ENABLED(CONFIG_ARM64_HW_AFDBM) { > > if (smmu->features & FEAT_HA) > > ... > > } > > > > instead of cpu_has_hw_af()? > > Hmm, looking closer, cpu_has_hw_af() is the thing which actually influences > mm behaviour (via arch_has_hw_pte_young and arch_wants_old_prefaulted_pte), > and that can still be false at runtime if ARM64_HW_AFDBM is enabled but any > CPU doesn't support HAFDBS, so perhaps you were right the first time :) > Yea, I believe the cpu_has_hw_af() is the right gate. > Although AFAICS from __cpu_setup(), ARM64_HW_AFDBM will still > unconditionally enable TCR_EL1.HA on CPUs which do support it, so maybe it > is OK anyway? > I believe cpu_has_hw_af() is still the safer gate for SVA. While individual cores might turn on their local HA support, cpu_has_hw_af() represents the sanitized system view. In mismatched systems (where some cores support HAFDBS and others don't), cpu_has_hw_af() will be false & mm shall default to software-managed AF/ Dirty for consistency across all threads. Enabling HTTU in the SMMU while the kernel mm is in 'SW-Managed' mode could cause the SMMU to silently flip bits that the kernel is expecting to handle via faults, leading to a mismatch. Thanks, Praan