From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-a4-smtp.messagingengine.com (fhigh-a4-smtp.messagingengine.com [103.168.172.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8FE633F59B; Mon, 11 May 2026 13:50:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.155 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778507451; cv=none; b=MJxU6Uq5ZX3v/EwD9NLX9YSCaW8oKGSwK9DfmO2EZlZtENlXD1f1q558BkgRmjhKE/ctKPkQErVMMFYuylLMlTWksIytQ345XFrxKHQZxwDu6G1rSaIX8zBpsCPuffihoEUdR7YlJdeFAiDiUub6yVBcpdvosoWvVEyMn3vQ1So= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778507451; c=relaxed/simple; bh=yAXhKQdTAuajKq+KiH4HBZ9PTBZlzMdMt7oEXvNI53w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Em5nBf9PORJPp9z/HUfTG87zXvILH4gmwiBgMuUGzZVKSAwrcKGawk5OVznm8thbuOJofsUwGE0L7TobfnZw94TdOj6NBek8dL2c8WzwwiUPCLEownbWDhW+tZDeCuRcZf/EFXntB97T5VlCCUAhWd9mtnu2BZsLGVzD8JqLZQ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net; spf=pass smtp.mailfrom=queasysnail.net; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b=QY8/lkSa; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=YbY+Iw9B; arc=none smtp.client-ip=103.168.172.155 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b="QY8/lkSa"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="YbY+Iw9B" Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailfhigh.phl.internal (Postfix) with ESMTP id 30C271400088; Mon, 11 May 2026 09:50:48 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-02.internal (MEProxy); Mon, 11 May 2026 09:50:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=queasysnail.net; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1778507448; x= 1778593848; bh=ZXI24ZCigjX2i8ed3wSzDEVGe20y9EDO24W3iWUxVc4=; b=Q Y8/lkSaXf9oa1u+90HWmA5fD3ZHnMbGIF6oovGJfOLO8WvXVPbd6qJ/PSUiDW5DR DaH3nkilSZAcICx31JoQYH42WivAhlaB8mEUeJpiezxUNXrJ4nBRYKBXXwN1eIGh w8q7Ac/5336cPJCOTy1i4U35pfo2/uuDs15WMsIMq35d/1j4Yl8zYK12c14UdZXw RAtDhzE9YFQFhRDCH4x7+R0xfQCDh7wrScsiRTCOZ2XeAhEp08FiX5FD7q+Cou+N i4gIIsJKM4sEZaFJlpB7f+oLft4D5vrisqEhMnk9O/BawkzW0KI5NIBoigszzeHy Oc0AkaoJt09XVBWzXwt8A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1778507448; x=1778593848; bh=ZXI24ZCigjX2i8ed3wSzDEVGe20y9EDO24W 3iWUxVc4=; b=YbY+Iw9BPWxT/7cZtvt0phYJ82je+TxB8q9w5xDpRwo/wvZYy8u Kt+nsj/C9jhxv2Kvk/Zz6O6h47PABwaP5u3qUK5kXiBTy4CznsR1XXtXkmsjytv/ HXVE9RMGRayQrrps/ePD8sNuYq8oGSYpXF4MGcXVYC4MJ7CaNNgNTBQc0ecKnscI ukbuc87DrnGTBrXW/rBpVPT5W6Jnf6oqOFJCp9M96ZffjzPRuS+1hOgxGqGAFPko 2RDHbrUFVc2JDudguzgOvm4mkm4ax8SBgTS3p6DvZMWUG5058/1ibmYwJ0oQd9qj xfY8Iu5iCWdXVmNMsNxIYEvOCuEulJmwcHw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdduudeltdelucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkfhggtggujgesthdtredttddtjeenucfhrhhomhepufgrsghrihhn rgcuffhusghrohgtrgcuoehsugesqhhuvggrshihshhnrghilhdrnhgvtheqnecuggftrf grthhtvghrnhepuefhhfffgfffhfefueeiudegtdefhfekgeetheegheeifffguedvueff fefgudffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epshgusehquhgvrghshihsnhgrihhlrdhnvghtpdhnsggprhgtphhtthhopedugedpmhho uggvpehsmhhtphhouhhtpdhrtghpthhtoheprghlvgigjhhliihhvghnghesghhmrghilh drtghomhdprhgtphhtthhopegrnhgurhgvfidonhgvthguvghvsehluhhnnhdrtghhpdhr tghpthhtohepuggrvhgvmhesuggrvhgvmhhlohhfthdrnhgvthdprhgtphhtthhopegvug humhgriigvthesghhoohhglhgvrdgtohhmpdhrtghpthhtohepkhhusggrsehkvghrnhgv lhdrohhrghdprhgtphhtthhopehprggsvghnihesrhgvughhrghtrdgtohhmpdhrtghpth htohephhhorhhmsheskhgvrhhnvghlrdhorhhgpdhrtghpthhtohephhgrnhhnvghssehs thhrvghsshhinhguuhhkthhiohhnrdhorhhgpdhrtghpthhtoheprghlsghinhifhigrnh hgsehtvghntggvnhhtrdgtohhm X-ME-Proxy: Feedback-ID: i934648bf:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 11 May 2026 09:50:47 -0400 (EDT) Date: Mon, 11 May 2026 15:50:46 +0200 From: Sabrina Dubroca To: alexjlzheng@gmail.com Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, hannes@stressinduktion.org, albinwyang@tencent.com, shenyangyang4@huawei.com, kuniyu@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jinliang Zheng Subject: Re: [PATCH net v3 v3 3/3] macsec: use rcu_work to defer TX SA crypto cleanup out of softirq Message-ID: References: <20260509033353.1814289-1-alexjlzheng@tencent.com> <20260509033353.1814289-4-alexjlzheng@tencent.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260509033353.1814289-4-alexjlzheng@tencent.com> 2026-05-09, 11:33:47 +0800, alexjlzheng@gmail.com wrote: > From: Jinliang Zheng > > free_txsa() is an RCU callback running in softirq context, but calls > crypto_free_aead() which can invoke vunmap() internally on hardware > crypto drivers (e.g. hisi_sec2), triggering a kernel crash. > > Use rcu_work to defer the cleanup to a workqueue, for the same reasons > as the analogous fix to free_rxsa() in the previous patch. > > Fixes: c09440f7dcb3 ("macsec: introduce IEEE 802.1AE driver") > Signed-off-by: Jinliang Zheng > --- > drivers/net/macsec.c | 8 +++++--- > include/net/macsec.h | 3 ++- > 2 files changed, 7 insertions(+), 4 deletions(-) Reviewed-by: Sabrina Dubroca -- Sabrina