From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7996370D52 for ; Mon, 11 May 2026 14:36:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778510188; cv=none; b=ZdguhJ6YJ4BvTU6MUYdhkcRwHoHDbbB2bHdK7m3nGBGgVurvXeE+K6COWuNmGq1kogtWyrsDfNkLbXFYnRzV08+WAi0ZTlwRQnvdm4QhKiaixNAYksx+HZ9M3wwGrlYLP1BP1+O6aceryvzURNxiKqwDVrH8TuQgcNEYzbDoIjM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778510188; c=relaxed/simple; bh=OD53JVPWJNXND+hhbRWk6qwD4LDdvpVx+u1whxdxWqM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HzhPHCf8ozPqLjqmmUYeYjxkNCWQy23YOwueStjJea6qb7CGXVK9LKmjFoRo9YbwV6JQoZj3m+xpy/r+95bivdUY3QKTxaBORoaDGW0TG3EgUv2Pd7TzbwgfwsHY/GyKOUVI6xmgYDrAY5xiNFncPI3NPBMEIXCGv7jB4BFASv8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=e7qlESu4; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=IukC+2mX; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="e7qlESu4"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="IukC+2mX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778510185; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TRmZZoSXD3Wj4LMAwAdt4eJuVkT2JvoyntYmnjZ3hZo=; b=e7qlESu4MpS+YWuM7yeCcpC7ak+1PG7wZx0oEhHIpEVaaMlBwot88JJjX5w53FWMsF55XV PSWh8kbbGIk29PgXyHkQcQjUNBheGlwT3TlrpfVx1CnPWMm00rsrCj8ihhTZ7Y9rWfrnSi 0PSNNqjmiM87C3Vw7HiSBaiNE/BBLRM= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-647-vAjFaJezOs6KByQx6zHNaw-1; Mon, 11 May 2026 10:36:21 -0400 X-MC-Unique: vAjFaJezOs6KByQx6zHNaw-1 X-Mimecast-MFC-AGG-ID: vAjFaJezOs6KByQx6zHNaw_1778510181 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8eb55e55394so891616485a.1 for ; Mon, 11 May 2026 07:36:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778510181; x=1779114981; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=TRmZZoSXD3Wj4LMAwAdt4eJuVkT2JvoyntYmnjZ3hZo=; b=IukC+2mX0Kt0XvpMgbaANkshrqCh+DvFB3a1h6awSF88ZOWytxcF1BfaAayrCifZXD oL9uCLhJJGXkLP6phxUf8XFMZ2wvnO2TZBtrNaSGMh2C5Irle/2K6/Y0OF6ABugwz7TD JsZwOtKXpcVV117PwEN2e5+Yng+RjUuyWHY421lyOfKYzFdOsTeYmpQQaqy5f62tXA4g Qcw2S/1lLfKvH5q2yaL6+ko20GiDX/H/P/7gTsjOAl7MQ1jGtQUxA/4qg1k7QSj+Fugs UCuU71qI5HU00OUHecjC9KomnrZcG+mW6A/VAd5YUgEU5fh/B6V5gCCA/H8bwPv1WN2o AG8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778510181; x=1779114981; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TRmZZoSXD3Wj4LMAwAdt4eJuVkT2JvoyntYmnjZ3hZo=; b=B9I10Z2wlT2R/V/jCeu0iDn+YEAcPG5XSNQs9uJss27UUOMwAwTguycSQX1FQCKBua uvlyeX12bEqDkReLhyvT5T7o27/+35McPMfwwTDyyUlQECi44sC7xM2PPU29s6KmWooM /CJ+fGhahhSRzJg4zOW2Y7OJNQgkgAvZMCsjb0Ohdm1M+4VrQkygBRvizjQVxWBdTGV0 GMqJ45MQH9agV4TXV4HoZbpmTUOZBMGk856XGX8i/l7dRizqdhB+MGcPoWoKsyPftTUR Kxl2UBDS0mcn3h31dJvFLc1A8Q4MHaMldY01TusAOOnP0UkGkCm3k7RKBqjguw+gcheT PGgA== X-Forwarded-Encrypted: i=1; AFNElJ8NZ7J4HlSedmezt/GhWUt2VYvP6z/9pwepFyy2gHAM7GNkPbDhC58QW884LgmjSJs26HUfJ3ByIaUZr10=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/q34Qc5WH3wq0KMh9icAv/8qkZ9JFeK4PWUcc/8pr2rQ5FOdk w1YyMz0zOoON8+42Rlntjqattc0nzngDghgt/sFNi0dMMXqpIl/TFM3GrtQXNs5Fc/ejW7EEPma iT5Y7Ph6v0kQRe/aT5G4p6gui4BmGRhlrN4IwwGlWfV8JeUxL8SaroobKwG6jOHnHUg== X-Gm-Gg: Acq92OF8AIi7QnJSUXNnTEzB5qHVELq2z1BGAFQDJNT6A+rBRPIMK71zXCZduMF2stq FgwdAUT3ai4F5uqpc/KIrXYbgeB7CQLsV1pjXarVGBh3u140BRxjjHBSbJsBV7dbkq4aq4RVBdy FosZnJdVmYP7Z+Nvhn5AWJW2PHxiaZGgu8U4D+GwvlWyb8e/WYrTxIC+Sf6vFwW6CeBVvGVtpnw 7YqahY+KpAw/mf/399KU/+Y38rlBb2j2ugTKhl+5dmWJnXGzzSoxDDjgxIn25xC672DcPMcT4Ef y+WWHxEYHcT9QiBqQ/QjdQjIDmZyeHvskXCQhlNqCZrNmp1/y1c3ew0FIVngAVuRfR/K48yj+d7 hGMBSu3iOGMCWH/shEndNyKqPmjWi8zxER3jTDzt6ZvLZSmkQm1K7Hl/r X-Received: by 2002:a05:620a:298f:b0:8cf:ed8d:20a3 with SMTP id af79cd13be357-907bb3e1b6fmr2203931485a.42.1778510180768; Mon, 11 May 2026 07:36:20 -0700 (PDT) X-Received: by 2002:a05:620a:298f:b0:8cf:ed8d:20a3 with SMTP id af79cd13be357-907bb3e1b6fmr2203927285a.42.1778510180315; Mon, 11 May 2026 07:36:20 -0700 (PDT) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8fc2cd04c68sm3128259285a.46.2026.05.11.07.36.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2026 07:36:19 -0700 (PDT) Date: Mon, 11 May 2026 10:36:18 -0400 From: Brian Masney To: a-christidis@ti.com Cc: Nishanth Menon , Tero Kristo , Santosh Shilimkar , Michael Turquette , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Michael Walle , Kevin Hilman , Randolph Sapp Subject: Re: [PATCH v2] clk: keystone: don't cache clock rate Message-ID: References: <20260507-clk-sci-v2-1-38f59b48777a@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260507-clk-sci-v2-1-38f59b48777a@ti.com> User-Agent: Mutt/2.3.1 (2026-03-20) On Thu, May 07, 2026 at 11:09:34AM -0500, a-christidis@ti.com wrote: > From: Michael Walle > > The TISCI firmware will return 0 if the clock or consumer is not > enabled although there is a stored value in the firmware. IOW a call to > set rate will work but at get rate will always return 0 if the clock is > disabled. > The clk framework will try to cache the clock rate when it's requested > by a consumer. If the clock or consumer is not enabled at that point, > the cached value is 0, which is wrong. Thus, disable the cache > altogether. > > Signed-off-by: Michael Walle > Reviewed-by: Kevin Hilman > Reviewed-by: Randolph Sapp > Reviewed-by: Nishanth Menon > Signed-off-by: Antonios Christidis Reviewed-by: Brian Masney