From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 742A53ECBF3
	for <linux-kernel@vger.kernel.org>; Mon, 11 May 2026 14:48:49 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1778510929; cv=none; b=S8eHAvk6/0HpUP6fL/D8TWRUcpsc9zdIH0TNPQ7C1g1Dq2iNuv6L2vwT/TdCZozN5bbXUzG97lvOd9p7OUAEc1hqZX5LhDtXghrh0fRqZ8m7KvJcWsSOnyvOmCo0mq8ohRdtR5dNU9RSdmu0bQps49j7nB7/3f3CyKlsloQyYtA=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1778510929; c=relaxed/simple;
	bh=2favqUqgmzwLBSdzdJayZG4j4Xz6KcMDYMEslx1Fc8o=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=foWyASUXX4o7gejXcJh+RBTOiIe0rXVdjgeQ33+YhCrHo7SbUDnBxnbp+0svuje0JIlueWA6urdATz94J/hVQF8/zpW8+ryLdlDgoBAGRs5pyN9PaWbLgSGCg1vGbflELPl9KUz3ctbHeCrtcpaLzh03V0fGX5frCTKUYSoVb2k=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=muhLyGb+; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="muhLyGb+"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE79AC2BCF7;
	Mon, 11 May 2026 14:48:48 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1778510929;
	bh=2favqUqgmzwLBSdzdJayZG4j4Xz6KcMDYMEslx1Fc8o=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=muhLyGb+3SwDKYAnar025r0+CATdv6NrMPOoY6WrsY8iCDZjtIGWSY1KkI0khBI2l
	 iGbvD92tDvmzc/NbXqkjD9lFNXvnShqnkqw9ySuprd0UyMpvEwGCY6ybpa/hDX68n2
	 hoS+WKvDDmNVXqW6wRDT0NsZ6h64rxVQbCt3rutj1WucP3cKUSfFTWny3LA0S33ioq
	 rtEN+EYwSj584BMM6tNmfUv+i0VJPfCKyCVJHsbZgDUHFNF3jac+WDXLHDz9AvpXVr
	 3r+6qzrw8lDhdnGAVk+8VT/OjXEHUN5WEzIGoN2ZT3VSo6UvapzLzvI+GEQtMbgjD7
	 MzDyIhxrrZtbg==
Date: Mon, 11 May 2026 08:48:46 -0600
From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Sagi Grimberg <sagi@grimberg.me>, AlanCui4080 <me@alancui.cc>,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme: make providing NGUID as UUID usage less scary
Message-ID: <agHsTnBOgkadTqkp@kbusch-mbp>
References: <UPNVP7_KTI2VieaAyBtUMA@alancui.cc>
 <73735bc1-9821-42d8-9594-1e9cdb03e15a@grimberg.me>
 <agGQZU4NwAgSzHLD@infradead.org>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <agGQZU4NwAgSzHLD@infradead.org>

On Mon, May 11, 2026 at 01:16:37AM -0700, Christoph Hellwig wrote:
> [the patch seem to be missing some maintainer Ccs]
> 
> On Mon, May 11, 2026 at 01:19:59AM +0300, Sagi Grimberg wrote:
> > TBH, I'm not sure why should this be a warning or an info log. This looks
> > like a debug print to me.
> 
> It is worse.  For some reason the commit seems to imply the uuid
> replaces the nguid and they can be intermixed.
> 
> We really need separate sysfs files for the different ids.  I gues we
> need to keep the existing one someone, but it is a mess.

Yes, sorry for the unpleasant situation this is. The attributes were
rushed into the driver at the time.