From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5B593FFAC8 for ; Mon, 11 May 2026 14:58:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778511492; cv=none; b=bM8J02Wg3nTHi80P6ha8sqkkejCqMbSZkBzcHU6TPlzTrxxSxI9fhJvMAjbTYTR69tYCQ+FcT1k3mU503909aGejhFAcjPIKikOqcDbRtAh91X1m2Z87BVrIK5agiMn47i7W70nc25EwXvYU5H+QVvch+oFz0qafw2Acus9gMCI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778511492; c=relaxed/simple; bh=HyctA9ruJdLXQrNgXC3tYUZI/xC2gvKU0L16p9xW3Qw=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=TpV2DN1IDDOoE3ILdRFGe2BwIYRAWf94RfxmvWAtjRPQrKdsitwn6GvX8NzrHM8OuXOVCZ7/JD7IFLmNKPVUJX4q+Mgj3BYkD11tLaVwOu5vabPJvI9Yyy2RC0YqyTNQC32ErRDpAwY3VV26nkGHzdLKqHSyYAe4cOLJTcm2ipk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Kia6gF8i; arc=none smtp.client-ip=209.85.210.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Kia6gF8i" Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-82f9429f49cso5468918b3a.3 for ; Mon, 11 May 2026 07:58:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1778511491; x=1779116291; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=6Fy1wa5nHs9JHTWKOBvA60eVfLFvSI4Hq1+Dct5OtgI=; b=Kia6gF8iX7QKfuStbqtQfUbwBXn6ZQN4jWhWDDY2bQc+jdDnTXmuMU/CK4M2XHb5+z l+5YBx7aixOrN6w9HWzG3nIx0kUIMpOjlgBjaRSctbA9Z1EN8a2e5yzmJZCp+kmL8I/q +IxxrlUwz1PIvuAk5Z/VNGmLpSniz0LM5xR0xIm7b0WII5RNiz3D4kqm92KaA58p8/CD m/P4C81tuajTxvJozYMk6DlKKS9UiRJ5kAoWL/56fpWwfyVDD3/L1V/cx643sb7pdtYq kTFJDFZ4xWdDskr2Rq/cV+Xc9eq7Ls24A583oOGM9cQZeCHTTXjFSMwo0e4yvb8KKKfB YrRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778511491; x=1779116291; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6Fy1wa5nHs9JHTWKOBvA60eVfLFvSI4Hq1+Dct5OtgI=; b=hRq284r9JeJgqiy/RZripY1Mj35yldXLb1YdNnanmnsgXfNq98Vi1/AYIuMuwQipn7 G6IeYxINzrZLYoHmKz5hKfXJX/WCsoffC4WWthShuwWiWc9UwWG9TXKjK7q9/7iDUT2J wpORIpMFgWCZkhTSXFo3ZOq7KMlxRcGFtZpktVupSeri+H8Eg8n/IZgrgNicxMDJL7pO uuWvmx+alMeOKnAOuIWIzquszO6VTmSTcOojJhHg+ovnXrx4mg86zWudp26jg0uW2N2C aYiCIwerTfp7Vv2uP0QtukW8lQIHU6ZGLZdnkeTsoSTyZ0ka8rQpwuzqR15qpAGb5heP GKnw== X-Forwarded-Encrypted: i=1; AFNElJ98kkD122lELHDBD9+6TykJ5x67vacSoYC4YC+zXvemS2owHUd1woNiBGu12xGOkMSiNqDSeP9EXaI2aZI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz62Gsm3OeOJBj39QM0I7glPPiXrC2YuOHreNXkLHmdrXEbeDDv 4Btw8Hr63wvro4EcjDbjco+P6fHZUzHl6Z9+8lIQSvet1cD+5tgo9VhZVwFVMLr63A5kVQ3hipw zOQcvPg== X-Received: from pfbdu7.prod.google.com ([2002:a05:6a00:2b47:b0:82f:7242:4cb9]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:1989:b0:837:db4e:a35d with SMTP id d2e1a72fcca58-83e3afd78dbmr9504363b3a.23.1778511490544; Mon, 11 May 2026 07:58:10 -0700 (PDT) Date: Mon, 11 May 2026 07:58:09 -0700 In-Reply-To: <20260511113759.610924-3-tabba@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260511113759.610924-1-tabba@google.com> <20260511113759.610924-3-tabba@google.com> Message-ID: Subject: Re: [PATCH 2/2] KVM: selftests: Fix FD double-close in kvm_vm_release() From: Sean Christopherson To: Fuad Tabba Cc: Paolo Bonzini , Shuah Khan , Marc Zyngier , Oliver Upton , Will Deacon , Ackerley Tng , David Matlack , kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Mon, May 11, 2026, Fuad Tabba wrote: > kvm_vm_release() closes vmp->fd and vmp->kvm_fd unconditionally, and > kvm_vm_free() calls kvm_vm_release() at teardown. A test that calls > kvm_vm_release() and then kvm_vm_free() without a > vm_recreate_with_one_vcpu() in between double-closes both FDs. That's a test bug, no?