From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85DB53233F4 for ; Mon, 11 May 2026 15:09:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778512179; cv=none; b=LflcBXqig9PX4h9S2JFJEnk1yBprWKltJZQPhMpYB/H9yKkOdOdliqmSfro+i9ayTCXi5ZfBpBSwvXdQHX2FI9VrkxQPYlBsMlimRnIumCk/CwBPtOL76fJ9nlqTioTu21xDtL+6qyzVpKei5R4LfGHimd9qiC2xIjZ/ttnof6E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778512179; c=relaxed/simple; bh=pDoOOoRbfnSiYt3NK45esXAiboYelbh9USbQXkCgS20=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QzHMC4tzCDqjIuPe4GNbqvAUAp+4/K093SG7ewIulBXuEv6ACkvcztnvRSdp5DbfWSqxI7hwNWt54zNzpGt1uuARxLG0Of9FBDKcoPk0EEqvfcloc5XyU+6OCsIX8wRZ8yAuAdiapVxFWOdnA2WN3ToTCjxnqUEt/TZgJp/2xj8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=NU1dvV7x; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=i8P81ube; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NU1dvV7x"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="i8P81ube" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778512177; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6fJ1KMpAkCCaRuC7BCMByjq+rlJoeF9q4cW8hbtF/+g=; b=NU1dvV7x4BuxyB36W0HB03IgXfPxgaNrnxsqHdfyYHiqRILxk0B9NFQkw9eut2p375nvLm 8lPC9xSNy1hccm4aLZtXIJMoRuT7Uk8FsWZEVjmKxibrr5I/izR/x9g82ZQNexB0ZNgWUT PKXXR3HQm1PDPhVkcFHZ8K3IUQrZlHI= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-504-jO1ZyGwNMYywWw4E8EUCSw-1; Mon, 11 May 2026 11:09:36 -0400 X-MC-Unique: jO1ZyGwNMYywWw4E8EUCSw-1 X-Mimecast-MFC-AGG-ID: jO1ZyGwNMYywWw4E8EUCSw_1778512175 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-8acb26fbbb2so59725426d6.2 for ; Mon, 11 May 2026 08:09:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778512175; x=1779116975; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=6fJ1KMpAkCCaRuC7BCMByjq+rlJoeF9q4cW8hbtF/+g=; b=i8P81ubedFDYCWI/d54uzWbgy0yjClFlMzy+hcyOYfUbHRqWryiWEZb4od1LguVc17 dOA/FdQYEZxPjR8I61LNgCCu0SakT42KK/QErdI4GE8wpmh71D56ZYLoFYgmhilVplvW BaNblRACf73mp1K+sYVi8n3tgFzET0Jpj6jAbk80hm2O4qWkFUaf1v/O0PxLJdj8jfH/ OPRbFZbtdnfYuqmgofxUNhvRtpr9l78ja3S3tt0pdd6W5xOFLLKscnpGwiCrEYLDjv5H dXwwwrzIWU6InHxZRLJXzD96GWvwkTEM1HOmrnSOfKYy2TCZOYZCi6saoOd5YHD7PBjj 2zNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778512175; x=1779116975; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6fJ1KMpAkCCaRuC7BCMByjq+rlJoeF9q4cW8hbtF/+g=; b=lhiFzyX5KhVeHY4wsb2CJ9IsARnVec2M394FFKpKqPFCKoiq/yU8LkUlX6Sn9F0XtY mebI8L12QFh7jRpsM1XYQhapbx6qOkWFJ2OLEY0P4eTG5mfbe+R6SsfumwHxOR8Q6KoR nOSj0TlPFFUwYouWaClMgV42ARglg1OflxAqX9JhhaJ/Tu5STeDBqUpGKpguMaTBWw7i rZojTPkH2eduvDqFDCYAbnf3Tj8zqmuJU8TDqUQVW8I3/KR8H4fPbNsbXHRSpUlnsXOx xLqyuUOCCu0eXp5+Ahg7NYMzEYVfMfmoKwJBV3Vso7dq8Gwh6/YTW1MIdjLYdQ/SjfF7 IjXQ== X-Forwarded-Encrypted: i=1; AFNElJ9JmLZlaTb/locBZwkWT2hbn75B5wjA4Uk8f6pEie7PZWhmwexBg48IK4BisDeCHLd1Jm+0/2CoL8Fsu/k=@vger.kernel.org X-Gm-Message-State: AOJu0YwXax7bWG9PRk7/YUeTP9zJyAByXH6yFXpQX6P71T1LaJQK6n+U 5CZsrP+2BGRVsYxpEmyAstqSSxvfHiq8QlqjU7DNPk7wnWJVsnrlRZ/fIgNvHwbmA/JuuE8fnnp ke2h0vXpP3xmSnxR83MT/GShTgENHlRkCAtT9P3pnuCbA8oiPoKsRdD6bRB5AZOL+hQ== X-Gm-Gg: Acq92OG/uiBSFQts9A/EHZ/tJB41+e2CUcMu82n0G/4dn2u043wH8KO5gAocdSbd1nc uj+sJMrJiDrBVJRYbMD/EGIx2g+bU6suMTU7z4tIjwI2MLyVZ0SpXfELh40J4FoIJpG5PKxZuq/ unv9MhHFuOSehc86HQB7FvwlS2C0RvzDHmBgAiPHyoT8sOAA7PfEdmF7KC24DmokID2rxo6L4iL ATigtLRgQv6MfmcQ63/2UwOHDepUVxSuT7L+6KTWMVXXA+ptCRX7QH8IFX5+uPuAyMr0mIrV4zz M92GUAMtLynhBwdj52OjZ3SzwTWbZwO0mgakmd4iM4oUH4vxy05SUdcyNAqk6BKr0zhABnZh+8c fTvdRVoxBRW0Kzr5plgbwdaIt3z7JhAUyf8t7UIW4b/6DT8CS7f4DvTat X-Received: by 2002:a05:6214:4989:b0:8b2:2474:8f3a with SMTP id 6a1803df08f44-8bc449aff3amr377914206d6.25.1778512175166; Mon, 11 May 2026 08:09:35 -0700 (PDT) X-Received: by 2002:a05:6214:4989:b0:8b2:2474:8f3a with SMTP id 6a1803df08f44-8bc449aff3amr377913356d6.25.1778512174525; Mon, 11 May 2026 08:09:34 -0700 (PDT) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8bf3a906e65sm96046336d6.16.2026.05.11.08.09.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2026 08:09:33 -0700 (PDT) Date: Mon, 11 May 2026 11:09:32 -0400 From: Brian Masney To: Min zhang Cc: Wei Xu , Michael Turquette , Stephen Boyd , Philipp Zabel , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: hisilicon: reset: Use devm_kzalloc to initialize hisi_reset_controller Message-ID: References: <20260511053216.538035-1-zhangmin2026@yeah.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260511053216.538035-1-zhangmin2026@yeah.net> User-Agent: Mutt/2.3.1 (2026-03-20) On Mon, May 11, 2026 at 01:32:14PM +0800, Min zhang wrote: > Using devm_kmalloc() does not zero-initialize the allocated structure. > Uninitialized members in struct hisi_reset_controller may contain garbage > data, which can cause reset_controller_register() to fail unexpectedly. > > Replace devm_kmalloc() with devm_kzalloc() to ensure all structure fields > are properly zero-initialized. > > Fixes: reset controller registration failure due to invalid dirty data This is not a valid fixes tag. Please drop. > > Signed-off-by: Min zhang Fixes: 97b7129cd2afb ("reset: hisilicon: change the definition of hisi_reset_init") Reviewed-by: Brian Masney