From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF312221277 for ; Tue, 12 May 2026 00:36:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778546173; cv=none; b=ZcNQI5kdu6im7gHz1deZ+l12AmXCzurnPqUIXc1HgUWAPJYr587U2XY1n6uuTJIyUubSwwJaS1wiz09KAXpz27YD2jBBm/DxZ3cy7rCDaHcab6/nAOkIHxdFOargd1Qhqmf8ihVZCCX37USVgth7ZqqM8QN/6g7Y226MwMeLBK8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778546173; c=relaxed/simple; bh=blJBzgUHAUtaPJlb+5Oh7K4tbo9vv+d+DqDbf+DDSOo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nwSyOqHlXm02oM6wvwY09942yUQh3MregbfVkyNjdXKEXOy0G/5bT6of79PTPXSllTuUI7SOcLU9K5+R6UXSWLiLCBELCIqla20S683KbROAUQeO8NxQkAe/EhtNp0PawH73/0ZvniEHEC25DQUEwi3fXyrn/0VwEKN8JMNkVVw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CQ3a/qPK; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CQ3a/qPK" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2b458ca2296so32278545ad.0 for ; Mon, 11 May 2026 17:36:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778546171; x=1779150971; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=FrVVtUgfOTXQmbIBWwPggikMOHzXWvBM1dIScqMwVk4=; b=CQ3a/qPKOzWlb7qV7MRdFBX/G73r2lQWSOUGwlxZl44remuK4uexKMpHn7PsqIqcAp Dkx/8oH8Qo5cbubSMSuvTlL4ZZ4pb6dvScO9BvWCg9yw7NQya7ekd3nUwRTkgFRKxCz0 1PkaXBCR4KQn7OdE2zo61IaV9a9Vbklxz3zcvlBS+NXwSYVfgLKJs3YAKwAN4RRXMGmX 49E1prXacbuFTRbSpm4Omvd8Q2/J3xFeb18sB1VRgFO2AI/jGfpO+uVnwFgyVejNzTk1 j25qPeICXyBmv3MlZ/yZPtxhckWKC6iDmWAEbWoHM9n9Oy3CTWZ5ZxxK9K8Xm8ZSLYFe /ucw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778546171; x=1779150971; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FrVVtUgfOTXQmbIBWwPggikMOHzXWvBM1dIScqMwVk4=; b=mCvXqGl9hlY/lfFMtPInj1AP3vDQ/JQ+J8Akm/Dh80J+59APiCqK/f7iW3cB5Hg2LK 9xEc52THXmPpIDfLk8ooe6kxl5PIjUP/OUOzouagK/aKgngm4e0TAsfU3OgNRQjE3eUo 9yaDb1dwwq+gYHQtkp+SwY6oTMgj398BuF4AoQ3I+li+djeOxllvZcokXbiYz5htCIRh ntaztwkT30HsQ3BpE99tvzsTp+q3ZtbKxpzvIua6/NHgSI6ChwvdkLD4plFvD2eZWYfI z9FVB3gQvjekIuAG5THI2iFqnZpJe6aCfGMgf6AtO+dPiUlWP/BSN+Wh5inCForUXx9P 7Xog== X-Forwarded-Encrypted: i=1; AFNElJ8q0k4QxJOY6I8s6IB9es7X5p/LDTzEROjfvuqWOnDB4ovZk0EAvwZ5L8YMKREQwWDLHvJWxA7OirE8e6M=@vger.kernel.org X-Gm-Message-State: AOJu0YzAcTy19Zv30RAEs/FoJ9Vu9ExVteh4fFV+wlzTZwWfCj/fgFO1 KVOEESlqbu+XCb3kMNjYlrwE67/5JdKCBePWPvmOjiQoxm2pIYny4pT6 X-Gm-Gg: Acq92OFVBgsdMdOoP1IQ5cEgO6Iyi0nRjJb3rwX3XTSvbcRDFyxXpkF0R7o8U28xRhm 2CFI0E7hSfj61q4dPWTxEnieg6oYomJXOJYyIPx7hu83+bTrMLk6nMyY8UNXEkGcjRn54JPJNdR Jinu1AUYrgHmQ2RjahGzQujQ1TCJDe5VBO9dEU7ozunHRhGuMQlreSb6vGi7Ec85CCNZjPcru82 KFXgiJv9qM2IQTMQcbMCBWuKItd1YW7muqhRCJebLpgJcFHGpqo2QPEwO2ypKAQDzKaPzp6tzDY Pz+KsTrEVyFTiKyuRS0NBizf5pvFWnEwk+o2qq0Mztk0lpa9QArX+/hu6djHoYNzTPCd4e4v1DB XjyK6hBbIgm85TlM77XfLnZDJqlOcmaPmhY5cT6zt4oqQy5grsORBJWC4KqHB5fJcjl5rKec8ey KFiin2bImYZk2bLj+kIvCnkfA= X-Received: by 2002:a17:902:ea01:b0:2b0:a957:304 with SMTP id d9443c01a7336-2baf0cf267dmr168280775ad.6.1778546171197; Mon, 11 May 2026 17:36:11 -0700 (PDT) Received: from localhost ([2001:19f0:8001:1b2d:5400:5ff:fefa:a95d]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2baf1e365a1sm112248115ad.44.2026.05.11.17.36.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2026 17:36:10 -0700 (PDT) Date: Tue, 12 May 2026 08:35:46 +0800 From: Inochi Amaoto To: Ulf Hansson , Inochi Amaoto Cc: Ulf Hansson , Karol Gugala , Mateusz Holenko , Gabriel Somlo , Joel Stanley , Paul Mackerras , Maciej Dudek , Andy Shevchenko , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Yixun Lan , Longbin Li Subject: Re: [PATCH v3 2/2] mmc: litex_mmc: Set mandatory idle clocks before CMD0 Message-ID: References: <20260426112016.1370929-1-inochiama@gmail.com> <20260426112016.1370929-3-inochiama@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, May 11, 2026 at 04:52:21PM +0200, Ulf Hansson wrote: > On Sun, 26 Apr 2026 at 13:20, Inochi Amaoto wrote: > > > > The litex_mmc driver assumes the card is already probed in the BIOS > > and skip the phy initialization. This will cause the command fail > > like the following when the old card is unplugged and then insert > > a new card: > > > > [ 62.923593] litex-mmc f0004000.mmc: Command (cmd 8) error, status -110 > > [ 62.949717] litex-mmc f0004000.mmc: Command (cmd 55) error, status -110 > > [ 62.976606] litex-mmc f0004000.mmc: Command (cmd 55) error, status -110 > > [ 63.002516] litex-mmc f0004000.mmc: Command (cmd 55) error, status -110 > > [ 63.028442] litex-mmc f0004000.mmc: Command (cmd 55) error, status -110 > > > > Add required clock settings and initialization for the CMD 0, so it can > > probe the new card. > > > > Fixes: 92e099104729 ("mmc: Add driver for LiteX's LiteSDCard interface") > > Signed-off-by: Inochi Amaoto > > --- > > drivers/mmc/host/litex_mmc.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/drivers/mmc/host/litex_mmc.c b/drivers/mmc/host/litex_mmc.c > > index a8d9c0ece16a..c984398d0803 100644 > > --- a/drivers/mmc/host/litex_mmc.c > > +++ b/drivers/mmc/host/litex_mmc.c > > @@ -68,6 +68,9 @@ > > #define SD_SLEEP_US 5 > > #define SD_TIMEOUT_US 20000 > > > > +#define SD_INIT_DELAY_US 1000 > > +#define SD_INIT_CLK_HZ 400000 > > + > > #define SDIRQ_CARD_DETECT 1 > > #define SDIRQ_SD_TO_MEM_DONE 2 > > #define SDIRQ_MEM_TO_SD_DONE 4 > > @@ -142,6 +145,12 @@ static int litex_mmc_send_cmd(struct litex_mmc_host *host, > > int ret; > > u8 evt; > > > > + if (cmd == MMC_GO_IDLE_STATE) { > > Rather than doing this explicit check for each command being sent, we > have the ->set_ios() callback where things like this belong. Please > move it there instead. > OK, And I think the patch 1 can be removed if this got moved to set_ios(). I will prepare a new version for it. Regards, Inochi > > + litex_mmc_setclk(host, SD_INIT_CLK_HZ); > > + litex_write8(host->sdphy + LITEX_PHY_INITIALIZE, 1); > > + fsleep(SD_INIT_DELAY_US); > > + } > > + > > litex_write32(host->sdcore + LITEX_CORE_CMDARG, arg); > > litex_write32(host->sdcore + LITEX_CORE_CMDCMD, > > cmd << 8 | transfer << 5 | response_len); > > -- > > 2.54.0 > > > > Kind regards > Uffe