From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1E8141325C for ; Tue, 12 May 2026 06:02:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778565749; cv=none; b=TjuoXDVOhdOTelVCvlnkxYJZGeq93ucd2vcWraW9BBhTA332Ogi0eBAVuv6fIfhE2OGJs8qWPCjuELjiAKCuVVOB7DSlW2qmKFYHUk6s+WLQkceD0tYCr8uoZqIL6yhe4NFLkNiybMHhgoM5YXrQ8BzyiJw0dM9hD7uOz5O6G4o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778565749; c=relaxed/simple; bh=b+kye1YfWgGDm7yCq6e0IumltEH2J2dN2+IE3Xz2HMc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SLLOzOLggpTxWYKF9vYaTN3v1IwIOxTB4oBU9eR6p5st0n1WdP3x8cAr6QFWepxQQoxMv86bn0F2a4f7fpxvHXVMiNkuYwkVUn7z2Nplj4vFByNvRiRBBgsostGwYiEEwUGbf15nngAKt9O95Kg8WLr1u3MjKwR7WULXLKSsdeQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=eLGh0ujB; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="eLGh0ujB" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=eZAruczZ/XZ7XcnBnviefmBw3M84MvDK7lfbPNAeEs0=; b=eLGh0ujBe2nKq0Hp0k5Fw/fSc3 2Npuroxekx1sIiujTlsKdujQz4xagC6tvAQOmeygNNyRJkSW7/SBkSYai8WjuHMHThzleVaJi93GF 0IHmRQb/uWyfXpPmIeiQKQV5QFmjfrKGEIP7VsUd6EhbpRexyKNHxWukH6q1aPHBUeNTjka0+pGzj l3tSwxOSJALqPCfqnfBQ9zVE4Vya3DoAmugcgRmRJCc+g+6w1ksnBusDXW0gJ4vk7Pzq/8Y5Py7IA V8/V+sPSwvLDQlwyEH8ggJSJsoaG8OOsYGE0SNN6lYVeLTKB9TQGiQ/dmO7nzhSXpjKslo6IRgERi i0N0hvew==; Received: from hch by bombadil.infradead.org with local (Exim 4.99.1 #2 (Red Hat Linux)) id 1wMgC3-0000000FiWP-0JAW; Tue, 12 May 2026 06:02:11 +0000 Date: Mon, 11 May 2026 23:02:11 -0700 From: Christoph Hellwig To: Keith Busch Cc: Christoph Hellwig , Sagi Grimberg , AlanCui4080 , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvme: make providing NGUID as UUID usage less scary Message-ID: References: <73735bc1-9821-42d8-9594-1e9cdb03e15a@grimberg.me> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Mon, May 11, 2026 at 08:48:46AM -0600, Keith Busch wrote: > On Mon, May 11, 2026 at 01:16:37AM -0700, Christoph Hellwig wrote: > > [the patch seem to be missing some maintainer Ccs] > > > > On Mon, May 11, 2026 at 01:19:59AM +0300, Sagi Grimberg wrote: > > > TBH, I'm not sure why should this be a warning or an info log. This looks > > > like a debug print to me. > > > > It is worse. For some reason the commit seems to imply the uuid > > replaces the nguid and they can be intermixed. > > > > We really need separate sysfs files for the different ids. I gues we > > need to keep the existing one someone, but it is a mess. > > Yes, sorry for the unpleasant situation this is. The attributes were > rushed into the driver at the time. I'm not trying to put blame. But I think we need to sort this out somehow - plenty of devices ship without a uuid and a system log warning is not useful. So I guess we need to slowly deprecate this attribute and add proper ones for nguid/uuid. But I can't really come up with good names for them.