From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50FA72DE70D for ; Tue, 12 May 2026 06:51:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778568715; cv=none; b=l5K8OWEF5/5bDgBfV7euHgTkm40JgOyKmDF+E8pI+JypHbUnlL21k5DQIkoyXd1ID6Hrxsyn/2y57RpD2ReWS7MZGU75uHV+Tl9a2uH5j6HBRXwYnfCzxjx6Zua/g2HAKTqd4SOy9hy8lyNGYI3XWs/HZCJJVsYRFLrwRS5VVr4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778568715; c=relaxed/simple; bh=JrQbMHAIUgObA1+mKB9cmwyGVWli0GV/3xeXEfKec+Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ca2OboDLA43uUuqLKgH2tdWnUpyzJkiaA004dshT0yoJ4Oxy4NGmf9Ei1UadO5Wk2sWZs3a8cinqPr8iytc0rgb0+1p/5IkWvGf5hNEWGbrfM9vBkJKkc/pwk4Wq/iiEa8X7NCQ6UzABlt4ozeEQZa/O0Dk4x8J//Iycpz+YO1Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iy9X4nJL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iy9X4nJL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71BACC2BCB0; Tue, 12 May 2026 06:51:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778568714; bh=JrQbMHAIUgObA1+mKB9cmwyGVWli0GV/3xeXEfKec+Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iy9X4nJLqbWsnvDt8maKE5p+Nu099G37eshBismCInFuhZUp0yS0mHJRGNOCYas3Z Ptisd0du9040+8gjOTnEODmTYnmAgnmQR2ks9AC63/6/+Cx5tWjISj+mj4QDivKrWP eiAExqCh7de66jSYTZAAcA2sff0U9HMTGo1yLPIZJRtEoBpeKwJA2DRVWe8+GkJuzl KZZ4pqd6K+LF8Yc7wqZ0/SWrEW6flO9Gw7x5jg/bnfAthyENKsc4+9CVAk9CxbHBel CYfiaFBj3tSQNgvexfXGwBg9CQjLGmUFhZcDMuS5hpWrRf3mFLvbVMoACa2QMBSAPe rQf21poTG03oA== Date: Tue, 12 May 2026 09:51:46 +0300 From: Mike Rapoport To: Pratyush Yadav Cc: Pasha Tatashin , Alexander Graf , Muchun Song , Oscar Salvador , David Hildenbrand , Andrew Morton , Jason Miu , kexec@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/12] kho: return virtual address of mem_map Message-ID: References: <20260429133928.850721-1-pratyush@kernel.org> <20260429133928.850721-12-pratyush@kernel.org> <2vxza4u5c2oq.fsf@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2vxza4u5c2oq.fsf@kernel.org> On Mon, May 11, 2026 at 06:48:37PM +0200, Pratyush Yadav wrote: > On Mon, May 11 2026, Mike Rapoport wrote: > > > On Wed, Apr 29, 2026 at 03:39:13PM +0200, Pratyush Yadav wrote: > >> From: "Pratyush Yadav (Google)" > >> > >> There are currently 3 callers of kho_get_mem_map_phys(). Two of them, > >> kho_mem_retrieve() and kho_extend_scratch() need the virtual address. > >> The third, kho_populate() doesn't care. Make things simpler by > >> directly returning the virtual address. Rename kho_get_mem_map_phys() to > >> kho_get_mem_map() to accurately reflect what it returns. > > > > This should be moved earlier, before replacing open-coded get_mem_map() > > with a call to kho_get_mem_map_phys(). > > Do you mean move it before patch 2 "kho: store incoming radix tree in > kho_in"? Yes. > I can do that. I did it this way to show a clear need for this function, > but I don't mind doing it as a preparatory step. With the usual "it will be used in the upcoming changes" text in the log it's fine :) > > > >> Signed-off-by: Pratyush Yadav (Google) > >> --- > >> kernel/liveupdate/kexec_handover.c | 28 +++++++++++++++------------- > >> 1 file changed, 15 insertions(+), 13 deletions(-) > > -- > Regards, > Pratyush Yadav -- Sincerely yours, Mike.