From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19F9C357D1A for ; Tue, 12 May 2026 07:27:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778570878; cv=none; b=YTb9HdLBLUMWpsSTRVsbNJYYoCwoWsOf0nkEwGvF108fkZiYxGfIqaXmupPn69sk1pCNWqHDRpoawcdoDQ3bLdJHwo4F+J8llN15Q0nihcRAyDXf0yTnO8eX9OoPneVOBhpasBkxInucBTVVwwlwYI7NAMcdl1015FYGw2iikog= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778570878; c=relaxed/simple; bh=Wb5Eaixtf8ds6w5uqD4P2ndnnK2y3udztabhmv6EE/U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=E9XDWX4oZ8fC93HlB75UsQT8/uLplaLb6/3nL77zlQTCrDseL0G9QDGaK4ZpfNDj/VmPrCKNCQI5UJB3Cffjp6XEE7XekNhT4rdnZw8/E/I6P6V0WKCJFI/5Prfm+41fnRLNdQw6Zb/rcB08Migm96enuDyw/9lPn1BzgwXyllE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WJ7INdNm; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WJ7INdNm" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4891e86fabeso59755725e9.1 for ; Tue, 12 May 2026 00:27:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778570875; x=1779175675; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=K/KXokBmQXfYB3ymboSTLTvRoQOVtSVEUAohP9gpfDk=; b=WJ7INdNmPTClC5SAwcGLGXmwG2oP85nK0xuaIMLRiup6AdEviKlutx2MUps6uwfzGS 4Cf2sNicDQfomShfLbyABzhKf/YEy4TpyinooEdeFmv62Tg5xTYzNFmIiAGYokKtJyvT Nat+PuOaeZUEJcLztkza71Wkie4WF9P1UYEKgDDwl74/REXeD5P5DNM5qklpgYC9FohN U88WU3uOjZUk7Hq6rv6jwaVLA55q63GK01vqkXfR5jGe1M7rwrrQ5iCsHnYby2DQrzOu 9JUxjzR4+DTHLvoLuK9bgXZaQndoFTo6amdwby4dP+VhNapdgPAXdA1F4AH+iSl8Nk4J axMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778570875; x=1779175675; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K/KXokBmQXfYB3ymboSTLTvRoQOVtSVEUAohP9gpfDk=; b=j3des4bdjdw82fczGUIRdehZDCP8l3cgtHKE3d+WYonw5xjqBJ65GQ6hLUwDU0XUTl ychs7GBmtiSTuqVRROfKYkzByE8JS6MzigKkVY0tjPQOGjWS9eg9Syc5vLxbHSNW3hWn s80oPzxcT1UkTpdstXCbOlDGJZQOhXzJPB3kQunDr4woQV4TiyBq3LPmDCJ83rIanlaC Am1rTEw0GlcY9OjbGJ+6Fob0DMIyJVGcezwsojlUoUW3egvvUOmUU56x/sg3jIJwRXxQ NMvComiY8Y7DsYiMlRajIayb3SLRbI94cC6B182wWVuixZkQqJ4GRoVt9fecQHCl2RUs e3gg== X-Forwarded-Encrypted: i=1; AFNElJ9UAPULBLLc0w7bKcbAd03CAk3iSOLrXtrj6kfggmf876e2CKZlhoeV13TJO0YpLKUOIghzGwA9+onu4WE=@vger.kernel.org X-Gm-Message-State: AOJu0Yxe1OR9k8dAhYCEBt2nuiI5+Q8AgqkDFIBRN1WKX5EKerJNLP0+ cwqMpXUnhJKhRtmqceA8s//dLina7zHeyd1BqKnhsXq5buuSjaCZkv9Y60hVf2Cn X-Gm-Gg: Acq92OEmeDdK137GYCYNromGh9V8rjpQnGhnW5Iwu5vjX6M34mzR69s8jQ2orWW5Hxs T8K3FMjvXHj5/xKA2Z+n/yWosK39KwAIO3OTP5tzrWydDdrsUrmrqTe6eq4JbtvAMpaP7xALI3J hoNVivFFOtH9SIRCbRJAjlNZ3otylLmQOTnNBOYtfRqLG51Iuw1h0dpWbLI9W93srK8PL96GWS6 I5cZJkavGFR5SX+LmPa6FkSZmThQQL7KDZG+PdFWC75XM9kXNvNoYjJRBi15SjjmlKBTvqN/aon 3lyfZlcndoJ7KbkNgX3TyJaQSCFN4NBwrltiPrH5tWU5i9OrqvVjM9NucrjKdhFM4LAqwynBWQm 0VDsoVR6KWvpUCBx7P4+ZiP8a1J9sHLGKNczl0XlouAaUj4SDULM0c5j5Mk726Rj0PHSGcYl39r si7FB7qz3I/d1BtpwzxPo= X-Received: by 2002:a05:600c:1da8:b0:48e:635a:18d7 with SMTP id 5b1f17b1804b1-48e635a1ba0mr320493495e9.0.1778570875315; Tue, 12 May 2026 00:27:55 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4548eb75c29sm29966188f8f.9.2026.05.12.00.27.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2026 00:27:54 -0700 (PDT) Date: Tue, 12 May 2026 10:27:51 +0300 From: Dan Carpenter To: Noah Techoueyres Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, nikolayof23@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: rtl8723bs: fix line length checks in rtw_cmd.c Message-ID: References: <20260512003115.5570-1-noahtechoueyres@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260512003115.5570-1-noahtechoueyres@gmail.com> On Mon, May 11, 2026 at 08:31:15PM -0400, Noah Techoueyres wrote: > Fix both block comments and assignment statements that exceed the > 100-column limit to follow Linux guidelines for readability. Used > intermediate pointers to fix assignment statements. > These are unrelated. Do it in two patches. > Signed-off-by: Noah Techoueyres > --- > Changes in v2: > - Replaced repeated struct access paths with an intermediate > pointer to traffic_stat to resolve the 100-column limit. > > drivers/staging/rtl8723bs/core/rtw_cmd.c | 38 ++++++++++++++---------- > 1 file changed, 23 insertions(+), 15 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c > index c1185c25ed36..5c6999ac17f6 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c > +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c > @@ -1106,24 +1106,25 @@ static void collect_traffic_statistics(struct adapter *padapter) > { > struct dvobj_priv *pdvobjpriv = adapter_to_dvobj(padapter); > > + struct rtw_traffic_statistics *stat = &pdvobjpriv->traffic_stat; Don't put a blank line in the middle of the declaration block. regards, dan carpenter