From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21B733783AD for ; Tue, 12 May 2026 07:45:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778571922; cv=none; b=YMAedAK9z0d66kaYMSV1Qstm7O5GwxuSe82+6jDxUHTJGwNUCAakleQhtTTmiSAP1rbQfURGz/7UTDAFpUqsh+cXG6oCPjaggCYIhimqga6p+kB2F5se9549KqxyUSVIk5FGGpz0QeWmptU4x40hFh6B6v/evTJHb0yCSSS90/w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778571922; c=relaxed/simple; bh=f+yWQMRJhhFmv3gWuRjIuOMLgbpJH+o6i8+Glu9ZEP8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tx5m1pB6ErrLctW2n+mCSpckwmB4Cifyj/jZT8AAN7d+N4ivn1cuiCE5UNHSYoNHBQvjzAIPx7QdAEILkC0PCCYmuLTO32Thg4l4pALWrRfy9QmFffGo23GNJpKFxjr5GtH5rTVbEMxVTzX/34AEYYQRqlopFB4TPlA1G7nHn68= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Xn4hnga/; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Xn4hnga/" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-488ba840146so45992485e9.1 for ; Tue, 12 May 2026 00:45:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1778571916; x=1779176716; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YuUpqcwRSMeMl5pOLaTVyc6TdYwqJl65snzBr5xo1y0=; b=Xn4hnga/P7L9YXCppEJLnBL4DfcInuCK+mZ6VABAT1nof0/wIln8cBcgJKclKcd9YQ KfJ3wGhIA8F4oBkcCh7eVsAim2f3gX4XvPyGKr6rfyZk7tkIq5EkAsr071pfXmVgJN1T bNPuJ/EWJDz3tKEz6dMWC8g23iS/w+hEFm/rWjoFVzJ7sbmR/lRgZ9ZNWvm7Rhle6o0O AwdiOdCzldL/YoefkXrmaGEoDesANSIGAcD0zsc16NC59tnsWKxZmicyE1SkWMrT6Ypw 7er+j+tt6UcCeTq1nJ+TGczD/rdw0PvxTkLW/abwwArRe8G37EIKYmD1Cl9lRbRvKNSC YRaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778571916; x=1779176716; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YuUpqcwRSMeMl5pOLaTVyc6TdYwqJl65snzBr5xo1y0=; b=eGNsT7/WCycwJAngJFrRrbD0qS2yfCV27UZojasrtGCZIKR2LjqmDYbC2Qn5ZO0CcI mGdxy3RQf+KRDa2kYBTHWJCEW789U+e8bUyLwCOBI+zJUkvVco7G5gtcTWNmwB+XAG0P 0mCKbGJnegEbPzZNcRNkwrHbjvxi7YCR3biTQMhS8CSKiSl1ayq5blCQNUloR3nK1wq8 kAQdj+Zo+rs5S5UvJV95biiKSS1V6WuiFJQp8DMSxZpP5Xzo7XJQW+SQiSH6IhwunLaC xtDNhe2vtvm5A3khNiHfQurZS4HgV0MapOpqSkoDrJlKKh1OYKPP9ueDJVABPwd31Lx8 oQ1A== X-Forwarded-Encrypted: i=1; AFNElJ9ydtcSx5Ehm1nb/hgIaxGp4NYNaxnu9flVbEKhzupE2Um8e89kT6l1ivCmLvzJqcRBq3a3t7y50115p1Y=@vger.kernel.org X-Gm-Message-State: AOJu0YybATgfkdTcozM621hmwvAR7tb1eJUQJxCKIu9z4rXnFb/+7rvg fxF3G94mGDej1cwXt55PzBJxoMOqNwufVlmdnvOCMphUjcB9BdFekVgLvZHqmICIZOE= X-Gm-Gg: Acq92OG9HUb1+54V6p/vkG9AFfcbLgDpU1KVkjFIJJyL+TWtSN6lK15weJWe3ZYkiNT HgH+piwxojj5BthDVbxzJSJNYAhkYEI4bY/3fwblSv6A/fio2jzKzIYLhcVQv175QFtd+7pt11I Fg0xi2nm7DVW0qAibAyclrbCmnH8v+gp9YqWrdHtNC02hn8xqsBdCo/G+RPKHgIY/4ajV5uByhr lr8OKfLr3x08amY5Ukj9ZISnPma6LrStnUlquMZJdt4n7qI9hwnV+u50c74oOtHCD6GN8mWDx+0 wSErXu3tvoXE8OmN+aeIKXxGRzlTfSF6OhuWs7LcV4xHdpQPGTAPeZqVMOYuHs0SDTlw5DYmIFI aVTODHPwIm1vAgaD+zNI+bjWs0nUgtb1+ttvt4YsK/ykljjOM2759awrR9+naGVxqDuRh11frN9 eh9NmpPmYDx4M3Y2fPdd0AEOJsAGAdJNqWIYNR X-Received: by 2002:a05:600c:c058:b0:489:1aed:1658 with SMTP id 5b1f17b1804b1-48e8fe7b8bemr18623855e9.23.1778571916418; Tue, 12 May 2026 00:45:16 -0700 (PDT) Received: from localhost (109-81-80-123.rct.o2.cz. [109.81.80.123]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e8f63beb7sm13428995e9.35.2026.05.12.00.45.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2026 00:45:16 -0700 (PDT) Date: Tue, 12 May 2026 09:45:15 +0200 From: Michal Hocko To: "David Hildenbrand (Arm)" Cc: "David S. Miller" , Andreas Larsson , Mike Rapoport , Andrew Morton , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 5/8] mm/bootmem_info: stop marking the pgdat as NODE_INFO Message-ID: References: <20260511-bootmem_info_prep-v1-0-3fb0be6fc688@kernel.org> <20260511-bootmem_info_prep-v1-5-3fb0be6fc688@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260511-bootmem_info_prep-v1-5-3fb0be6fc688@kernel.org> On Mon 11-05-26 16:05:33, David Hildenbrand wrote: > We removed the last user of NODE_INFO in commit 119c31caa59e ("mm/sparse: > remove !CONFIG_SPARSEMEM_VMEMMAP leftovers for CONFIG_MEMORY_HOTPLUG"). > > But it really was never used it besides for safety-checks ever since it was > introduced in commit 04753278769f ("memory hotplug: register section/node > id to free"), where we had the comment: > > 5) The node information like pgdat has similar issues. But, this > will be able to be solved too by this. > (Not implemented yet, but, remembering node id in the pages.) > > Of course, that never happened, and we are not planning on freeing the > node data (pgdat/pglist_data), during memory hotunplug. > > So let's just stop marking the pgdat as NODE_INFO. With the last user, shouldn't we simply drop NODE_INFO? > Signed-off-by: David Hildenbrand (Arm) > --- > mm/bootmem_info.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/mm/bootmem_info.c b/mm/bootmem_info.c > index 74c1116626c8..cce1d560f094 100644 > --- a/mm/bootmem_info.c > +++ b/mm/bootmem_info.c > @@ -62,15 +62,8 @@ static void __init register_page_bootmem_info_section(unsigned long start_pfn) > > void __init register_page_bootmem_info_node(struct pglist_data *pgdat) > { > - unsigned long i, pfn, end_pfn, nr_pages; > + unsigned long pfn, end_pfn; > int node = pgdat->node_id; > - struct page *page; > - > - nr_pages = PAGE_ALIGN(sizeof(struct pglist_data)) >> PAGE_SHIFT; > - page = virt_to_page(pgdat); > - > - for (i = 0; i < nr_pages; i++, page++) > - get_page_bootmem(node, page, NODE_INFO); > > pfn = pgdat->node_start_pfn; > end_pfn = pgdat_end_pfn(pgdat); > > -- > 2.43.0 > -- Michal Hocko SUSE Labs