From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 466F2368D72 for ; Tue, 12 May 2026 08:06:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778573173; cv=none; b=ejH1hhjuw4bYs4TxQV/Gl51hgCk0A4t2K5vznPoSqEWzMdO22AlKf6HoEDlhWeEwMqHUIWLPuclc5KQ5Rudm3swfndAsuJ3jHgTa10CmEbMJtjxY3twKm9Skx2CWh1X+v+2Un2XO/ZgqeQhpJDPD3LpyjKdAHzqU8kneSz6iwa4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778573173; c=relaxed/simple; bh=Cw5y9vpzQ+HGAAqvHwdnbCKDka1FgZ8X0LZB56QGS94=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YuTPLQ2pC+QR9voBr4nKMuwi3R9MX654U64fuWIW3GqtFXROTB108WH1UWTot7PvFe267c+eyZW+mWUMxA89Hmz5knMya4KIrvMFYj5up32sQ+dECteyG/jPjUFXuDS11olSYdb/rb9g+f0hzTS5hqwjcQUnxVkJAKaW2uePZ5o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Gu/a4o4s; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Gu/a4o4s" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-45562c41ec7so2002075f8f.1 for ; Tue, 12 May 2026 01:06:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778573171; x=1779177971; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Ub9rCJB+xiyh5qMMvDQ8N4fa009xZ6N4W+3GYqzTDBs=; b=Gu/a4o4s2OwYS3JU03JpPaNeZZRabZtomXxQ1eM7TOCuqMsFsv36gr4xJdezROV5IA Ef6GhZPDMAWGYv1DhbOVvo0x0GMAQz3vek9ayZpChQARGZKWpvlfLNgPDmqwV0P2kY/g m4PB8tXEOP8ozDRbk9QCFpuUP6EbksDulwlwQ2/ZVZw2rP3tybPV3mUlSA2UKyZicVou 69iJGyfFFkmSS8RagYoRY+kMPy9D+jlIA6JcfgX1SXaQFScsMcLx1OwPLqMe9cBsseBX gILd5IAXOCHKqiHPSLQGJ0qYXYAtdqEiy3kIx4IPKa8q70tJ0GSEm6q/WiJnGk6MKWDa FpCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778573171; x=1779177971; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ub9rCJB+xiyh5qMMvDQ8N4fa009xZ6N4W+3GYqzTDBs=; b=evzxW9ysmsEYcj0WDayVTGld5OysLPQzR87QY7B6X01HcapnbV1lmQTZgPLiE21wPk +PnDbwxD58d3zhPgZAIRCrCReG4QPXrjbcdPHYFP7lff/8I9hxp9CDPoMBp3YMkBUW3R d37QSgiclbk5+jN9iotnxh+hKDLrtoJ1Nvj94rkE8r0zdTiDTrDK21su/qhNLVzbbyYC q4VZowQ8GuVAuxxx3rJVg15D2MbM+5+gZ7g4ClZvvK493kJr6iF743L3zuYtKJ9ayeHs DDX/ZOW+ssq5vCepdj8KPclNyjim7960VFg9/YvIS6vyl9khMnVebPxRm64w6Rq+Jiw7 7gFQ== X-Gm-Message-State: AOJu0Yzg/NfBSt6EcmiXvyVQZzmNiTdawHoROFb8hyUX5cRXYB76tmdW qwEoEnvtDLQH4vZpPhkZM+z2//Itqo/mIByX5pAl/JzYwhP4UQQV9ag3 X-Gm-Gg: Acq92OGw6dMMNsu1iiusEhnFUI8SBbaj3U+eVurYzvwgvLzSHsd36EB6OiG9mxIa6Xo DOn/obyWQMDzyXlt/yV4MFwIoWy5VoZEYWRBnSfkzZ6U9KFqvkYaKdA8tfs2Crf00R8jGQAqVW8 7OrdgEndHZeHvizIam35ZJIYyVTSSiWNaV2Fvcz6iG7BnXWJlxXoEDp/WghuyerdRKHlwOS5B7+ mRTwIa3O7KFh6XtrEb1Gh7i/ZciNJTCG8lCzU95Nh75/+gzbTzrMxE+bqGRXDySfApRrBU4+CXG ZwFsiRjfuqutGpBm7fWlOVR7Z1do3yZbjhUUrtm7lYvBap9vauU3JOVyXoQ6CnZ3KcWkH3WjmD5 YSBYMbPJYf9/L/FY+KprifpQ0ThM4H38RCTYCf52IbU29/6XewSyv7cPoUDNZeJwqNkJj/UGXzz /GXLO2haYV2MqgmrEyFH4= X-Received: by 2002:a05:600c:528e:b0:48e:7f1c:8778 with SMTP id 5b1f17b1804b1-48e8fe721bcmr30944315e9.17.1778573170670; Tue, 12 May 2026 01:06:10 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45491e94c0fsm31909250f8f.32.2026.05.12.01.06.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2026 01:06:09 -0700 (PDT) Date: Tue, 12 May 2026 11:06:06 +0300 From: Dan Carpenter To: Thomas Gleixner Cc: LKML , Calvin Owens , Anna-Maria Behnsen , Frederic Weisbecker , "Peter Zijlstra (Intel)" , John Stultz , Stephen Boyd , Alexander Viro , Christian Brauner , Jan Kara , linux-fsdevel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Pablo Neira Ayuso , Florian Westphal , Phil Sutter , netfilter-devel@vger.kernel.org, coreteam@netfilter.org Subject: Re: [patch V2 01/11] hrtimer: Provide hrtimer_start_range_ns_user() Message-ID: References: <20260408102356.783133335@kernel.org> <20260408114951.995031895@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260408114951.995031895@kernel.org> On Wed, Apr 08, 2026 at 01:53:46PM +0200, Thomas Gleixner wrote: > +enum { > + HRTIMER_REPROGRAM_NONE, > + HRTIMER_REPROGRAM, > + HRTIMER_REPROGRAM_FORCE, > +}; > + > static bool __hrtimer_start_range_ns(struct hrtimer *timer, ktime_t tim, u64 delta_ns, > const enum hrtimer_mode mode, struct hrtimer_clock_base *base) The return type for this function needs to changed from bool to enum whatever... Otherwise HRTIMER_REPROGRAM and HRTIMER_REPROGRAM_FORCE are both just true. > { > @@ -1410,7 +1416,7 @@ static bool __hrtimer_start_range_ns(str > /* If a deferred rearm is pending skip reprogramming the device */ > if (cpu_base->deferred_rearm) { > cpu_base->deferred_needs_update = true; > - return false; > + return HRTIMER_REPROGRAM_NONE; > } > > if (!was_first || cpu_base != this_cpu_base) { > @@ -1423,7 +1429,7 @@ static bool __hrtimer_start_range_ns(str > * callbacks. > */ > if (likely(hrtimer_base_is_online(this_cpu_base))) > - return first; > + return first ? HRTIMER_REPROGRAM : HRTIMER_REPROGRAM_NONE; regards, dan carpenter