From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 886852DA76F; Tue, 12 May 2026 14:15:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778595316; cv=none; b=Q67gK03rlTmUYRf06lXH83caSwXebqAKDBCuScTxXcLl1z78hrCU4wX5PSUZZqXaSdfloOskUAz40B54TO/id8UIYt91aYH2/bhjKVor76djbLj0Qeufzcckp9mgI6LEO7Mmmlp/t9A/fy9ywPHiyFtXyK1VTbFvcYgJ+116acg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778595316; c=relaxed/simple; bh=2WkAjgMYKprH3oea5KBYbJRdKM6BKtjX2k7rnkrpqLw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dspy7KTNz7Cs8QNCeMA2QZKY/PEi6idFfsQcFdUJLYZlQ+F4GWly+UWYPG1BOBVgWrUP6wBa6tGQCU0vaIwJgqFoknvcohWt+sqCIs9bLMmqYfABhuDGK4m6b0o+pQihe3fUhEKi3JeNUmMP2+rzKs+U6VfTT75IOhITRFCsOjM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=h1bbivam; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="h1bbivam" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 557A7C2BCB0; Tue, 12 May 2026 14:15:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778595316; bh=2WkAjgMYKprH3oea5KBYbJRdKM6BKtjX2k7rnkrpqLw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=h1bbivamd7B2fX9ORDSXTgYIFoO432Ta39U7q+vTjjnVsQyw+i5Ow+otIBL6rRU5h w9nm3X9Ct1o/JO31KnZINaKaYTIqChugYgd4sVfAjtKrDEkNB/NPtPGwaEV2kajqsY NvkbKuisECF+YgofQzRtTTxOrnjbvT712uDcWFgEGk6d78ybIa0wxs6ITDFozIbnm0 UyPWuhnkUAueiZ3K5kJyEUVqDzVgQRCYXBiNIMwU3+BY4lFwU8upcUgifm5OFgw+RG zKJL2jEsy6a//wcvnsYGaD4gduEy2g5wJhRXzC4eRMc33rpYD00uSxbZO7jMmYdDnY 98jbKxosIdd1A== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wMntB-00000004C37-46q4; Tue, 12 May 2026 16:15:13 +0200 Date: Tue, 12 May 2026 16:15:13 +0200 From: Johan Hovold To: zwq2226404116@163.com Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Wanquan Zhong Subject: Re: [PATCH] USB: serial: option: add missing RSVD(5) flag for Rolling RW135R-GL Message-ID: References: <20260512103759.230894-1-zwq2226404116@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260512103759.230894-1-zwq2226404116@163.com> On Tue, May 12, 2026 at 06:37:59PM +0800, zwq2226404116@163.com wrote: > From: Wanquan Zhong > > The RW135R-GL MBIM interface entry added in commit before was missing > the .driver_info = RSVD(5) flag. > > Without this flag, the option driver binds to the MBIM interface > and conflicts with the cdc_mbim driver, causing AT/MBIM communication > failures after switching to 43 mode. This matches the handling of > other Rolling Wireless MBIM devices. This doesn't make much sense. The MBIM interfaces are not vendor class and will not be bound by this driver. They don't use interface number five either. You probably want this for the ADB interface in the second configuration below, but the commit message needs to be updated. > - VID:PID 33f8:1003, RW135R-GL for laptop debug M.2 cards(with MBIM > interface for /Linux/Chrome OS) > 0x1003: mbim, diag, AT, pipe > Here are the outputs of usb-devices in different mode: > T: Bus=03 Lev=01 Prnt=01 Port=04 Cnt=02 Dev#= 8 Spd=480 MxCh= 0 > D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 > P: Vendor=33f8 ProdID=1003 Rev= 5.15 > S: Manufacturer=Rolling Wireless S.a.r.l. > S: Product=Rolling RW135R-GL Module > S: SerialNumber=12345678 > C:* #Ifs= 5 Cfg#= 1 Atr=a0 MxPwr=500mA > A: FirstIf#= 0 IfCount= 2 Cls=02(comm.) Sub=0e Prot=00 > I:* If#= 0 Alt= 0 #EPs= 1 Cls=02(comm.) Sub=0e Prot=00 Driver=cdc_mbim > E: Ad=82(I) Atr=03(Int.) MxPS= 64 Ivl=32ms > I: If#= 1 Alt= 0 #EPs= 0 Cls=0a(data ) Sub=00 Prot=02 Driver=cdc_mbim > I:* If#= 1 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=02 Driver=cdc_mbim > E: Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > I:* If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option > E: Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > I:* If#= 3 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=30 Driver=option > E: Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=84(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > I:* If#= 4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=40 Driver=option > E: Ad=86(I) Atr=03(Int.) MxPS= 10 Ivl=32ms > E: Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > - VID:PID 33f8:1003, RW135R-GL for laptop debug M.2 cards(with MBIM > interface for /Linux/Chrome OS) > 0x1003: mbim, diag, AT, ADB, pipe > Here are the outputs of usb-devices: > T: Bus=03 Lev=01 Prnt=01 Port=04 Cnt=02 Dev#= 7 Spd=480 MxCh= 0 > D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 > P: Vendor=33f8 ProdID=1003 Rev= 5.15 > S: Manufacturer=Rolling Wireless S.a.r.l. > S: Product=Rolling RW135R-GL Module > S: SerialNumber=12345678 > C:* #Ifs= 6 Cfg#= 1 Atr=a0 MxPwr=500mA > A: FirstIf#= 0 IfCount= 2 Cls=02(comm.) Sub=0e Prot=00 > I:* If#= 0 Alt= 0 #EPs= 1 Cls=02(comm.) Sub=0e Prot=00 Driver=cdc_mbim > E: Ad=82(I) Atr=03(Int.) MxPS= 64 Ivl=32ms > I: If#= 1 Alt= 0 #EPs= 0 Cls=0a(data ) Sub=00 Prot=02 Driver=cdc_mbim > I:* If#= 1 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=02 Driver=cdc_mbim > E: Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > I:* If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option > E: Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms: > I:* If#= 3 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=30 Driver=option > E: Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=84(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > I:* If#= 4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=40 Driver=option > E: Ad=86(I) Atr=03(Int.) MxPS= 10 Ivl=32ms > E: Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > I:* If#= 5 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=(none) > E: Ad=05(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=87(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > - VID:PID 33f8:1003, RW135R-GL for laptop debug M.2 cards(with MBIM > interface for /Linux/Chrome OS) > 0x1003: mbim, pipe > Here are the outputs of usb-devices: > T: Bus=03 Lev=01 Prnt=01 Port=04 Cnt=02 Dev#= 9 Spd=480 MxCh= 0 > D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 > P: Vendor=33f8 ProdID=1003 Rev= 5.15 > S: Manufacturer=Rolling Wireless S.a.r.l. > S: Product=Rolling RW135R-GL Module > S: SerialNumber=12345678 > C:* #Ifs= 3 Cfg#= 1 Atr=a0 MxPwr=500mA > A: FirstIf#= 0 IfCount= 2 Cls=02(comm.) Sub=0e Prot=00 > I:* If#= 0 Alt= 0 #EPs= 1 Cls=02(comm.) Sub=0e Prot=00 Driver=cdc_mbim > E: Ad=82(I) Atr=03(Int.) MxPS= 64 Ivl=32ms > I: If#= 1 Alt= 0 #EPs= 0 Cls=0a(data ) Sub=00 Prot=02 Driver=cdc_mbim > I:* If#= 1 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=02 Driver=cdc_mbim > E: Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > I:* If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option > E: Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > Fixes: 01e8d0f742222f1e68f48180d5480097adf7ae9f ("usb: serial: add support for Rolling Wireless RW135R-GL (33f8:1003)") Please only use 12 chars for the commit id, and make sure to use the summary from the git log, that is: Fixes: 01e8d0f74222 ("USB: serial: option: add support for Rolling Wireless RW135R-GL") > Signed-off-by: Wanquan Zhong > --- > drivers/usb/serial/option.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c > index c71461893d20..dfec7467b36c 100644 > --- a/drivers/usb/serial/option.c > +++ b/drivers/usb/serial/option.c > @@ -2466,7 +2466,8 @@ static const struct usb_device_id option_ids[] = { > { USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x0302, 0xff) }, /* Rolling RW101R-GL (laptop MBIM) */ > { USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x0802, 0xff), /* Rolling RW350-GL (laptop MBIM) */ > .driver_info = RSVD(5) }, > - { USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x1003, 0xff) }, /* Rolling RW135R-GL (laptop MBIM) */ > + { USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x1003, 0xff), /* Rolling RW135R-GL (laptop MBIM) */ > + .driver_info = RSVD(5) }, > { USB_DEVICE_AND_INTERFACE_INFO(0x3731, 0x0100, 0xff, 0xff, 0x30) }, /* NetPrisma LCUK54-WWD for Global */ > { USB_DEVICE_AND_INTERFACE_INFO(0x3731, 0x0100, 0xff, 0x00, 0x40) }, > { USB_DEVICE_AND_INTERFACE_INFO(0x3731, 0x0100, 0xff, 0xff, 0x40) }, Johan