From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38C20282F3F for ; Tue, 12 May 2026 11:55:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778586913; cv=none; b=entvDuut84rSaLVDwU9M9ksJPFRlYiHR+XDQARcbv5EelFCzTS0djCLFeiP9pl81Oh4kO33DH9/wL/SqWyG+EuXOX5D504WEZbzT8Pre6eNceJON7Y7Zb5AnmFIUaqOgo0WTJgVvozK/2kG68pSPpbaAnYA68yIjUoYEoco5scA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778586913; c=relaxed/simple; bh=3pSQsQHYVTW7+KRXHIcIg2Do+tnAq9phi2FcXevjWYM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=r2qvoUeU96dm1totPQ/AsLkrH4iG3eB0qviesDpPe1GH8/M1jLyB2wq0h/Wu0t1IqRSUNFvQ7PCbJenRWqWe1gRk15sRMFsjW04cCksnDmUyEz4FaB3f81FNJ5xJuYywlqeeFJO/D+J8JYjPuAnW5RuShbVXZPnSoVa9GXSRe5s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gi4CW3U9; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gi4CW3U9" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-48a7fe4f40bso63062865e9.0 for ; Tue, 12 May 2026 04:55:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778586911; x=1779191711; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=eU4FV96CerSlsET7AI/qVZr6xvTD9nNAKpYXzn6pQkU=; b=gi4CW3U9auBVRFL6Za0m0/wDm0hjNjqcWk3AkXNgEVR2ns96Z6w6PsxKkV+GdWQVC8 sBKMadthEMLZ0pokXplUXAIyWm3ea+7OYieSbca6BmNPfDFWik2PnlAkUf8arFCxyxcJ qkm9KBjqd4XEiHjsuuOOg9cxSEP5oU4hSEzdXw8fsO5z1OHSA1/tJcP6pF6xjotoLGUL uNIMzrE7gRCYo3ybUhqf9J/uqVY/+enJF6PC1EYo+4ootB915hNfL4+uk8BtqsVK0psm HDBDclU/vMPqJr0/X0BcuMX+Im3V7mTia0yBykl3yCocnOVu+s/Wejs5h4vnCIQUsXMW Xr+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778586911; x=1779191711; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eU4FV96CerSlsET7AI/qVZr6xvTD9nNAKpYXzn6pQkU=; b=KM3nqGDPhe1qtYNnRaWAQxxri1A09eYIPOuP/rXQyx/D5vLTX0emd82EWa60FOhEyC N+J3/hEjnFINg6dIXzn03keSpJs+5entJJljAh83GDOXAvOsLOHfuU54BrWHUT7AwTG5 9dKJST+96QhLvtFXg6y7mgD/KBrDxrM35Ra98Db8/b9iehVpo4166fe4AK3ic4opoOjE uwa6KiDi/poo47SU2ekbe2Ely2S32vclMVfrYjtFeNywWwqDtnXpbYPvRBaoxrj4LpqR WNdS5pFmcrvrbb0uq+xpH8TTaL3MkrDKoig3fZxcgk+gi1USIhI+z5izhCGUlzWSJAlo 80NA== X-Forwarded-Encrypted: i=1; AFNElJ/kcz+ioUrfL34oqapHzUuVbH+v+U0CQAQfmCoC1IUrP0jcyzlbfc8MHz5KSr2aAB+eI+vFdVI5dsqF8Fc=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/w8OnuDmlt3eqRFk54ctpc+xpYtu0tCzNSlhOynHbjDWdjlFy 90FZFa19s7JJ+1fPf05IMZcrHi635H3VmftneUq28lisG2bD6HAyfyExvF668+XzOz8= X-Gm-Gg: Acq92OG3yA6oaSlnEu6GWmdXLl9eZGXG/0RWtxwXAy5Ty+w/vVXpSaio6DPNE+OsV7b HPkJZmfz3q0lolo45AR2dxselYO4GrVEeJ2DVDB02aIXNFrd1nzCmBCnPCVVHDeM/cqm25fWjsz JDwnQad/ZfuIHzqhIrSZEx+56xO5pnZS9rAwgj+UfFmRn3C3KMSoTyvgP63XrFfctJgd4N95WQs IgE0E3NVSZTu3yds4LL7+BLERGExTBR79nKZz/Jag1E9jNLy9JhAEq5CqFb89fu4EXcd69tJp6h O9X3ZAQ9DHi691KcX98ob97ARqvwFTq0KGIxD5ix3OPN3pKXKGRWCw3FYzrVxZqLttJ8XYIzcfE oKh/asuJKBCBOApNV+2r0rf9rcQOeO7KtmMgprdpWel1wqu7dIB9WQQaQbm7xKdfny6PnqEaDjw 6/FsJNCRYBtbcS9Il9DOTKdSS6HeHMZg== X-Received: by 2002:a05:600c:8888:b0:48e:8dec:19ad with SMTP id 5b1f17b1804b1-48e8dec19bfmr42830975e9.12.1778586910379; Tue, 12 May 2026 04:55:10 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e9055ec3dsm38923785e9.0.2026.05.12.04.55.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2026 04:55:09 -0700 (PDT) Date: Tue, 12 May 2026 14:55:06 +0300 From: Dan Carpenter To: Ashwin Gundarapu Cc: gregkh , linux-kernel , linux-staging Subject: Re: [PATCH v7] staging: rtl8723bs: remove unnecessary braces in rtw_mlme.c Message-ID: References: <19e1c077ee4.2272059b46402.3689085453526247548@zohomail.in> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <19e1c077ee4.2272059b46402.3689085453526247548@zohomail.in> On Tue, May 12, 2026 at 05:21:53PM +0530, Ashwin Gundarapu wrote: > >From d60236e3784e4258a7fe5e173d603d2b05d2af21 Mon Sep 17 00:00:00 2001 > From: Ashwin Gundarapu > Date: Thu, 7 May 2026 21:29:11 +0530 > Subject: [PATCH] staging: rtl8723bs: remove unnecessary braces in rtw_mlme.c > > Remove braces around single statement blocks. > > Found by checkpatch.pl --strict > > Signed-off-by: Ashwin Gundarapu > --- > v7: Added version changelog below the --- line as requested by Greg KH. > --- > drivers/staging/rtl8723bs/core/rtw_mlme.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c > index 9cf1c95dd924..c14b8dbd478b 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c > +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c > @@ -483,13 +483,13 @@ void rtw_update_scanned_network(struct adapter *adapter, struct wlan_bssid_ex *t > break; > } > > - if (rtw_roam_flags(adapter)) { > + if (rtw_roam_flags(adapter)) > /* TODO: don't select network in the same ess as oldest if it's new enough*/ > - } > + Nope. Please be more careful. > > if (!oldest || time_after(oldest->last_scanned, pnetwork->last_scanned)) > oldest = pnetwork; > - } > + > You're introducing two blank lines in a row. > /* > * If we didn't find a match, then get a new network slot to initialize > @@ -2410,9 +2410,8 @@ void rtw_update_ht_cap(struct adapter *padapter, u8 *pie, uint ie_len, u8 channe > > len = 0; > p = rtw_get_ie(pie + sizeof(struct ndis_802_11_fix_ie), WLAN_EID_HT_OPERATION, &len, ie_len - sizeof(struct ndis_802_11_fix_ie)); > - if (p && len > 0) { > + if (p && len > 0) > /* todo: */ > - } > Same. regards, dan carpenter