From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCF0B39A4BF for ; Tue, 12 May 2026 12:51:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778590285; cv=none; b=O23ZivrtYiayT/gGxswRCyb+of50oT2VpmzoPweEiZlHZseXwSwfyTo3sHVTO8oHYKTW0Q30urr6+pwYqWIUMgqQan+d3Zd84Wg/Jm3i+1+qxFwrdsLbajnBqaQNqk9BFBn74gKuj2ybnA4e8V25QLHWBBTIPUP0bdVD1a7VKM8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778590285; c=relaxed/simple; bh=mbpkaDTn1b07+htupvYfL+6q09zJWtdx7/6KsRRZNt8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ofBF8j1Za8oCqjycxAjXmyMr1ehJsFsn6sI/4mTCJrf2ZdqrrwlPZFBck/k1MKfJsu9rx8wVbCrlgjQtk8N5QKe+VtLUEavF48Vi+D0Uyut+iat9T1AOngmdm+EN66YDNUAISQ95DRkm72mHQ9DF2y2tp96OtWTh97HhME3G2tU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=c/RlsusY; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=rxzqObN5; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=c/RlsusY; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=rxzqObN5; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="c/RlsusY"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="rxzqObN5"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="c/RlsusY"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="rxzqObN5" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DB79E6C2B2; Tue, 12 May 2026 12:51:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1778590281; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n52nbh98duZbiXz6dP3xRLV5JP3pfEgj9aRozhxR34E=; b=c/RlsusYjpJc0Whj9npQgFgFhDUsQTZ27RgdKeMxCJkkNFhNTkL8eE6CRNrS6yZsUIvFZM QDmVwbK3bn7xU68l70dsXKwPQYhauRvDIKUls1QhCutEF33/kGPkHhqXPCcf6S4SeXmLmu 0EkjQztP48ez57siRoSAJ2A73iaMilQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1778590281; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n52nbh98duZbiXz6dP3xRLV5JP3pfEgj9aRozhxR34E=; b=rxzqObN58l+TTkwlmve3Dl4zMycYYl0dvT/+QF/El+OLlqfZ9FclGRur1QyRF5ifoCBvEn diNWerpMcWq1jJDQ== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1778590281; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n52nbh98duZbiXz6dP3xRLV5JP3pfEgj9aRozhxR34E=; b=c/RlsusYjpJc0Whj9npQgFgFhDUsQTZ27RgdKeMxCJkkNFhNTkL8eE6CRNrS6yZsUIvFZM QDmVwbK3bn7xU68l70dsXKwPQYhauRvDIKUls1QhCutEF33/kGPkHhqXPCcf6S4SeXmLmu 0EkjQztP48ez57siRoSAJ2A73iaMilQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1778590281; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n52nbh98duZbiXz6dP3xRLV5JP3pfEgj9aRozhxR34E=; b=rxzqObN58l+TTkwlmve3Dl4zMycYYl0dvT/+QF/El+OLlqfZ9FclGRur1QyRF5ifoCBvEn diNWerpMcWq1jJDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D3B62593A9; Tue, 12 May 2026 12:51:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 2BiQMUgiA2pdLwAAD6G6ig (envelope-from ); Tue, 12 May 2026 12:51:20 +0000 Date: Tue, 12 May 2026 14:51:19 +0200 From: Oscar Salvador To: ackerleytng@google.com Cc: Muchun Song , David Hildenbrand , Andrew Morton , fvdl@google.com, jiaqiyan@google.com, joshua.hahnjy@gmail.com, jthoughton@google.com, mhocko@kernel.org, michael.roth@amd.com, pasha.tatashin@soleen.com, pbonzini@redhat.com, peterx@redhat.com, pratyush@kernel.org, rick.p.edgecombe@intel.com, rientjes@google.com, roman.gushchin@linux.dev, seanjc@google.com, shakeel.butt@linux.dev, shivankg@amd.com, vannapurve@google.com, yan.y.zhao@intel.com, Dan Williams , Jason Gunthorpe , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/6] mm: hugetlb: Move mpol interpretation out of alloc_buddy_hugetlb_folio_with_mpol() Message-ID: References: <20260506-hugetlb-open-up-v2-0-826a0c5f28fc@google.com> <20260506-hugetlb-open-up-v2-2-826a0c5f28fc@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260506-hugetlb-open-up-v2-2-826a0c5f28fc@google.com> X-Spam-Level: X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_TWELVE(0.00)[26]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MISSING_XM_UA(0.00)[]; TAGGED_RCPT(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; R_RATELIMIT(0.00)[to_ip_from(RLa1jia3o8a9x8abp87x6pc54n)]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[linux.dev,kernel.org,linux-foundation.org,google.com,gmail.com,amd.com,soleen.com,redhat.com,intel.com,ziepe.ca,kvack.org,vger.kernel.org]; RCVD_TLS_ALL(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; URIBL_BLOCKED(0.00)[imap1.dmz-prg2.suse.org:helo,localhost.localdomain:mid,suse.de:email]; RCVD_COUNT_TWO(0.00)[2]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,imap1.dmz-prg2.suse.org:helo,localhost.localdomain:mid] X-Spam-Flag: NO X-Spam-Score: -2.80 On Wed, May 06, 2026 at 08:54:38AM -0700, Ackerley Tng via B4 Relay wrote: > From: Ackerley Tng > > Move memory policy interpretation out of > alloc_buddy_hugetlb_folio_with_mpol() and into alloc_hugetlb_folio() to > separate reading and interpretation of memory policy from actual > allocation. > > This will later allow memory policy to be interpreted outside of the > process of allocating a hugetlb folio entirely. This opens doors for other > callers of the HugeTLB folio allocation function, such as guest_memfd, > where memory may not always be mapped and hence may not have an associated > vma. > > No functional change intended. > > Signed-off-by: Ackerley Tng > Reviewed-by: James Houghton Acked-by: Oscar Salvador > --- > mm/hugetlb.c | 20 +++++++++++--------- > 1 file changed, 11 insertions(+), 9 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 8be246b4e6134..ea3bc405b3162 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -2160,15 +2160,11 @@ static struct folio *alloc_migrate_hugetlb_folio(struct hstate *h, gfp_t gfp_mas > */ > static > struct folio *alloc_buddy_hugetlb_folio_with_mpol(struct hstate *h, > - struct vm_area_struct *vma, unsigned long addr) > + struct mempolicy *mpol, int nid, nodemask_t *nodemask) > { > struct folio *folio = NULL; > - struct mempolicy *mpol; > gfp_t gfp_mask = htlb_alloc_mask(h); You already get gfp_mask back in alloc_hugetlb_folio(), so maybe just pass it here, so it is clearer to the reader that these are no different masks. -- Oscar Salvador SUSE Labs