From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC2AA3A5E8C for ; Tue, 12 May 2026 22:31:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778625099; cv=none; b=QajTFJrH34sr5PVGL944O2dhIR0lDt+nSMHZKYt9xHLYgkcgMI88C2PmhCC3Zo6R4um1NwS46atYPg/RAJqGJKRbPBq5sFTYVOvz38/pH+uPKiDy9ueVLeiWjtD2xGRfFyKcBZbcgnFos9MePB2ftJPueET1wjHWxcpqhb6Ts+g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778625099; c=relaxed/simple; bh=bcVfxasbit4U2yzziAt1k9ONFCXfeXaWbNjOlT3ECP8=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=hEka4eMaEqLBVbcnfVyiflo6/gtmSToGGf4bmnzvHDveAcRPAHn62z+K3y+LNHad90c1Rzhm7QN4XTsVJv0uTlgzzjSJhfU/wp47axUR0nVS3rN+aQTriP6s1fzCVBcC9j1qgxeTMhK3iI87+kJ73odQyyzDOSQQDLmwofkd0BU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=joSHRhIC; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="joSHRhIC" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-367bb9caa54so4953047a91.2 for ; Tue, 12 May 2026 15:31:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1778625097; x=1779229897; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=M7/ckcGX/26EFOsM99Da2/PEjvZTD7dt6PJubXtrn78=; b=joSHRhIC+/nH+3vJN0zqUJSQ4gysMKvBeXtMDR7EW93hOYfyrNVjI+W6H8wvfxEIeQ 8rAJX7Yxyo3VXvHssz1yZzDwmnpJeS7Phoffu8mXIq192RbVHYqD/BcIWogqNqBy0sm/ c+ts+GU7879UjxZZpXNzEjtCkltwwnm/JA2M9qq8au9qcaRTMEmF8SYuM4YZfG8GcE/w FXc4U6S13TyGH5NnxnFW6ac55pR0pL1+p5SgtM7R7uTx40USQ9C9vkniGDLlSKCMczZv aSIS3jfIsj8kDkJtZcDJ7jCJfSvRsQ5pJWCO0ASJncaO7OJ+EvfjNxm/mr5NNQ0Phdx9 TiPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778625097; x=1779229897; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=M7/ckcGX/26EFOsM99Da2/PEjvZTD7dt6PJubXtrn78=; b=FJrdI/npTinixCKfYZ+WALJA6LsErdD1svNC2tQxYafvdHa8DZJlJMiUf4C6DjV7wT 9FY68tpiFzs5iqjCpzHzpqb8SVBT4I/MTY2TeH3UQPrR3x+MkMPSpH6W0j3yo1uUWnwF urE7tVFBvNH0CFqKYtGoVg/1dUFu/nbzYA2Ce8OVexLo/GL2t1fxoEaoqnIzhPAd4odL D+zLNrY5kMzsbV9T/IqP3Sys+p9jUFmU5NF/GulPPkJ7ZJiZY17GA9vnWS5Qgq7I272W NpX3siYBOZKFBNKOrhuMUot7KqGfkkDiL5s1ECkEnrhvQFJuHF/xNSfOlxF7S5OLiQVU JJsg== X-Forwarded-Encrypted: i=1; AFNElJ8cgcXkzC6IYgu+6WPQiGhPM6oIT9oCo+7J2Kc5S2e56poFTB1yx1TSQupDS6ym0gUmy91KVM4a550ezg0=@vger.kernel.org X-Gm-Message-State: AOJu0YxEw+bJN9wnesr/0MMVCHfJs/LfZVuSy21VDCrJ7F3bF2CcrLYD P6s1m/SqdxGAnnav32bz6t6o6XOJIJVkEsvm7frCtGpZCRKlqmiiZT4YgXFYITA/QgAFT0WMnNS 9h0z+zw== X-Received: from pjbsb13.prod.google.com ([2002:a17:90b:50cd:b0:368:a71f:a24a]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:3c8a:b0:35d:a0b7:9608 with SMTP id 98e67ed59e1d1-368f3aa426fmr918102a91.7.1778625096688; Tue, 12 May 2026 15:31:36 -0700 (PDT) Date: Tue, 12 May 2026 15:31:36 -0700 In-Reply-To: <20260508091829.GO3126523@noisy.programming.kicks-ass.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260423155611.216805954@infradead.org> <20260423155936.843498069@infradead.org> <20260508091829.GO3126523@noisy.programming.kicks-ass.net> Message-ID: Subject: Re: [PATCH v3 1/2] x86/kvm/vmx: Move IRQ/NMI dispatch from KVM into x86 core From: Sean Christopherson To: Peter Zijlstra Cc: tglx@kernel.org, linux-kernel@vger.kernel.org, Jim Mattson , Binbin Wu , Vishal L Verma , "kvm@vger.kernel.org" , Rick P Edgecombe , Binbin Wu , "x86@kernel.org" , Paolo Bonzini Content-Type: text/plain; charset="us-ascii" On Fri, May 08, 2026, Peter Zijlstra wrote: > > Move the VMX interrupt dispatch magic into the x86 core code. This > isolates KVM from the FRED/IDT decisions and reduces the amount of > EXPORT_SYMBOL_FOR_KVM(). > > Suggested-by: Sean Christopherson > Signed-off-by: Peter Zijlstra (Intel) > Tested-by: Vishal L Verma > --- Acked-by: Sean Christopherson > @@ -7152,17 +7149,9 @@ static void handle_external_interrupt_ir > "unexpected VM-Exit interrupt info: 0x%x", intr_info)) > return; > > - /* > - * Invoke the kernel's IRQ handler for the vector. Use the FRED path > - * when it's available even if FRED isn't fully enabled, e.g. even if > - * FRED isn't supported in hardware, in order to avoid the indirect > - * CALL in the non-FRED path. > - */ > + /* For the IRQ to the core kernel for processing. */ Forward? Or just delete this comment entirely, either way works for me. > kvm_before_interrupt(vcpu, KVM_HANDLING_IRQ); > - if (IS_ENABLED(CONFIG_X86_FRED)) > - fred_entry_from_kvm(EVENT_TYPE_EXTINT, vector); > - else > - vmx_do_interrupt_irqoff(gate_offset((gate_desc *)host_idt_base + vector)); > + x86_entry_from_kvm(EVENT_TYPE_EXTINT, vector); > kvm_after_interrupt(vcpu); > > vcpu->arch.at_instruction_boundary = true;