From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2215612D1F1 for ; Wed, 13 May 2026 05:21:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778649693; cv=none; b=FzPXf8TVGjkJSVyoXhOwZG4r8Xouxf/vmBguaDevEPXfAEFKCFMU9iMYyC2YTzM+I+JVCUA2YMtSQJWsXNJ+uek8mMksMGUNw5MFGxK0tAZCWeEsN+j7S2Q6bGGIyrCZV+Cm4W4HaNHLxZ4WvVjYw+ekqmV02SNDPJEjCB7oH24= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778649693; c=relaxed/simple; bh=U/k7wP4nof29hIub7t/vN2DJlMFD7yWaztzvzuGKqd0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GVOdA/iPhTXZTMd9Yn1q2qW3RPy0kEMx9+FxR5+Jqz4t1PpRsjIGm0o7Zoomb1bx9c30cewD2Sj8oJG5HNG+3ME+XmKS/lllrwKMMYarvg2n7JPIvK9WZfVzJHNqfd6jfqDSarpAcuS8ustwUWj1kWlFl3hLIttWEm/Ix6OcZrI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=LYp47UHn; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="LYp47UHn" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=k+nq8dgADBoiyTyjYHwy7GvXLat+nsmv3RDJEo3Azbg=; b=LYp47UHnu/NV0LA7wdv5Edu8J1 UVwUlULFSOySubGo2P8zx/2xe76V8zC4COHwh39gZEHd4xLVObGAyRsuXRwzuPadozuEvrJZrthqJ HvE3do0/oK0oCSW1R8z7Zw25AYS4IM6j+O74slVDJfOjdVPQeOhZlw0ZRD6VX5WZJUR05/XigSMtf B5qKvIiGOsqOi7Dooqt5NGFb0zt4J0rvQqUCt7VyAVbsOc6rs9BSnzaowd3rwHLq3Kp7jrrGnJB+F CBAHfRiXCzTelmpBCCLNUPf4jTXT7/OPbv4WY/bw6cEIaIJge9GBg39N4dBXNH3MFbWxRBQU/8WZk nwyc7Jhg==; Received: from hch by bombadil.infradead.org with local (Exim 4.99.1 #2 (Red Hat Linux)) id 1wN21z-00000001J2I-1vTY; Wed, 13 May 2026 05:21:15 +0000 Date: Tue, 12 May 2026 22:21:15 -0700 From: Christoph Hellwig To: Baoquan He Cc: linux-mm@kvack.org, akpm@linux-foundation.org, chrisl@kernel.org, usama.arif@linux.dev, baohua@kernel.org, kasong@tencent.com, nphamcs@gmail.com, shikemeng@huaweicloud.com, youngjun.park@lge.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 1/3] mm/swap: rename mm/page_io.c to mm/swap_io.c Message-ID: References: <20260512104201.716213-1-baoquan.he@linux.dev> <20260512104201.716213-2-baoquan.he@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260512104201.716213-2-baoquan.he@linux.dev> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Tue, May 12, 2026 at 06:41:59PM +0800, Baoquan He wrote: > Codes in mm/page_io.c are only related to swap io, it has > nothing to do with other page io. That is true. At the same time it also (mostly) isn't about all swap I/O, but specifically about the block based I/O backend for swap, and secondarily a little bit about helpers for the swsusp I/O to the swap file, with a little bit generic swap I/O wrappers thrown in. So the new new isn't grest either. And I'd rather wait with this until we can nicely split stuff out - the rest of this series is a good step toward that, and my swap_activate series is another. After that we should be able to stop creating swap_extent structures for SWP_FS_OPS-based I/O, and contain struct swap_extent with the bio code and actually create a coherent abstraction. This will require moving a bit more code around, though. My preference for the resulting name would be swap-block.c or swap-bio.c, but that's up for future discussion. Can we just skip this for now?