From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B05EB3E47B for ; Wed, 13 May 2026 05:45:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778651156; cv=none; b=FzsjuceMbgc5PEYnoPYUKz02KQaKFIdBDUuFs1+l3PU3rF/r+hKGmzf54zvsYE3WsTpPPf72Q5lqoUmolonxZoSXQSgVqM1DpLNgaIHEw+6D5P32X5aUxK52X/MTAkcx4G8UdK/4xLwjEyNfKBjUTTZr79T2IIQdyFF/ntCT/+M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778651156; c=relaxed/simple; bh=kCOjq/VsA7iCs12DiLnqafDe3qdguO0vapzWucYAl8g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=evLpGTEuiFBLSm8LLsUYvhbuwtXiDlNC8v/jC0cYOnAH1cg6b7boYivQpuiAIZnUfkIYociTF4sl7aIQVF5CrrjPlkwq0niWH7/+8ieSXyePOAMr33KjzFeNHpO5v9fAIeD+laempdaQ72E1YCpmU/YTRYJQSQJJJWKQ0YAlgZQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=3X7/lU+4; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="3X7/lU+4" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=kCOjq/VsA7iCs12DiLnqafDe3qdguO0vapzWucYAl8g=; b=3X7/lU+4mWfhs5iNNSdlJFsH0F AmuyqInwXN1Y6Yu1FUcIspAM5niIHfNNymcWcDmos1fE/gXiq1ty7jpAJnJb3Cr1pLn2MO03sLSFt rQnHJh8sNGeBVsh8Kq51sYs66UGWOrY9xbHbF0POUtJKs1NadQWW4xIUxorBsTCWvX5OCXVP8o+BF dvf7sjZ5Pyscc8YHFoin4OVOY1uwHkGn+CEO+77dN0QxLK5xlBRvKdYaAqTjhnzfN+HwcO+pH0dQS icrSRMNpEvMvtmiYvjJSbqDSi4h83OZFzDPW1DSh66r/xUNLMcefhoD14Ps1pX14hhP0CvmWs2af7 SWYFPKjQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.99.1 #2 (Red Hat Linux)) id 1wN2Ph-00000001MPx-1zgm; Wed, 13 May 2026 05:45:45 +0000 Date: Tue, 12 May 2026 22:45:45 -0700 From: Christoph Hellwig To: Baoquan He Cc: linux-mm@kvack.org, akpm@linux-foundation.org, chrisl@kernel.org, usama.arif@linux.dev, baohua@kernel.org, kasong@tencent.com, nphamcs@gmail.com, shikemeng@huaweicloud.com, youngjun.park@lge.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 2/3] mm/swap: use swap_ops to register swap device's methods Message-ID: References: <20260512104201.716213-1-baoquan.he@linux.dev> <20260512104201.716213-3-baoquan.he@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260512104201.716213-3-baoquan.he@linux.dev> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Looking a bit more I also think this abastraction is still leaky because the unplug calls for fs based swap aren't properly abstracted out. (note that it would make sense to use them for block based swap as well, as building a single bio will be a lot more efficient than relying on block layer plugging, but that's a separate issue)