From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C9CA3A759E for ; Wed, 13 May 2026 07:53:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778658784; cv=none; b=VuNO2kHwz/GkwXH5XaXWxTp5cQgFPfMi1GLvkSxQGpBBG+4e0NXASACD2VGJBydcbaf6/KshtBZ6UtnJoTJZ92lndHARfKUK7zRHX85EFeGfCDUXFpFwhvjGhe16tP2V/G52qzZ7jhSZFOw4ddFkkuNga8pXsqLYckOWafJKs8c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778658784; c=relaxed/simple; bh=Dop4pZxScudWKS4ltQhKDt8/6TrzV1cgZE+0HEmFWHk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Rq/KABUPnBE1cn8Fkk139GtGDsLoyx0+xfyFsbFukROv58CAcLkviuqc048iQOhC/ayAKCGkWIXY1kRLoic4pOqB/5OO2vvBDPc+cG6qqzXPLgZYsoWYR30ehewHfzLBsTa+UVb+ifVcNNO0ZrbFoVAvLZ9noUdTaJJ4/IKGrQw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pk1CFyd7; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pk1CFyd7" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-488ad135063so51575525e9.0 for ; Wed, 13 May 2026 00:53:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778658782; x=1779263582; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=STHxK4qvqeQ0RbAPJE0Gc4vNM5XKJnXw+gBlPnD0MgQ=; b=pk1CFyd7hpkOm4FQQ0MjsAtq36sY5yKyxGc/A9U7mNRYaojpTwkdalTEv0UkD0s3eo QPrt+mcEcloFB1Jp7uVQHCp9TRrC9PuOpSDPswLwUapLuxyhExRBXGUQld1f9ROMRe+b gikTUfItgnFZLNNycwj+KdOIVVkOzIsbaTDinRJ59rBFsgCRIwBF0E471ZORDdg18J/D gD7SdRtZy7VdB6gBt8E8ncyVoTc+8GnmxA1Y9HtoZaJFlMUpyscL2JEVVtJr/QrfD+jh He1LBFfZ4n3krTXkPOOF8CgHQJxG+dPeWlSOKoG/kwh59TggSbYhEJmcL+hIFQOq/EJR VSXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778658782; x=1779263582; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=STHxK4qvqeQ0RbAPJE0Gc4vNM5XKJnXw+gBlPnD0MgQ=; b=qk5ZyT+XdOfSC7R2qgKaqBhuMIYu1t7udb/t9pVSJAvzbizlGlZ/pZVvTyy4oWjkhF PTyESEKZ/7FwCcCeqmEMRGnD1ZGxob8ZOGG1LUwOVJNM4JXUv5LxN7kuk6S6ouOSYysy HwqJgDXInFijae8TYpJmSiIoGMb209SRi72ViNhwJZLXiGsKK8Yo/jog/AP2ly8lT7fz JXyLWMxaTYWQ2GVTrfRRC7rgo8PRZnpqI3zAysali/CkCuC/y45B9D57ww2gI/1UMvlX W64kWjLsnKlycWpYbxPf9ynfLmUI4LnUuMMBjDFUvqBvrnEQhAlU0ivaRk6dyoVpkoj/ OJRQ== X-Forwarded-Encrypted: i=1; AFNElJ8dP42Zo/sIQEaIiuymgCAuVR3E2ZA9fnWmBIuQhagvdgHAXAr1I9YNSUEOKN84fzXkBt0xCopCo0oK9ZY=@vger.kernel.org X-Gm-Message-State: AOJu0Yxe1q04jteqovZ6PN4KIs3CnRv6fH19eg9Pc5J6O13eXY/usTvA 1OkZAwa3AGXAnDgzWF4Xat+lwi0K7zxngW1tPEGJLELsI737jce4ipwv X-Gm-Gg: Acq92OFSq8JG4Nk7lhR4gLWW1e694E0bdq1O7XeBcC+Iqh24WdWFqByooTjlrZzmsn/ KOI10ijMEtjFG0latm2NoEd5P6zpxRzxTNX1wDPEaRq3aiPn/M5K1Yqy6cWCUrIGh3UxGYFDdlF 1BxlaS694LBgXmtwtwwQUFIVswGlaP+YlQTpGJM637Cl7aUViQUFifpc3isK00zp2kRuIxl77Zq XUdoJK4tlOdxzGlZMkNB9GQ5XnBhLLbLcZia8ItCY/lkLHHffVfGnefMIA4Jx3W/AAjUnYfdk5h +H71aBZYfo8JLWlANQmW0g95RJDWqab+AOcKGZ0mCFz5ljvoaqpBVb2yNnxgjcJ5O31BSb7gwVc 6R1s3smMEtQZf7Xl10+CK/iXr9sDj1gG2uXdo9dIC0yyD1TVnoZfL265wmlzz0+eJS4CxBHvQEU Q9O/SeQp8mu5m8oe+VwcLi/RoGrqsUirZ2nh8q2L+dtFg+7+H67AUbJmlIBbS5t/zf6DWIULBmS 4QHeFdt9VCyoJ/lszD5OarEqc1VOnP22DHFCxBdfAyQ X-Received: by 2002:a05:600c:1547:b0:48e:8499:4bd7 with SMTP id 5b1f17b1804b1-48fce9eb099mr21737525e9.17.1778658781539; Wed, 13 May 2026 00:53:01 -0700 (PDT) Received: from fedora (cpc92878-cmbg18-2-0-cust539.5-4.cable.virginm.net. [86.16.54.28]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fc8d19974sm52175545e9.2.2026.05.13.00.53.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2026 00:53:00 -0700 (PDT) Date: Wed, 13 May 2026 08:52:58 +0100 From: Vishal Moola To: Tal Zussman Cc: "Matthew Wilcox (Oracle)" , Jan Kara , Andrew Morton , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm/filemap: fix page_cache_prev_miss() when no hole is found Message-ID: References: <20260512-prev_miss_fix-v2-1-4af8e5c1ae62@columbia.edu> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260512-prev_miss_fix-v2-1-4af8e5c1ae62@columbia.edu> On Tue, May 12, 2026 at 04:45:59PM -0400, Tal Zussman wrote: > page_cache_prev_miss() is documented to return a value outside the > searched range when no gap is found. However, the no-gap-found path > returns xas.xa_index, which after a successful loop is the first index > in the range. As such, that index is misreported as a gap. > > The sole caller, page_cache_sync_ra(), uses the return value to estimate > the cached run preceding a sequential read. In some cases, the buggy > return value can undercount the contiguous range by one, shrinking the > readahead window or pushing borderline requests into the > small-random-read branch. > > Fix this by returning the start of the range - 1 when no hole is found. > Update page_cache_next_miss() for clarity as well. > > Both helpers were previously fixed together in commit 9425c591e06a > ("page cache: fix page_cache_next/prev_miss off by one"), but the fix > was reverted because it caused a hugetlb performance regression. hugetlb > no longer uses these functions and next_miss was subsequently refixed > in commit 901a269ff3d5 ("filemap: fix page_cache_next_miss() when no > hole found") and commit bbcaee20e03e ("readahead: fix return value of > page_cache_next_miss() when no hole is found"), but prev_miss was not > addressed. > > This was found by pointing Claude Opus 4.7 at mm/filemap.c. > > Fixes: 0d3f92966629 ("page cache: Convert hole search to XArray") > Assisted-by: Claude:claude-opus-4-7 > Signed-off-by: Tal Zussman > --- Reviewed-by: Vishal Moola