From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 067AE3955E8 for ; Wed, 13 May 2026 09:40:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778665219; cv=none; b=AYaUZ9L+Wt7qqQAPgQXiR8c4e1Buyecsa08nlGQsKq95kHsNd1IZmZ9rD5u/qsd07MfyuhlQXsp0qrfgaxeOfrrfDJGFMAsVLw1hWoO9mh3C6CsK8JMbwzCMvdZAZ9EdHdHOhjkDEu/wYOJ4Z+czGIVivgZkMAbF19bk8JbumXI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778665219; c=relaxed/simple; bh=RAtC9l77W0bPuQMW0/WWijaFhrPnbBjPlx5TjNTS8LI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NM6+VeG2t5IV/Llz2hR8j5ZduucjJK6anS9fFwsSx9kshwOwZfnK+py588WWMBqRqLsX93/l7VnJlB18RHbRPbXNt2O7PTL2DxjhmofJYZHm59yvaMDQ0HivF2Sqfsfhw+5Hm4TY9/zpOfu94BPp7N4zsibz3jvIXB0W8OYMs1g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=STfxvOfL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="STfxvOfL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3809AC2BCB7; Wed, 13 May 2026 09:40:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778665218; bh=RAtC9l77W0bPuQMW0/WWijaFhrPnbBjPlx5TjNTS8LI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=STfxvOfL7bMTQyT0SRP2hq8Xadf6JEvMES4RqVeENsMr0rTC0vJ2wfK0lHoP7s6tj fj5MQwqOqJwq+nZeAHXaXi1YO3AfQOZvoS8DRcdLq1rRF1lee497+o3EMUKIj10Ihv n7/XZrWulEwDEcpi6q7K43a5CGhGhqLlR6L1b3EDVqx1Vr1f+PXzb3dusMjnn+P6Fo sDybYcIEytf1/4xZdAQhjM4cD3PheKReEjFIrdNS/lkWSHZ3QVNz1SiOYkZcVGGjjy +koUxLQzprvyvcuxOReiJ7YASk+RuGTKFK5iplDfgbHXAksOA95huS+YinY1xYwXeo HEQtO6vOAU+xA== Date: Wed, 13 May 2026 10:40:13 +0100 From: Lorenzo Stoakes To: "David Hildenbrand (Arm)" Cc: Baolin Wang , ranxiaokai627@163.com, hughd@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, ran.xiaokai@zte.com.cn, "leitao@debian.org >> Breno Leitao" Subject: Re: [PATCH 1/2] mm: huge_memory: refactor thpsize_shmem_enabled_store() with sysfs_match_string() Message-ID: References: <20260512120557.49995-1-ranxiaokai627@163.com> <7b8cb44c-a098-4430-a8ef-142fa7a19087@linux.alibaba.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, May 13, 2026 at 11:38:21AM +0200, David Hildenbrand (Arm) wrote: > On 5/13/26 11:03, Lorenzo Stoakes wrote: > > +cc David also! > > > > Unfortunately we put some hugetlb logic in mm/shmem.c too which makes > > get_maintainers.pl not do the right thing. > > > > I wonder if we should add mm/shmem.c to the THP section _also_ just to cover > > this off? > > I'd rather not. Too much noise :) Haha fair enough... maybe we should move this stuff to huge_memory.c or something, but not sure if that makes sense. Not a _hugely_ big deal though tbh! > > -- > Cheers, > > David Cheers, Lorenzo