From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE7DB3E5EF7 for ; Wed, 13 May 2026 11:09:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778670576; cv=none; b=F8iPCo58WxAtg/kn9bK6+b2tj8+fyrAFY+DLeQzE4JjMv7tq2ADqPqDixw/oNfJcgY2bLpXjLqIUEAq3pTpbScOc7OZ/2+z1+Chv9PrurUKNhK/dZeWS9OCKNoXL2OF3s4LV8y7/fymtsN8Z2EeGtuDuu1ShwaTFQE2f/y506/M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778670576; c=relaxed/simple; bh=VxZrVHvvMTsJO+0g5aFCaePGNp5xIFjPpLQeQ27rCeE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jfNobJLP5YC9RbsotiaWrosZRaB1aL0PikyVVFfFzHwOYyKoxzWh5M+GbjkWlz9M9NMFCNBptJxbsMMz7hQvcHc4ng35ToENjjZlk/hWC3+K731qFudP79Rq+fzzO266aLvnHF8wYlEsvKHu6UP0FpE5CD9VIQpCccGnIW/Y6dE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Z5iTIbm5; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=nenFu8bx; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Z5iTIbm5"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="nenFu8bx" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778670574; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/RlJfaQI3WYwGNvwR+AOHY2/jIgelfdXHLs6DnIAFBw=; b=Z5iTIbm5bKUUIEjRJ4JmkZGFP5LtcPKGUbICWxR7OJcnYb42FoFcHE7vJ1aamFZMsenyW3 3TuC8H7OP8KxoT5/EFwWa7JXGgDd09RucmwT2NXsSYNgvc3OXecntC3LkfyYuChs0Q2D9Q NB8Wzcn7+ssy6N5+ay0BY8sWQn8jXIM= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-473-fppZ2TupMU-5zBPs5R64Yg-1; Wed, 13 May 2026 07:09:32 -0400 X-MC-Unique: fppZ2TupMU-5zBPs5R64Yg-1 X-Mimecast-MFC-AGG-ID: fppZ2TupMU-5zBPs5R64Yg_1778670572 Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-367bb9caa54so5697130a91.2 for ; Wed, 13 May 2026 04:09:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778670572; x=1779275372; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/RlJfaQI3WYwGNvwR+AOHY2/jIgelfdXHLs6DnIAFBw=; b=nenFu8bxSZCxTXd1fp0cVgXYP33nQqHPbt6r6rih5bedss2xp6RMWQGq8jeZTLSTP4 5CDfPS2nHt3+eiIPjzoCzQfVI9BWkxwHdiYx00ld60vwphTP35bZlAC76TiX8BR4BbXQ Ys1xQdac0HtZ6T9Mm/r2d0MtFeQmFsE8sMZCltxs4epfK/HWNRVbWfkJpIuu7YJsM3s8 yaFGrn1Xvzngay32RRIl13yKPc1u0rcRxpllv5SnqG/50gq9VtOk02YdJh6mT5VYpWVv UI8tw73Gs2Zl8lD081KtQI8EH/9Ug7u5FJnbnyrA8SSWV6Hg8AN3mcIKAAuEh7hprU47 FCmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778670572; x=1779275372; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/RlJfaQI3WYwGNvwR+AOHY2/jIgelfdXHLs6DnIAFBw=; b=Zn3tF+BO2rdY9Nh6ljDtP6kBYSl3zt6VtFC8Z9KWR96EFI5W3f6QpW09A7DPOXskgL 205DPbUR5lOMFnx93FRfQf9XKZXhpNLQelSVJmRjw4pv8Z3BzWbcpim67C1RkyN9evy6 kEBSzioK4JMtTG3pkjrWp2SIQNo0dSxZDK7esTA43hk3c+zB/WmNgeL1mI/FkRf7WEtm rtgrFoWKz0K5PoggJaynvuKX+ZZ2plCmMUmUG/OTuo85Bhvo8spdhOypJcVhTORODurh Efflgqzjkw7LPFJ4tcrdaVrvm/03qTyd+Q18m4BVttomlddJ6BySU0HtxjcN8novlNtG tBLQ== X-Gm-Message-State: AOJu0YybfUNfhQgd4QuYho61Oj7go4CRh04k6T5pnFX0hIghAERnM34M +66+QoCx6bzYz+OmRzXk5TeH365TXxASXozK7sXheiSlbMM0R0zxLERqyC+W9eExCSQul1z+xeQ Qe+Nvj5V/FSa6VWkd91Svo1mo5HeuJrwuTTywQ1Y7tgWiCaha2kDE3Ai7q8geB13PbQ== X-Gm-Gg: Acq92OFqZVFBFyIHhVEm3hPrmVZAUOeEkx2NbaABG+m+msB+RX0OlM2B/Y8LcYknltn xa5km8cgGbHXOW8wuHRV4E4AgN8VlSajFsCEmMvQFVhvWSq8hJ+icfDo/aMDP/SbTXLxFMbV57T j0J71aQ3XuH2zGrYl1YTXr4lBbo4lgMEbtWldX9lAtIASsW168Hc6FoShIrUeHDrV0b+a/cwZq6 Phg5nHLnIU4J9OefHxfTVh+XBxDvez5O2eJFqtNJHRZkAYs6bUIDWMFnD0c7IXE7X8eFptdQPqF 5s0EQKd6lq725iJlRLYgvguGcdofZFkFuIIQ3/tEtdK7QsBJHyhOrRTmDeGhT6yBCdb2/OJtOA+ 9tUAJau5Kx+iF X-Received: by 2002:a17:90b:51ca:b0:366:3df3:fe45 with SMTP id 98e67ed59e1d1-368f3e43e84mr3063213a91.19.1778670571680; Wed, 13 May 2026 04:09:31 -0700 (PDT) X-Received: by 2002:a17:90b:51ca:b0:366:3df3:fe45 with SMTP id 98e67ed59e1d1-368f3e43e84mr3063186a91.19.1778670571226; Wed, 13 May 2026 04:09:31 -0700 (PDT) Received: from fedora ([49.36.106.210]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-368edf4d95bsm3806341a91.6.2026.05.13.04.09.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2026 04:09:31 -0700 (PDT) Date: Wed, 13 May 2026 16:39:24 +0530 From: Arun Menon To: Jarkko Sakkinen Cc: linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, Peter Huewe , Jason Gunthorpe Subject: Re: [RFC v2 4/5] tpm: Increase TPM_BUFSIZE to 8kB for chunking support Message-ID: References: <20260324181244.17741-1-armenon@redhat.com> <20260324181244.17741-5-armenon@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, May 09, 2026 at 05:54:21PM +0300, Jarkko Sakkinen wrote: > On Tue, Mar 24, 2026 at 11:42:43PM +0530, Arun Menon wrote: > > The size of the command is checked against TPM_BUFSIZE early on before > > even sending it to the backend. We therefore need to increase the > > TPM_BUFSIZE to allow support for larger commands. > > > > For now, 8KB seems sufficient for ML-KEM and ML-DSA algorithms and it is > > also order-1 safe. > > > > Signed-off-by: Arun Menon > > --- > > drivers/char/tpm/tpm.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h > > index 87d68ddf270a7..26c3765fbd732 100644 > > --- a/drivers/char/tpm/tpm.h > > +++ b/drivers/char/tpm/tpm.h > > @@ -33,7 +33,7 @@ > > #endif > > > > #define TPM_MINOR 224 /* officially assigned */ > > -#define TPM_BUFSIZE 4096 > > +#define TPM_BUFSIZE 8192 > > #define TPM_NUM_DEVICES 65536 > > #define TPM_RETRY 50 > > > > -- > > 2.53.0 > > > > Shouldn't this prepend previous patch? yes, I am going to put this and the i2c patch before the chunking logic. Thanks. > > BR, Jarkko > Regards, Arun Menon