From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from out-172.mta0.migadu.com (out-172.mta0.migadu.com [91.218.175.172])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id E597B48B38F
	for <linux-kernel@vger.kernel.org>; Wed, 13 May 2026 15:44:45 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.172
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1778687088; cv=none; b=Pxb1NdOzdBOAaBBvTmeFl/n70A7yvwDkNQnqHj6JUU+4awaQnOF0BEo62h2s551rUegDAuY15GB61S/6NLAlfVLtEIeFW07Vk7goRetW3xyyIORGnoipUH8745tZIL94p89Hfi86ObDqsK/jYM64jOSudJva7W+Jev7WZ+pSlzQ=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1778687088; c=relaxed/simple;
	bh=gEAwQV72tVVMzjIXY+Mor82GbH7T9PIQ+DtbEVemLjg=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=rt0uhAkQh7GQXLavhbR1i/TBkSrluNhoMHyhBjQnVyzmXFuuDM9eG6Fac14/isMLyuD3kMq3gOwttcX67nZKGKAaaFkK3t63hhsTjTXUvPZlklLQpoBNQLaqWMvJctsI5tOxYZkYwDwz/+lIEpkkrDY14Y+tbxmyXq7cUagKapI=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=N5BQM7on; arc=none smtp.client-ip=91.218.175.172
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="N5BQM7on"
Date: Wed, 13 May 2026 23:44:38 +0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1;
	t=1778687083;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=3KsIXS59mcRQeKKkkiOCaaEGicr+26hZlUrTN/qAN04=;
	b=N5BQM7on2iiq0um5dJyQqdxAF7ykEfIe15906gaSbLXPxajxlPdkwxyYcWqyAWf2miM2zx
	zvm9NFopmF1DRgVbBST2Oh20J8F9AfT5kxrDQ8DdEH2HttYcfitfJtRqWA5jVc7FuCoTZb
	FCoIeVagzKMMBdNt3J8VkmgFSItKCxI=
X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers.
From: Baoquan He <baoquan.he@linux.dev>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org, chrisl@kernel.org,
	usama.arif@linux.dev, baohua@kernel.org, kasong@tencent.com,
	nphamcs@gmail.com, shikemeng@huaweicloud.com, youngjun.park@lge.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 3/3] mm/swap_io.c: rename swap_writepage_* to
 swap_write_folio_*
Message-ID: <agScZgsBgL-WRAac@MiWiFi-R3L-srv>
References: <20260512104201.716213-1-baoquan.he@linux.dev>
 <20260512104201.716213-4-baoquan.he@linux.dev>
 <agQNzhC_m9zvqBUa@infradead.org>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <agQNzhC_m9zvqBUa@infradead.org>
X-Migadu-Flow: FLOW_OUT

On 05/12/26 at 10:36pm, Christoph Hellwig wrote:
> >  
> >  static const struct swap_ops bdev_fs_swap_ops = {
> >  	.read_folio = swap_read_folio_fs,
> > -	.write_folio = swap_writepage_fs,
> > +	.write_folio = swap_write_folio_fs,
> >  };
> 
> The convention for method naming is prefix##method_name, i.e.
> swap_fs_read_folio, swap_fs_write_folio, swap_bdev_sync_read_folios,
> etc.

To me _fs is a modifier to qualify the method type. If need change, we
may need change all swap_readxxx_fs/bdev_sync/bdev_async and swap_writexxx
likewise.