From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f44.google.com (mail-dl1-f44.google.com [74.125.82.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92186395AD5 for ; Wed, 13 May 2026 20:02:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778702524; cv=none; b=Okij4zmekWfT+Tj0uHmU3l1PyAo0kLeuAm0UcnOwA3FvlH4xBQ59215clnmXcV6vhLjUDkWJxreOKG/Rys5bZFV4hhhkB0zphKtOM9cgtT/x2ngUKsdhutg1VXefyXEBVIqsXQ7oxysTO0/eRDWrC8Tsxu4bP5U01zvpti/lTms= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778702524; c=relaxed/simple; bh=SUzO+Goy+cHMi7LxDDffOXrvlL47rvbUGF+iLVEkU4E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NwKxzHDW662gXbNUbHHf+1slByarg4T5hY8RZNhbPPceJXOxx3hi4ZHASnfLWY2sHVuyw0dQoSBNYDDyL06dMHhkQCLh9CIiBzu9mYxnW6DfQMFTDJpFGTjpGVjViZo5H3kK3TKtPMd8xM8FJ5CZxBT9MBFP5Jd20eZNvUYtYD4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LMnjTHH5; arc=none smtp.client-ip=74.125.82.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LMnjTHH5" Received: by mail-dl1-f44.google.com with SMTP id a92af1059eb24-13317450f83so269974c88.0 for ; Wed, 13 May 2026 13:02:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778702523; x=1779307323; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8ImgcLtFrpGQ9AHbrbrcH9nkVCHOcjM95JO8KGUOdcI=; b=LMnjTHH5WQw1dcLvVYhul6b5qLFD1Ydpu5aKl23MA3J9GMBMo5fpnIuKnwl1pY9eTa 5JUmDeqCCT3v/E4CuGi2zsxsMidKRUdj6TM7Ath4KNyrJ2JnmE1sDEibkpBRHHbPPpTM 6tvgMfECv8zgaQJbQDwO6a3FYZ+C+W6CvqJrJlFWVdSUIF2KVAN/DpKAHiM2jw1RYI10 tBUdfzf+UDx5an2jldSEB1B5W63xEK0oTlxUZ+OoUaylxVdRKSMwoS7UVNgiTSXAoVWo oHw6KB4g9HCs6eH+hZVDgihb8aUThC6lguTE7vSxO0dBpYclwY4NnEfSigFugDsLLSdv LCiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778702523; x=1779307323; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8ImgcLtFrpGQ9AHbrbrcH9nkVCHOcjM95JO8KGUOdcI=; b=C9gO6fhfD7ntgucWATltcKc0BWRsfPRMRmg20G76+Lre7l/ndcToW8SGGyTeFsJSHc 5NYrdIbouEFDqpY/aJwIBKE2Supe6m2nqdFZen7IhAKP/FROpdGIGsjK75lrVA4UhYEF TssxgI2eVLYR3jOzco+OBqW3PJEt3J6jQjqFJSX09KSrKsuT7yramNehJysWeE7fV4zq 9wrFmVpLo2lQyojyyMOmciBtkkZtDbN6VXz0A/J4o0HkfC79k5WtvwIQuyBy0AwfbIa+ A8DCnBukDNaCeaPLX/+Ogd1fJK2bCNUE5rj2tQEIWCWZDpep31NqxkHs+1DF65j9zQ6D nnGg== X-Forwarded-Encrypted: i=1; AFNElJ8Z0zChDKu6Rm2jNxnfkxmu90YIs37hnf7ryWmdlqChnlv5vTwVj0dUQ1cPNgQ/WWzN0VIQTP6vPyaWQlE=@vger.kernel.org X-Gm-Message-State: AOJu0YyhG/RSHuktr5bNUZCJGUsiDjjuCOkDXrg2x0EWz4nn6ifigNe+ hOtHr1bbT+Or1mHw5dT7CV9JpMFJXXIuvs0bUAPHj+0I7iaPrKZNbh+o X-Gm-Gg: Acq92OHrAAWLfDNWPDvxvSrtp6mhwrprZXz8i4TPO5wQepZSjdqh3kVT46Q+mLOG5x3 Fy3IwUXZoeRwwNbKz83WPscOT6w7PJZa7buQTUsnuNBBqNzuizdayXaGz11cSxnQBDhmNbO+bqU jaAr5cmD00qO+1FCEh2XU1E4QkaoQ4GmUSzFvRfVna4CmKlBrtNCj0lkgxnZ0x4PtkzO9rTXQPX 5VL9hP9RHnz06KIyGYfi+DrCmp8J+bMMydxWbwd0E74U2JpNlLaA+9zNzVIvcr/0O+kAwHKRWNN BAOZrhYPq4j9rnn0folMYGX+gKUq82kspnnWxli+LrzitCfQR/KHrHO2Psosj6FRMF7liOJbLjV ex0/opFrQWIessSUjiZSaiN05qa+6NShsddnL/vVfjmmHfzKoggcW/O3FoASGTg2af3q2jrJHc2 rr+ALinOjxDeChO78av03HWe/W8gkuN93vCyo6LLQxJhYY0hJLFb9wsHSdMWKt3vXVDXy1xPfLC mY= X-Received: by 2002:a05:7022:910:b0:12d:b6cb:bdc9 with SMTP id a92af1059eb24-1342ee3a35cmr3000459c88.9.1778702522527; Wed, 13 May 2026 13:02:02 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:e25b:b38f:c027:f0cb]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-134cc33a618sm666176c88.12.2026.05.13.13.02.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2026 13:02:01 -0700 (PDT) Date: Wed, 13 May 2026 13:01:58 -0700 From: Dmitry Torokhov To: Rik van Riel Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH] input/evdev: move kill_fasync() outside buffer_lock to fix SOFTIRQ deadlock Message-ID: References: <20260513115000.77ec5975@fangorn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260513115000.77ec5975@fangorn> Hi Rik, On Wed, May 13, 2026 at 11:50:00AM -0400, Rik van Riel wrote: > buffer_lock is a SOFTIRQ-safe spinlock. kill_fasync() acquires fa_lock > (SOFTIRQ-unsafe), creating a potential SOFTIRQ-safe->SOFTIRQ-unsafe lock > ordering violation that lockdep flags as a deadlock. > > Fix by moving the kill_fasync() call to evdev_pass_values() after > buffer_lock is released, alongside the existing wake_up_interruptible_poll(). > > The wakeup condition check is the same in __pass_event() and > evdev_pass_values() Does this really fix anything? This code is running holding input->event_lock with IRQs off... Thanks. -- Dmitry