From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5123A3D75AB for ; Thu, 14 May 2026 07:56:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778745403; cv=none; b=ilUrb2f7JPXV04pOaTtMHxWrZLJcMyOa99YKSlw/wRnQwuzWjDraxngaB7VR2ZLAWnrmekzfm+oWyn+D5bBviRHpvL3/NbNL3q5B9IU6xatsxVqa8S+e8mIDd3IqPxtSUD4jpBmndyqLRaJ7XJWHNhy+4bdjaXxtrpg2XJ7O8gY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778745403; c=relaxed/simple; bh=xjfUa96Gp9n6xM59kjbJ5jDYc9smjkpMcgXLwOE7meg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DhJJbREH/DTofZ34OenZ0BTR50FUtCHwLuV6UW1iq5lEjUwiHXEwBAmtDqd/PqvWlRS0sZ7hQVAHj/IH3aRIiN5HyOWBFcZilRih8bGElKwrS8MUrx8OgKQEutD62Oe+v2pgK8W7YkXv4sXwRl9K+N/hfVxspX5MXp4WDvmiX4M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=x/Erx4Nf; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=TtIDAUXw; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=tMaeTE1G; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=9xp7FAK6; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="x/Erx4Nf"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="TtIDAUXw"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="tMaeTE1G"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="9xp7FAK6" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 99FA567268; Thu, 14 May 2026 07:56:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1778745400; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HwFSQfDMERUWUOQUggcVf3A37PosV5rvk/rTsK4+J9I=; b=x/Erx4NfTcSQmE++lS/rrpLvevnL6hKmyXFkXCGeayIxwLjHWwwX2McagtqjNTb3YugtO2 fDDD+dVjx2/ZpzqBrh70SWeCTtC+cCVZ08KCDTXS8sSUo35IDRInjmppj4F350fopUsA2+ sW11erwwMBSpZZ1PeXkJhV0EqvWLWVY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1778745400; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HwFSQfDMERUWUOQUggcVf3A37PosV5rvk/rTsK4+J9I=; b=TtIDAUXwuhJFQ9RVUdwnnLdHZh9f/tX90eoRTZvjOqadw2+Gq6IiVFVUdvggEFdrpWmr39 ixkaEFSsLj4Ab6BA== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1778745399; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HwFSQfDMERUWUOQUggcVf3A37PosV5rvk/rTsK4+J9I=; b=tMaeTE1G2wmNettriYEUN+3VtxUt46taiJjVvnpojK7t+/I7V6l0gW9OSFna2xPovLgLK+ KR/EBBqeUuOFO83iCGMHF/ExytlvZe5KFI8h6tPOpL/R7pLLXF6TTCZa05auq3MCTYPZM7 woSqnKntB0IyZbX47+1TvXQblkuZYu8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1778745399; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HwFSQfDMERUWUOQUggcVf3A37PosV5rvk/rTsK4+J9I=; b=9xp7FAK6lpGh4FznFoaMpPoctBt32DI1ci1gPtYSNBvJW83BIbcC1xrAO86EVk+nh5MVFj 8nx4wdp4/toVdrDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8D562593A9; Thu, 14 May 2026 07:56:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id DDAPHzaABWqICgAAD6G6ig (envelope-from ); Thu, 14 May 2026 07:56:38 +0000 Date: Thu, 14 May 2026 09:56:37 +0200 From: Oscar Salvador To: Muchun Song Cc: Andrew Morton , David Hildenbrand , Muchun Song , Michael Ellerman , Madhavan Srinivasan , Lorenzo Stoakes , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Nicholas Piggin , Christophe Leroy , Ackerley Tng , Frank van der Linden , aneesh.kumar@linux.ibm.com, joao.m.martins@oracle.com, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 02/69] mm/hugetlb_vmemmap: Fix __hugetlb_vmemmap_optimize_folios() Message-ID: References: <20260513130542.35604-1-songmuchun@bytedance.com> <20260513130542.35604-3-songmuchun@bytedance.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260513130542.35604-3-songmuchun@bytedance.com> X-Spam-Level: X-Spamd-Result: default: False [-8.30 / 50.00]; REPLY(-4.00)[]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWELVE(0.00)[21]; MISSING_XM_UA(0.00)[]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[linux-foundation.org,kernel.org,linux.dev,ellerman.id.au,linux.ibm.com,oracle.com,google.com,suse.com,gmail.com,kvack.org,lists.ozlabs.org,vger.kernel.org]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:email,bytedance.com:email] X-Spam-Flag: NO X-Spam-Score: -8.30 On Wed, May 13, 2026 at 09:04:30PM +0800, Muchun Song wrote: > __hugetlb_vmemmap_optimize_folios() uses incorrect arguments when handling > bootmem HugeTLB folios. > > The section number passed to register_page_bootmem_memmap() is derived from > the vmemmap virtual address of folio->page instead of the folio PFN, so the > bootmem memmap metadata can be registered against the wrong section. The > helper is also given HUGETLB_VMEMMAP_RESERVE_SIZE even though it expects a > page count, not a size in bytes. In addition, the write-protect range is > based on pages_per_huge_page(h), which does not cover the full HugeTLB > vmemmap area and can leave part of the shared tail vmemmap mapping writable. > > Fix the section lookup to use folio_pfn(folio), use > HUGETLB_VMEMMAP_RESERVE_PAGES when registering the reserved memmap pages, and > use hugetlb_vmemmap_size(h) for the write-protect range. > > Fixes: 752fe17af693 ("mm/hugetlb: add pre-HVO framework") > Signed-off-by: Muchun Song Acked-by: Oscar Salvador did you observe any Ooops or malfunctioning or was just code reviewing? -- Oscar Salvador SUSE Labs