From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8908B18872A; Thu, 14 May 2026 08:10:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778746254; cv=none; b=RNtQdFcq+Qs5i7M2BWNPnA769CrV8U5bv7W4M+3AGRRkkhDsbeil3W3eB2Qop2XYieo5TAL3t1vyby78wv+PA4uRQXdBWJaghsU4cdk3VHFKKj00l09xXeruR9xt0Q+KC7CLWqnp6G3iPJRdXUkMLz7yaxls9xI5SsQ8v/iQWIg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778746254; c=relaxed/simple; bh=excU94TPAflMzDlEA+ZzmjzNe8/hTfQW8RfitdCkX9c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=d6opWDSY24Y3fLPdElJPbm3da50TMeIwohIqHPxp7LTmCDTX5AsvkeIIslBjValH7vZIDCqnasCJSTSsdZ0vsQFO5ziQW5QggxoedUP1rcd3jnoJnoiZ3q9kP7OLPo8NdUCvGUqECond62A14B+B8nab8JkOY65raE8iHy6nNdA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=cFwnWLGM; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="cFwnWLGM" Received: from ideasonboard.com (net-93-65-100-155.cust.vodafonedsl.it [93.65.100.155]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D9A688E0; Thu, 14 May 2026 10:10:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1778746243; bh=excU94TPAflMzDlEA+ZzmjzNe8/hTfQW8RfitdCkX9c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cFwnWLGMiuPPY/FvhNYZXM+E5qRtpAm3w0f7lbUSSQQVqhSWVH9CEwephqeRQsTJA flP6o2kgYVU4v0hBoQCOLmgmd/CSQUXFd9qddHriIKvqUty7X6uKbkuuEhE+pDEG+g rmvzoe3059NI5HkDqRv5TkCK4ChRfiXiMD5ZOoc8= Date: Thu, 14 May 2026 10:10:48 +0200 From: Jacopo Mondi To: Kieran Bingham Cc: Sakari Ailus , Steve Longerbeam , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/11] media: i2c: ov5640: Remove unsupported bayer orders Message-ID: References: <20260501-ov5640_cleanup-v1-0-0869a7802a33@ideasonboard.com> <20260501-ov5640_cleanup-v1-5-0869a7802a33@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260501-ov5640_cleanup-v1-5-0869a7802a33@ideasonboard.com> Hi Kieran On Fri, May 01, 2026 at 04:39:07PM +0100, Kieran Bingham wrote: > The OV5640 only outputs SBGGR8. Remove the incorrectly advertised > alternatives which allow a misconfigured pipeline to be established. Do you have any idea why the datasheet mentions all the RGGB permutations as valid outputs ? > > Signed-off-by: Kieran Bingham > --- > drivers/media/i2c/ov5640.c | 21 --------------------- > 1 file changed, 21 deletions(-) > > diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c > index 244c341d0e77..e1e253730206 100644 > --- a/drivers/media/i2c/ov5640.c > +++ b/drivers/media/i2c/ov5640.c > @@ -309,27 +309,6 @@ static const struct ov5640_pixfmt ov5640_csi2_formats[] = { > .bpp = 8, > .ctrl00 = 0x00, > .mux = OV5640_FMT_MUX_RAW_DPC, > - }, { > - /* Raw bayer, GBGB... / RGRG... */ > - .code = MEDIA_BUS_FMT_SGBRG8_1X8, > - .colorspace = V4L2_COLORSPACE_SRGB, > - .bpp = 8, > - .ctrl00 = 0x01, > - .mux = OV5640_FMT_MUX_RAW_DPC, > - }, { > - /* Raw bayer, GRGR... / BGBG... */ > - .code = MEDIA_BUS_FMT_SGRBG8_1X8, > - .colorspace = V4L2_COLORSPACE_SRGB, > - .bpp = 8, > - .ctrl00 = 0x02, > - .mux = OV5640_FMT_MUX_RAW_DPC, > - }, { > - /* Raw bayer, RGRG... / GBGB... */ > - .code = MEDIA_BUS_FMT_SRGGB8_1X8, > - .colorspace = V4L2_COLORSPACE_SRGB, > - .bpp = 8, > - .ctrl00 = 0x03, > - .mux = OV5640_FMT_MUX_RAW_DPC, > }, Seems like you've missed the same entries in the ov5640_dvp_formats[] table. > { /* sentinel */ } > }; > > -- > 2.52.0 > >