From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4C0134753C for ; Thu, 14 May 2026 08:19:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778746749; cv=none; b=QLxes212k067KsH2ujKulu4d0sFjadm/97zdS1MdzMcyHAqQwJnvwWxzbq361htCOdh9vwxk5Zrd772LzNC1fYuABUHYyrbCgQgRO2ALrAOLZGpjA1WUCtWze8hf10BHrXJAC+/s/Le02+02dL5/pteNTnBrnXRCi/OFFwVkXHU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778746749; c=relaxed/simple; bh=cLqaHLLY6a5+Col5c3+/CdpNR/brgziPfNFXYDyZQNo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZJQWlIpulnRgw680bc/znlwnZGbDf4Y2urzr9CmdqgiW7xLcBUfNYQ5gvxQ2qxJ5I6UUSOrZ8an5sXcakeR5glhTsYb/0gx2Z9GIpZkaC4BZKyNnrTInwGnokqVLA0dw9oDIgEXKeXvhr4XBSQpQO/ea+gNWVODeG5PyHxvrmd0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Pr+Z7ALC; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Pr+Z7ALC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778746747; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DhmNTYqHMw1g7FKdYGDDVqDLp/5lEDFCOTrrEv198Cg=; b=Pr+Z7ALCokHErzf74B3/74HNVc4oCQEdnnx3koPGXwzja+aWHXiMqrFW93Bf+6HL0fMI0C mcsV6i1J2bQk6pUMzc/3AupR/8Upvbr5YgyVNAsYZ5J3AQ/o2t6qrsFqSATn0hM68HeOOF 7d0sStlC9mUzXYelpRtHnkB+2aq6Kyk= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-235-MlI0O7JFMgSvix3aGhcO3g-1; Thu, 14 May 2026 04:19:02 -0400 X-MC-Unique: MlI0O7JFMgSvix3aGhcO3g-1 X-Mimecast-MFC-AGG-ID: MlI0O7JFMgSvix3aGhcO3g_1778746741 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1322118002DD; Thu, 14 May 2026 08:19:01 +0000 (UTC) Received: from fedora (unknown [10.44.48.223]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 55CF11800762; Thu, 14 May 2026 08:18:56 +0000 (UTC) Received: by fedora (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Thu, 14 May 2026 10:19:00 +0200 (CEST) Date: Thu, 14 May 2026 10:18:55 +0200 From: Oleg Nesterov To: Andrew Morton Cc: Andy Lutomirski , Kees Cook , Kusaram Devineni , Peter Zijlstra , Thomas Gleixner , Will Drewry , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] signal: change force_sig_info_to_task() to call __send_signal_locked() Message-ID: References: <20260513165237.b7a2cad23da85997609f31b0@linux-foundation.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260513165237.b7a2cad23da85997609f31b0@linux-foundation.org> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 On 05/13, Andrew Morton wrote: > > On Sat, 2 May 2026 16:13:12 +0200 Oleg Nesterov wrote: > > > force_sig_info_to_task() calls send_signal_locked() but this is pointless; > > info is always valid and has_si_pid_and_uid(info) should never be true. > > Forced signals do not carry si_pid/si_uid, not to mention that info.si_pid > > overlaps with .si_addr/si_call_addr/etc. > > Thanks. AI review said things: > https://sashiko.dev/#/patchset/afYGeHSWkLzXDlvC@redhat.com Yes, yes, thanks. I have already replied, https://lore.kernel.org/all/afhmbCryeyIz0E3V@redhat.com/ Sashiko is right. Again!!! This needs another version. Oleg.