From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E6E838C40B for ; Thu, 14 May 2026 08:36:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778747808; cv=none; b=m5gy7yeUw8aTXOFCZhuVom9W9djBygoAWQmP1gZBw2gcQzJYn3j/CcrB0BHZiJjCPzHsFcynmnEnUUec3ySwXbvonl5e7VVKE8HwbLp/BtWZZJVoukqiEnM+NrgWnwyKusMGQ4PfVcC95B/il2CT+MkFPs47rWW7a7TIw3SmwnQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778747808; c=relaxed/simple; bh=LZjFSiJMAk133oX14n4qPnTedQkFhR+lVpMPoTUdv1c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=K9SZef303xkj576yboG2WuNSXsyHvpgdv/hiN0VODb2+sg7hMC52gfaxBCZKl9f3UjZxKQAzUzNhsD5YzudZqoMr2Q5jYDcraKF5fK2A/wfhAANmU0V2c4d0i+zYaIxrIFzW2udPVGwHucnnKTN3iQNhzt5WROtBF1d/rxIFvpQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qWZAer/s; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qWZAer/s" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-43eb05b1875so4567448f8f.3 for ; Thu, 14 May 2026 01:36:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778747806; x=1779352606; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/SqpIK99SX2LQxq4P1qr8bITnns1XnWYW1P90iMrai0=; b=qWZAer/slBa8nVAUcTouO45TaZrceVijuKkY4F+XAhMxrQ+a3E11v++xCtsFvKUwA3 8qgy1FSjIGmlbLL4hsnB6vmAOILeYGh3eNYkmAST6IN50YMobcoTIO6/Evrv6cKTBEk3 7KgRoHDg7Uil2Q1U848aAL/GFr7zAc3hho9/PVVkRwtYRnZ0+VJSTIC5KMPCY/7P7e1A h03JzkIpKOD0iySGBsQzRyz1zWxBjJYF63bym6EFNd2LBmGRbTj81+mPNzcjHPxXBmu3 GoehkgyjJhz4g3q0Tq19mSkbndmbXKpQD7vpGcdkwAEVasbcx0UsUrp3cYFiYg/51GQW qZoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778747806; x=1779352606; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/SqpIK99SX2LQxq4P1qr8bITnns1XnWYW1P90iMrai0=; b=QNKIweuQ/SZ+f5b7EOncOZdnEeGazUt56iuFh1WLSWKjkYjtG/dK7B6t8hZnCJboGP bETFlUpXOkpzFuLimVNKA3IJiYknoWf/GWF+g/slwEWHVx6BSb0/630ehqxpwSL7XSDk rVljsNDNsGTfFBd/P1p9UAJlBdliexhmgoLhbUQ/e5dKcrKhT2JMHLuptynrn4z9iN52 8RQwfWIUfv3kSmOv2pU3UJ/vBQx07jL+Pv5QeCP99J+qplUcalVcksjsv7HOia5g6I7S rEWl5rpf1ef7XBN005q2M14ip3/hVPg6Ud06uyLFRf4jj0kJKexSbJusZs/jzaQu73x4 YcMw== X-Forwarded-Encrypted: i=1; AFNElJ+R1AJgWa60qodZ4h/yvUvtIv3fwzqJWSXwmWVly82Md3rBftuc+4f5dMeGx5VgWz2654wBBNLX3a4kwHc=@vger.kernel.org X-Gm-Message-State: AOJu0YwPkL+30oaqTOC3cLGj+Ptlu3WzdnMfwsvCPWzr+L+m73UAfl7m HaXyxvf5nxQRh2klgW4N+PYDQ6VshmurTlRWGTNdtqTIo69hk+YqiCET X-Gm-Gg: Acq92OEmmcLy+hDvsHVn1Yl0C0V7giPOHBguz0IS1V0t0hduFbvdG6lsWjye66cOL4I mKLzJHIM/rzSfl0Rpx+Nash4Wn//bCUaUGpf3SZgCFS89Yu+Na5YPRxtVod2QcYkMjGaB5ob3GO JhxEv3e2lpjHzDEzodxmDTbE/qC+jg9W6NeXt9jvbBHoToG1tfTM6lXDqZJ1IZHEdxAYGzRo1Wa zoMQRYsd84JKOhRHuz3u79/BhuGUaCDw/Kd9SlhSPoX9MwVqQTo4LeBzDHXsQuszblb1S9Lyqdh SoCaMOzm+aajwMHIQh/DwhUx+Mrhb5wRPcuOo8pIXCvgtCbgIZY0qJNXG0/XfJK2HmOu578R5y1 DbUzQCgTjku8uTdZE25aaPlBx7cC4wgLd7/uGifCSzxgJTgg2/FZlE+804XSHV9VSNhuY4y+TFj PGgPkrC5kqPv4nGZHfTq8= X-Received: by 2002:a05:6000:2486:b0:439:c299:4d8f with SMTP id ffacd0b85a97d-45c57bf958emr11214469f8f.17.1778747805454; Thu, 14 May 2026 01:36:45 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da0a17a22sm5145202f8f.22.2026.05.14.01.36.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 01:36:44 -0700 (PDT) Date: Thu, 14 May 2026 11:36:41 +0300 From: Dan Carpenter To: Chhabilal Dangal Cc: Sudip Mukherjee , Teddy Wang , Greg Kroah-Hartman , linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: sm750fb: add missing FBINFO_STATE_RUNNING checks in copyarea and imageblit Message-ID: References: <20260514080318.39332-1-yogeshdangal66@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260514080318.39332-1-yogeshdangal66@gmail.com> On Thu, May 14, 2026 at 01:48:18PM +0545, Chhabilal Dangal wrote: > lynxfb_ops_fillrect() correctly checks info->state before accessing the hardware 2D accelerator, returning early if the framebuffer is not in FBINFO_STATE_RUNNING state. However, lynxfb_ops_copyarea() and lynxfb_ops_imageblit() omit this guard despite using the same hardware accelerator through identical code paths. > > Without this check, the 2D engine could be accessed while the device is suspended (state set to FBINFO_STATE_SUSPENDED via fb_set_suspend()), potentially causing bus errors or system hangs. > > Add the missing state checks to both functions, matching the existing pattern in lynxfb_ops_fillrect(). > > Signed-off-by: Chhabilal Dangal > --- 1) Run your patches though checkpatch. 2) Add a fixes tag. 3) Put a note in the commit message that you are using AI and have not tested your patch. Smatch says that the state is always FBINFO_STATE_RUNNING so this patch is unnecessary but I haven't looked at the code. Please check again and resend if Smatch is wrong. regards, dan carpenter