From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E75533DD514 for ; Thu, 14 May 2026 08:58:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778749124; cv=none; b=JU+nuwrtMq8il/Yj0tbGCbTsgWCZ3DjC96a/31iHzFGepAxGN/tk4PpIC6tjFLLFThvv6RcZ3WAPUl5gyepKcfzKqG341M8BxhmsHMEcw3zmMxBRxiFFIMT9OWjlEeK9hv+mfc2GIuLRmRfYXXSv+nVH6JqtKEYXhH1Jp/zRUn8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778749124; c=relaxed/simple; bh=09CoTliJM0nyVjP3hQHtDfOxZrT+Op/MGS31EN2IbG8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CPofZmoJJhm2Wj9992XtlgOshbQOa/nl/rKJfmZ9PpvTCQ7opUFfmDl/voeC4EyNh6FO3MoFFdxYTxTtA9trQ/NdnOuNdtCzE9jTwdc0GLiqgpZeaiDlzVE0PAJV7v+V2KKfqLZKRCKyb+x6Mtu6VvPBRgh+cY3YGjKvcc46ARU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Mr95YaSx; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Mr95YaSx" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4893940bb5eso48061685e9.3 for ; Thu, 14 May 2026 01:58:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778749121; x=1779353921; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=t3qt/7vR/Iml6VkS9noPU/Zo5QB0R48kOuliLAld6I0=; b=Mr95YaSx4ETSvs/EAOue+ezxFNvAy2ag73+5QMCnoafLO9N6cl4RCAEwr13Glfj1Z3 CJxCyoW6KbP/Vfpbx4wMkd4tqokJN7QV5BSHC1JPzDMwnwzHApHMn32OvBWQ2+I0x8E5 TA8hcgorM+MGokS1fP1vLboDP5dSnLIGySW4ntsXjWDK2p+cxukRreai8OBrGxFVJ2+q /YGuuo6jiYJe0+Vzqhwn3Yatrv6gTge1H10tmbfcmkC+PX1J3bSD+K9B1FsWiwMXULw+ Tx9hrJ1BCRFxATFwuNan/dEakpwM8bu9WyIK4fyvvkiiSc3EUa/mI/7BYwaWnW39jAYh 9PZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778749121; x=1779353921; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t3qt/7vR/Iml6VkS9noPU/Zo5QB0R48kOuliLAld6I0=; b=gAl2LSKsyyZQzaf1Ay93U8fobdfAr58NRfLZl45RUK8KJJq7ij25MAPv64SbUz2Mgj WgBCVDdxlm1i7QWnrbTQUnv9Z1EV0oKPNhuK9QAnARbV+qTrBLthdEDU+DB+eTxdqXKj GhJjjDbaYBIbFT/ReEVwyoeCT75PopnwkjX/kkYiXSRUTKqM+4InWznqFNk0KQWupnZo gjZ3D2TVpN+NwZa2EmNDtaOK9GWYBPSBoArPR5InECcf4/0A5CEwmNyeEyrUTFAGzsbP mI81PAuvN9+zxyIa584QBAFhWq+CxERm3fy+f8TdbrIpnehdYu4vVWx7Wtpc0iNbIhqG mqrQ== X-Forwarded-Encrypted: i=1; AFNElJ+glTyag6vXWVUzCqHkZ+Yhkne4oZARjtd5Z6YV4Nj1L24RMyIUCTqxT0Vxd41+8P4Y4qTQydcEyCO/DWc=@vger.kernel.org X-Gm-Message-State: AOJu0YwrlU5WR6OtL+kcRIoN192BIYn5zd0qy/ycJB9zmxVfkzfJEAg/ tZRw4JZ7XGp8t0WIZlSP/nIPu2MpAWCHe7WKOEvtighIZ/Itiz/fFuYNjskNYA== X-Gm-Gg: Acq92OHNiXYuz6PA4BHfDeK/30YPJfFnTlFsr1yDWgZoTLzrrxH8KT45vMaycHrNnZc Og6vaxCPDVW63ooNMo/yrbVfYjgNjmRqprfz0lvz1nrj3K8Y+jc7cS2AKVMFDuuaGbxsfU0JjUg B9cSjidI2qjmKM9TUTgfbBTwf0N6NRLulKElHLvcjJOJY6Udt2rRPDoNMHuXMtoryl4dC9Tl9Uw HETmaiekpRhEnsHnkyfdUkEIoJ9uiUKV+Cv9iwoiUdvXnE232GqCO72AfG9ahnOlPXGrJ4/v259 7eKswoRjmWY4v+Y/sx3FVBSSXUv8SPQwkdz4Stlpu+mwXwnG4LQC9RfbuEL6h3mJRT/Fg/W2w7E q1DvsQexXhK8VAXO1LPT1O6fXQ6zCceMrw8/oOVQ9p/zrzMz1OeUMBr8FH24mewIka7lD4KSgRH r2ho6DHAVE1ZggsXEg/CDW4HJBCUZJrw== X-Received: by 2002:a05:600c:4c23:b0:48f:dedb:bd8b with SMTP id 5b1f17b1804b1-48fdedbbeb5mr7442475e9.18.1778749121354; Thu, 14 May 2026 01:58:41 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fd648a7e5sm50841925e9.3.2026.05.14.01.58.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 01:58:40 -0700 (PDT) Date: Thu, 14 May 2026 11:58:37 +0300 From: Dan Carpenter To: Hungyu Lin Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] staging: rtl8723bs: propagate errno through hal xmit path Message-ID: References: <20260514060323.24895-1-dennylin0707@gmail.com> <20260514060323.24895-6-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260514060323.24895-6-dennylin0707@gmail.com> On Thu, May 14, 2026 at 06:03:23AM +0000, Hungyu Lin wrote: > Propagate errno values from rtl8723bs_hal_xmitframe_enqueue() > through rtw_hal_xmitframe_enqueue() by returning the error code > directly. > > Also update rtw_hal_xmit() to explicitly map the boolean return > value of rtl8723bs_hal_xmit() to _SUCCESS/_FAIL, clarifying > the return semantics at the HAL boundary. > > Signed-off-by: Hungyu Lin I was onboard with this patchset up to this point. The "Also update" part legit confused me when I was reading the patch. I don't see how that's related. The second thing which confused me was that I was expecting the patch to update the callers of rtw_hal_xmitframe_enqueue(). It turns out that none of the caller check for errors. This can be fine in networking, in an xmit error case we pretend that we succeeded and that the network ate our packets. Very normal. However, when I'm reading the patch I want a comment to say, "None of the callers of rtw_hal_xmitframe_enqueue() check for errors so they don't need to be updated and this has no effect on runtime." regards, dan carpenter