From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f41.google.com (mail-oo1-f41.google.com [209.85.161.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6CCA3A05FC for ; Thu, 14 May 2026 09:37:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778751422; cv=none; b=GsmOhhrcwVibs5T7cFWxawHEBIybpW8tavjakRIZlOy2tqBgYE977Gl6E53GPCX+VG6xTza8tjX5p6RnOQZTl9KtkLn4XPKN+OKFzSUDuxlOmQ3IktlhMKXHvExPVHDNosOPpHUOTN4WZQgziSN3bj0lE7gbA0t+JogTjt1Lmg8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778751422; c=relaxed/simple; bh=XN1Y08zg1c/vHFKW689QAWB9RSwo74yJvQL3yg9ve8c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SDMuN4zCD3l+a2EJp4EHMsRWLGlc7dBgnWbHWiOrm6/FlehzJnu80nDKB6JG5OJaIIYH1W7+wktaeioG8PXFRfmzgsgqZMgqem209eJ4pvgqr7dlPxmysX4E5z8BWw39yqJnZ2+rmO2bwsc48IrNafUFHpcL9SzSCsLlzPxNq+U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=B+xjFHgo; arc=none smtp.client-ip=209.85.161.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B+xjFHgo" Received: by mail-oo1-f41.google.com with SMTP id 006d021491bc7-69b905c10ddso140116eaf.1 for ; Thu, 14 May 2026 02:37:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778751420; x=1779356220; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2DerFgBz6k83Qq7dtP6zw622SF3fHdfZj6SqqTvLKeU=; b=B+xjFHgo7JjIl8InvDeW5HV4u7RHpuG2EaJ0vcaCjtZzXtOjV5WJc4ikugvH73c+tN 9LN9m955o4G267Pnu79OJSQJ6p1q/CDqA/n3kmcM4Ec0BdQhGoRQjhdkK44mjWHO1uDp fJOQ8hgVXNbTnwXdTekkKZ0pnC/jnNzgQpW/Q8q3gtfJgv5OS2IKTvOKprnRQwNtohRi JW5NIFKxGT6B7L5Q5/6oAUCVCx+EpayyduHOu6CgwwolQCQvlAkWxSbLgv2yLgbHwsHK DlfZhYW0N4nWEjBdWJI8kCol+Q8bYn7xbm2+W4Wbd1DPaTH8v1DPYgrKvvtgzVO4TY0y iS+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778751420; x=1779356220; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2DerFgBz6k83Qq7dtP6zw622SF3fHdfZj6SqqTvLKeU=; b=IcEnnb38/T0ulfEJkNpnTAnNiVPy2SOc1Ip1ZsjseJWHyDFDR6H3AqhSsLF4j2OOxV ro4RsCqIFUyua/NFei0vySd4V6H3HVAi7456WCpUYt3voL3iw1BiVhQalrycHYE9eAhi +ZBBuxqN64l8mWd/gPjt7DltJ5Vy9vdT++DNEUlOD4O1iA9WufXhP3S/1l59h3llrGFF IdIdn0eAvjxY5Y3NuX/+rxT8+zRaYDg6qSuPitbr7G/oKQ7YhMSWAeohuPmwqavInRXA 3zVDzlfe2TVlo6zDFrHaEX+ymCsBDbsMzDbuq5Vg5upPX7cLlkUlocTcqmS8I3k6dXer myxQ== X-Forwarded-Encrypted: i=1; AFNElJ/bHDcO2gJc75ANNHmX62o1LJfFbJZhgwAeKt5+OT0SfQ91FCi/9w8KhYsnetBPPuNwmO8LcjfK5GqGCwY=@vger.kernel.org X-Gm-Message-State: AOJu0YxbfLHk7UxBGjDgo0C0PGFpwAyNR21IgdkFjcodT4dO5s5ystRF N2Z4+B2KwFgSAhYiYdPEmhHJWozOsEZ5Lp4kSBWhXMn5SW6LfDR+9sCT X-Gm-Gg: Acq92OENlnEcZgqJQY5TeRoxoJdIidMBZPEiWsLXlPPDcuY/ZRX4wshecqZ7TNJycGM UlvhTwtkNzgZhwnCUlQKEJMrwvV1Gkg5fz+RW+7M921HICIkum4ZuOtgZEwhz8zIDEQ0ACFvf3X qto6YAmKayX2OXuJt3A40MqeSSHuNYRpUsVxjZXObDMHi8y3Mn7ycyKgi2CRDipvWcPiF4Q5ZyN zY6hGfi5R36CIxuql9TflLpZ64mXFhuRvtC/Kx25oMwNFfencniojNS8IwxQPP5f8wSmNuvjeo4 pNg86hEDfppmUkte5AlGGBJHuj94gU5X5BZhuWEq/MFz51QxpeMVAcchWrKwnIKawgqxflTwY0S cYvWTZL8DkJbmS1seP71K8400m8JYO3yojszWlmyi2zKU13Mjv2W8YTMClVO2uBCmNTBzeRA7RK ifp75MEeZn+DUoB0mgII/IBlSB9OWdKuHfBTK68lRr9GX6Rwd9Gl6eA2FOrIC4KmnSBnK1WCvLu YbRYqKqC5KIdNw19zjj3jBxyOhlO1c+Q1RTkZI5gQ== X-Received: by 2002:a05:6820:4d06:b0:694:9f32:11 with SMTP id 006d021491bc7-69b7a9dd215mr3248558eaf.5.1778751420483; Thu, 14 May 2026 02:37:00 -0700 (PDT) Received: from fedora ([172.245.82.59]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-69b8ca9a856sm910974eaf.9.2026.05.14.02.36.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 02:36:59 -0700 (PDT) Date: Thu, 14 May 2026 17:36:55 +0800 From: Ming Lei To: Caleb Sander Mateos Cc: Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7.2 2/2] ublk: optimize ublk_rq_has_data() Message-ID: References: <20260513211846.1956810-1-csander@purestorage.com> <20260513211846.1956810-3-csander@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260513211846.1956810-3-csander@purestorage.com> On Wed, May 13, 2026 at 03:18:46PM -0600, Caleb Sander Mateos wrote: > ublk_rq_has_data() currently uses bio_has_data(), which involves 2 > indirections and several branches. Use blk_rq_has_data() instead to save > an indirection and NULL check. > > Signed-off-by: Caleb Sander Mateos Reviewed-by: Ming Lei Thanks, Ming