From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A602A3976A7 for ; Thu, 14 May 2026 10:12:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778753567; cv=none; b=ivdL4SANWHFG7Dw+xxlDHXiGgHi/+2cfBiryajpAjU2QSc4FI5d+/qJ9fKpJd8vYmg/migqLhefFbuTNouyuW08v9PaEsmqhnuTedJovdepzSUtoodHjht9miTbyOmFX7yqWKwRhhoE3A4I4DCdZBhjaxcfdo8oOKbRWUOgTty0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778753567; c=relaxed/simple; bh=pfbw+RBzRHc2kunDFtITjU+w+fGcve7D5Lz0mX9TkvU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XFzqbdSO3O/f+H3k2azABkxPj6A3sZbllsRjAoCfYRGV5Sqn1rAK74fWM7tIpdkNL+MpqNLfQPKW8E8vl+WNVO+v58Be0lSgSqMTNj3SKSE8hmwgCIWEW5S1q+CSkyuZeRIMKUULJ1b3lhJHE/wxoWxdYUQKH1MQ6UhkdctVOjc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HdeNTHX5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HdeNTHX5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5CD7CC2BCB8; Thu, 14 May 2026 10:12:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778753567; bh=pfbw+RBzRHc2kunDFtITjU+w+fGcve7D5Lz0mX9TkvU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HdeNTHX5M9fbJ9SUhbD2/sqXFQ55yI21JqGuVHCv5lZSIBDq+rqnDB2khZ8WIUi7W 69AlVMLKN9B4MdZqa+9dlXoLhBsU7GIH6Hj//G66IbQS6I35zHWBtVSImuCoccBTyf PVOVDOeT2F5PS+OS45GI4EVFSLVBTUIGgOI9yuqftfYVm9dahz8TVQP/mEjfXqFxRV 4cAXMuUHCEQdPjWNy/MIm6C8v5UCcos9BgfgRqW8OF2narIys3+r0wEoqT95+uAJdg 6AI6USubWkFfFlGEBDN+vr4l3vSJZ7HOkKcg128AfUPZXLsdCrKD7gmfFRQmZf71H8 7U1Cw78WZDYvQ== Date: Thu, 14 May 2026 13:12:41 +0300 From: Mike Rapoport To: priyanshukumarpu@gmail.com Cc: akpm@linux-foundation.org, changyuanl@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] tools/testing/memblock: fix stale NUMA reservation tests Message-ID: References: <20260413091458.774770-1-priyanshukumarpu@gmail.com> <20260415122731.1768912-1-priyanshukumarpu@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260415122731.1768912-1-priyanshukumarpu@gmail.com> On Wed, Apr 15, 2026 at 12:27:31PM +0000, priyanshukumarpu@gmail.com wrote: > From: Priyanshu Kumar > > memblock allocations now reserve memory with MEMBLOCK_RSRV_KERN and, > on NUMA configurations, record the requested node on the reserved > region. Several memblock simulator NUMA tests still expected merges > that only worked before those reservation semantics changed, so the > suite aborted even though the allocator behavior was correct. > > Update the NUMA merge expectations in the memblock_alloc_try_nid() > and memblock_alloc_exact_nid_raw() tests to match the current reserved > region metadata rules. For cases that should still merge, create the > pre-existing reservation with matching nid and MEMBLOCK_RSRV_KERN > metadata. Also strengthen the memblock_alloc_node() coverage by > checking the newly created reserved region directly instead of > re-reading the source memory node descriptor. > > Finally, drop the stale README/TODO notes that still claimed > memblock_alloc_node() could not be tested. > > The memblock simulator passes again with NUMA enabled after these > updates. > > Signed-off-by: Priyanshu Kumar > --- > tools/testing/memblock/README | 5 +---- > tools/testing/memblock/TODO | 4 ++-- > .../memblock/tests/alloc_exact_nid_api.c | 6 +++--- > tools/testing/memblock/tests/alloc_nid_api.c | 21 +++++++++++++------ > 4 files changed, 21 insertions(+), 15 deletions(-) I applied this while dropping the changes to alloc_node_on_correct_nid test. -- Sincerely yours, Mike.