From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E04FC3FA5D0 for ; Thu, 14 May 2026 13:54:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778766884; cv=none; b=e6LkNc/z39aNtwLR0wHjU/TwonPNym4vQSvORWVShwq6Aky5y8E55CANm8ygBKUMzKnXXWL3HA2vx4Z09U6tsDDLMYT5mqMJzTlj4DVypNtuOFL91iSKT5hCT/rKkPbP5CPjp2JkLXFU7CawzE0qkuxKIQ1iF+io8u/czIT6evE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778766884; c=relaxed/simple; bh=D00ilq+euMFH6w/lJjs5RWESbbOAzr8/PYOgGDIN55I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LHEQsqbl1ZD5zV4l7rkTm6QrZgDTIkb4lPJVZmQZ0ex2deV2frleQWregS+qelJM6zMO6YLJRNfLwL78sO1UyZQwmI+7hleaxIpiEvv3Lv4+I/R5go9VF6iu+5mdskHpk4gpq5VhzV5ap/0ESXahtLqa0w2XuZoTKf39OzbIRNA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=aG02zfyW; arc=none smtp.client-ip=209.85.160.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="aG02zfyW" Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-5165195c8b0so2350971cf.0 for ; Thu, 14 May 2026 06:54:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1778766880; x=1779371680; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sc+w8y4pA95T78hoAVZ6GrlC/xHuPVJr/YU1joizSQ0=; b=aG02zfyW8CLYsxFuBQuwH/kSaYx1pbZELYOji4LQxpQqg8B8b3aMlaQ2yQ3H5QkhWI e/51zvqWODNCxAD+PUd37MVop9X0EJxdK/OaT6jHXtpofDgTqwT2UKbrJi77XB73U7Ei M1MjhvLT74/A0gwQmKpFfh74fJtdFCp82ZngXh8iJZeSpwu9/M0+VgtDGLjHj9QwmoFX XLOPDguY2oov+2Go9iOEmniOrOid9lRoJ2vDZ8SqLvWXlo02CaACNnCA0u3f36Iqi04f h4E7Tt0vNWxSXHSmia7udCiSRxkmM60izrMmbpEs/qBOANxCEORBxStT2hdcY611MAhC Fxbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778766880; x=1779371680; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sc+w8y4pA95T78hoAVZ6GrlC/xHuPVJr/YU1joizSQ0=; b=UbihMZtngigh20j9Xl2DD15J7PsOTrTpS8skfxWPQd9spgnpWTuOzOWWsimNDNuznJ WgmQcsegDA3PRPbP07i+MWGuR8tPWYskxwtm/v4eZPrCg8ttM3KsmjwT2SdjLBFj/jtb GBjKvOIXtLxrTm+aLBAWGF9FHn0DLrJLazsU2Tu9IJpkmtpdUVGIB01avvTmXfkmurQc IZLgdU7eXXawhAG3QSJ8R8M8o9EyLnjWNAfE3FbljrTt4wWQ66C2oFx2qbU6H6nJyQOI dk3X/QauVJe+atytw0FJdsvQLDF2G+L8QITfukTzpde42th/QWn2Db4fVbFOOYJjJhQo TabQ== X-Gm-Message-State: AOJu0YxVKqk8ZOFg8yNp+WSbHFa1UUsL2ESMPJKqy6aPZoQ/pr92xIVb J56Bn6GQ0XEQsoLjueYo2wMcmofBiDnUU4eoGvnw7NRIKp4xnk2oVvG/mcwkqM14kF4= X-Gm-Gg: Acq92OH64HshRtb00O1kMZJ43qWiSxZkB7EZSiXkMpaIDcDpIZ4t0zNmAbkYPUT5Sj0 s4ezsZWZ194qEWRJ3o3ryKQuJ/gO4h4OnFmSiusBqUsCoQcgta1QjWxa8EjRFPxkHGY8Bf+w44W OfwZunRrMSpgE8BKGveIjOKGnLSazD6hijM3XV5XjCDtdDvtbiuWW9Q2Dj0NbRs0Be9GMSuuRU8 VxfqgbEyMfYl9C3XhuiAiuHjwhR3b+i/xul04iTuPm3TNDcuQBfi2CNnXq58ixieyU3i/eHgCu9 s+Ns7TI5W4SEaAX3X2QdkdqUDxH39Vi7fCXCpyjmvZWBtfKdnBd1+RN1YllBpodU+1rwYQ1xJ2t cVlDQHpXNvW7w9N2ITZyCMoUPeBCMC5F/IxoPvUttcyl2TQs1EyQtRo3qWYSAK2eeSIHu3aA50K i+KGHWxzpsYXMR3awPv5jNC2e1f8TANRE/I6c3PnR7YDniVz+GpohHqYzyqkfhBc5+RwhITRy8I HQC/5rUq4qeZ9YnHzgsMVU= X-Received: by 2002:ac8:5fc6:0:b0:510:dc4:942d with SMTP id d75a77b69052e-5162f5e3f73mr100495801cf.46.1778766879208; Thu, 14 May 2026 06:54:39 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-100-36-248-188.washdc.fios.verizon.net. [100.36.248.188]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8c90bb80ed0sm23810396d6.35.2026.05.14.06.54.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 06:54:38 -0700 (PDT) Date: Thu, 14 May 2026 09:54:36 -0400 From: Gregory Price To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, "David Hildenbrand (Arm)" , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Muchun Song , Oscar Salvador , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Hugh Dickins , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Ying Huang , Alistair Popple , Christoph Lameter , David Rientjes , Roman Gushchin , Harry Yoo , Axel Rasmussen , Yuanchu Xie , Wei Xu , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , virtualization@lists.linux.dev, linux-mm@kvack.org, Andrea Arcangeli Subject: Re: [PATCH v7 13/31] mm: alloc_swap_folio: pass raw fault address to vma_alloc_folio Message-ID: References: <66119d3bab318d74c1586b99dd70fb74e2da1ec0.1778616612.git.mst@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <66119d3bab318d74c1586b99dd70fb74e2da1ec0.1778616612.git.mst@redhat.com> On Tue, May 12, 2026 at 05:06:16PM -0400, Michael S. Tsirkin wrote: > Same change as the previous patch but for alloc_swap_folio: > pass vmf->address directly instead of ALIGN_DOWN(vmf->address, ...). > Rather than reference other patches, just explain the contents of this patch. otherwise... > Signed-off-by: Michael S. Tsirkin > Assisted-by: Claude:claude-opus-4-6 > Assisted-by: cursor-agent:GPT-5.4-xhigh Reviewed-by: Gregory Price > --- > mm/memory.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/memory.c b/mm/memory.c > index 0824441a6ba1..74523bc00d8a 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -4734,8 +4734,7 @@ static struct folio *alloc_swap_folio(struct vm_fault *vmf) > /* Try allocating the highest of the remaining orders. */ > gfp = vma_thp_gfp_mask(vma); > while (orders) { > - addr = ALIGN_DOWN(vmf->address, PAGE_SIZE << order); > - folio = vma_alloc_folio(gfp, order, vma, addr); > + folio = vma_alloc_folio(gfp, order, vma, vmf->address); > if (folio) { > if (!mem_cgroup_swapin_charge_folio(folio, vma->vm_mm, > gfp, entry)) > -- > MST >