From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50A433C1403 for ; Thu, 14 May 2026 13:55:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778766922; cv=none; b=dSsspDfWmMRYE7wUJMtaAVRXaWBIUEElW1jXG3Ibt5uO50qhhTFv+8WpIun7PgfO1vj5V18oMA5GOaRoowPuSMcuvWo6B22MyLFhV5BAk1nxLEzjQbJFrpiARLHF98xyL57iWE826trHx07QWZTTfHw2A72Oz4pRgxKPmMf/vM8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778766922; c=relaxed/simple; bh=NvNTTK7oVqMi+Oc1tLQ8KX1F49PSOBt3JtRnBB5mvFc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KeREta5XuWffnt+KAbXBS7cQDCPoVg+X7enxkrF4JnRCHSp0OfjVRSsU8IJQXOIjVskCgI12iFs9gU/W5ylKRWFNOkil5uNyBmC0o/y6pbAivRKm6i+bC6iztCuzhbq50d+DazhBCxElSKVAxI6AFrGTNSKKKWYN4O7cbu/IXwU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=Wkv7bf9W; arc=none smtp.client-ip=209.85.222.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="Wkv7bf9W" Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-8cbc593a67aso711743985a.2 for ; Thu, 14 May 2026 06:55:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1778766920; x=1779371720; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gqYGPZxgNRcYPxPA7WQ/pm4xhwUDd+98HNryuL77oaw=; b=Wkv7bf9WO4HLs6LgYKNpv1vMxltfZYvtiVSZ0cb22E7dBS+Vb3bwmL/aTSP4aFLW5Q wmZzfFgleAWmewqbdXUTzV8DlylBIv4RJRLPSTiYIYUMJTWk/yOfWDFI0W9fC+wydhji aoPOL76r3HTJEu3jSDuqe8N0zLja9yQuYoC1vCNl09uwQnBBhm7+oaZiFSATxXhHZYb8 CAufze4bDkpO6Pi5KguntvFyralFE7VYu2lIHslBeDyIAuDq4TCtT7V/GvkPkbibHrTl SygFPJAv5I94V2QNGdTfc8t8LwsMyePsPCnHKa/Miup0dAgcZD+OP5yRWBgNi/bNAzQV +f1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778766920; x=1779371720; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gqYGPZxgNRcYPxPA7WQ/pm4xhwUDd+98HNryuL77oaw=; b=YtbJLFsAryz3Xtw9m8ORuY2uremL+JnhperAAGJYAMpGwkZkVS49uS9EJDOMTT8l49 Aip4I3fuM9oBbCudAIXD8Z+td1Je0VS6LgSQGKw7Xb3yD5ufddLljYQX2r44SOmClePY RuKlYTWjfr6RKzO7DtXw83QhJoAMKIXvsLLguD7JgCwx/wuIdgSPfUUkMLHYMBv+qrYa 9n6pwxJYRIz0iVPpbbIMIb+7waG/7NwehnflkomhwCSi2Xq4xdUpmrgGREyAboIx5zSS xIvc0besDzV3wRLDNz1a41Vwobi2e7D9akjnZalo/sCWZsrKEdtt6HEhBa0RTwsI/BEn ttIw== X-Gm-Message-State: AOJu0YyfUrreWaFy8GM180XhgryGDSKBTOuoP+w4uWGof2c3wzA59Asw kWKb36TvXDAYiB8biQbVZ17BL3jkGXsMBAXVRY6L2GjHB3+ajfvmNtz8BwuytrIXltE= X-Gm-Gg: Acq92OEA98EL47QK0kn7HMYUrGS89dJKmBlYkOkiH4yH1ynoOhyx1dNb6EtWbVDJJtV 8t2O08VlSWxdCLCVBP6pyF6nmwiJTQYYQQxI5VMZJ0G0iW5vnFfp8GE7HkwsK7dnr/5Y4cmUHlX vfLUuRie9Xy5YqqhkDnikbCBLCnr8iKWdybU3juK02NPPFJi0PM7cXmhg9tGSUsiSDPJW14YzKj oMp8j9fss0v9Uhaw/h8aQoGW8QXuwPkNNZZAROklGaS1GGuMwN0ptZ5z4PYgTbAOt1fWSAmUJKF 6fa/vhn/zgLhlm2AXsfX96Ss57D347n/1BiDvex5fpA8vYnJDhzV31m21tvzhyIAPGLqjfGV9tU OBeRZKCBnBzHj0mktrlx6vZ2v+oMFZpyetnCMmgoZbGVsas9w5r3vNbaS5cDByz8ffpx5fNx9OR oqzceU97ijoHMxhxyQK+ucEA2mE5KGKjBM2VZrIDoZQl9VUBZvB2SiBhrmbSjm2PGrHjcVi/LtN fHPDktHBD1s X-Received: by 2002:a05:620a:2a0c:b0:8cd:9033:1724 with SMTP id af79cd13be357-90f880ffccemr1218244185a.9.1778766920104; Thu, 14 May 2026 06:55:20 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-100-36-248-188.washdc.fios.verizon.net. [100.36.248.188]) by smtp.gmail.com with ESMTPSA id af79cd13be357-910c0ec392bsm238411385a.41.2026.05.14.06.55.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 06:55:19 -0700 (PDT) Date: Thu, 14 May 2026 09:55:17 -0400 From: Gregory Price To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, "David Hildenbrand (Arm)" , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Muchun Song , Oscar Salvador , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Hugh Dickins , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Ying Huang , Alistair Popple , Christoph Lameter , David Rientjes , Roman Gushchin , Harry Yoo , Axel Rasmussen , Yuanchu Xie , Wei Xu , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , virtualization@lists.linux.dev, linux-mm@kvack.org, Andrea Arcangeli Subject: Re: [PATCH v7 15/31] mm: vma_alloc_anon_folio_pmd: pass raw fault address to vma_alloc_folio Message-ID: References: <411a7b6a750c1904b99be92fad0e678ad791ca82.1778616612.git.mst@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <411a7b6a750c1904b99be92fad0e678ad791ca82.1778616612.git.mst@redhat.com> On Tue, May 12, 2026 at 05:06:27PM -0400, Michael S. Tsirkin wrote: > Now that vma_alloc_folio aligns the address internally, drop the > redundant HPAGE_PMD_MASK alignment at the callsite. > > Signed-off-by: Michael S. Tsirkin Reviewed-by: Gregory Price > --- > mm/huge_memory.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 970e077019b7..d689e6491ddb 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -1337,7 +1337,7 @@ static struct folio *vma_alloc_anon_folio_pmd(struct vm_area_struct *vma, > const int order = HPAGE_PMD_ORDER; > struct folio *folio; > > - folio = vma_alloc_folio(gfp, order, vma, addr & HPAGE_PMD_MASK); > + folio = vma_alloc_folio(gfp, order, vma, addr); > > if (unlikely(!folio)) { > count_vm_event(THP_FAULT_FALLBACK); > -- > MST >