From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta1.formilux.org (mta1.formilux.org [51.159.59.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1739F425CD7 for ; Thu, 14 May 2026 15:32:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=51.159.59.229 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778772756; cv=none; b=Irt/gZ0XIxu6yD2hkNLGZ417iNpotU83Grh/kToJGsySXEB/QR3BWNydH96FJuCfXkJ6NCuZ3kiX+Myw4aTBo2TgbYGT+qeWp04mwZvWOoT0zJiSpeloqwWJaeLppZp29Gn7YbZflzp8LXVL7jx4AJ8ZqZKT92JJ71iRcIzPqP0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778772756; c=relaxed/simple; bh=UOmc132MLYD56cDCmj7UT0N/pkyv8EdvuksSJIeXp6E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NMFnlCb3Nnr/ZCvDOZfwmxG5Kox5nJmtBSooBMy/o83sfFY451d/iZXamcvY1rQOnEqzUyvCrndNRQ7Oo8cxRwQVo9BH7A0WaJglQ8tcRFNvPVWJz9P4x+t8bunruATLLVYl42d6/ecTuIjJe604uOLDsu/2up6cxkOrbfFyUnA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=1wt.eu; spf=pass smtp.mailfrom=1wt.eu; dkim=pass (1024-bit key) header.d=1wt.eu header.i=@1wt.eu header.b=fe1GUu6K; arc=none smtp.client-ip=51.159.59.229 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=1wt.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=1wt.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=1wt.eu header.i=@1wt.eu header.b="fe1GUu6K" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1wt.eu; s=mail; t=1778772752; bh=uISIBZqDxFhQaPt8l2C0vIXAu7dBGy7F+SRoVatNqr8=; h=From:Message-ID:From; b=fe1GUu6KYvSUBuJHGSMJsMvpWrQ02r4oAodwl6rfKwCVrq+EM8H8/wQ0R2Cf+hkGi aBpG3oBt3RXqCUXC66ZrKTTMr8Z3WoD7TtHXQc664G2fj8ve/4U4GO97r7+Hnlctpj ejSDqFlql0/HoaNX+KQaje0Sic2wKKdlZObOeJGo= Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by mta1.formilux.org (Postfix) with ESMTP id 08EAAC0BA5; Thu, 14 May 2026 17:32:32 +0200 (CEST) Date: Thu, 14 May 2026 17:32:31 +0200 From: Willy Tarreau To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/4] tools/nolibc: always pass mode to open syscall Message-ID: References: <20260514-nolibc-open-tmpfile-v2-0-b4c6c5efa266@weissschuh.net> <20260514-nolibc-open-tmpfile-v2-3-b4c6c5efa266@weissschuh.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260514-nolibc-open-tmpfile-v2-3-b4c6c5efa266@weissschuh.net> Hi Thomas, On Thu, May 14, 2026 at 02:05:13PM +0200, Thomas Weißschuh wrote: > When O_TMPFILE is set, the open mode needs to be passed to the kernel as > per the documentation. Currently this is not done. > Instead of checking for O_TMPFILE explicitly and making the conditionals > more complex, just always pass the mode to the kernel. If no value was > passed the mode will be garbage, but the kernel will ignore it anyways. > > Fixes: a7604ba149e7 ("tools/nolibc/sys: make open() take a vararg on the 3rd argument") > Suggested-by: Willy Tarreau > Link: https://lore.kernel.org/lkml/afRfjdovT6pNtwtP@1wt.eu/ > Signed-off-by: Thomas Weißschuh Looks good, thank you for making this one move forward! Acked-by: Willy Tarreau Willy