From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65714384CD0 for ; Thu, 14 May 2026 15:41:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778773310; cv=none; b=j+foJ+pkEpjrO3DBzBDe4jlvdGf4T8lZ/CnNZEL3mLpIgcyeR2x7FQzOpuK/X3pDOJGK2ZQ/R2or0RduqysGs8TcToAFO9RtiXCJjH9pFDmUugmH1+May8t9wrh8FKVzNGOPMNYM69n0l0prd/09AbMvmxnhtM14SFSyHrvNG3o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778773310; c=relaxed/simple; bh=4rEOZ0HrD7dJ7NzHVHtoO3V+5JqJ9tvjNPtsAXMQwRE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=usk3HBerjvAhtfwBsYOyRm1tFGA3g8AFsaDnaCxj2ka47HRQgB2bj79mGWKlpF/bgxFQTaiQ1PuJfGb1gpeul9qs560AN2LzDmZDxxStzkmYS5VYB+rWak/aNAGOsRre55kdbd2olaxjl3MYBy+bzkAz9BK5xMSHyMiwiarNXZQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=QnLw+7f/; arc=none smtp.client-ip=209.85.222.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="QnLw+7f/" Received: by mail-qk1-f181.google.com with SMTP id af79cd13be357-9118b952e2bso17600985a.0 for ; Thu, 14 May 2026 08:41:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1778773308; x=1779378108; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hgKCwvl8qCOC7UfBkBLgKxl3JgTAzl9p+k26wMt8Rf4=; b=QnLw+7f/zpjSn6F9+l4ao+vleBgrnSCqtWQg16ZnOy4vsJ7x/RDP3dtLDE6kFrQto6 P0GLdPOLE2pXHGJGF0D5z7qNkKuz2wl0aMKl/E1p/KBRv/oFDABVjbppPUyRa2eD2DmN Upp35TDCxrkiUNavBvY/utqZe64S6jnofWaomc1wfb9DqYxkATQkRut3ZhWsBttEQKnK CPIAIOAFXcodwE1qD/CFTwkBsWv7PWpT2/nCYidoeC6gPhQwxkPPvJMVRnFNe1dGWfeM 8Fqd3moHwQozpYie4N5kB8/QojJM3w8+IHOf5IAAmO7aiXW0EJVIFVPwlLjELPZnoo++ 6g3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778773308; x=1779378108; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hgKCwvl8qCOC7UfBkBLgKxl3JgTAzl9p+k26wMt8Rf4=; b=NKgez3Syiw87SdNVHJyJR9I8ggsjbnjRs9f4gkQ+5RMHk7t+GMSvpbj8lMlSNif54o hEy2PLEdQSsaTRlVM2Y7JY9D1i6MuzOVkZZwENM9IUt40iy/AEvdxFnLqdATKrdI09+R WK/hqp3zgpFTlqpYTymOCu3i+CIXYFuygxCHdpp8QRp2kXl9/MSrQlvPERhJq+8U1fgY 3+XjmUaHSQlChRibl3kQbjTyr24zR/jdUic15p3RzrjRm76oSyNWsDVCiYCUxg2kX+nB R2NLqb0hI/vQshSz2zUH1dZmXJonqxRms6GwmrM8B9i9knJwGVsj7ixQFI4FKAYohnyS bURw== X-Gm-Message-State: AOJu0Ywa2Hlbq3EbR5vHKE1LQRPTpzO2l/mxpqpeIgb5mysdtp1cKd8w YzFhIcX20K1TRevdh3rtYsplUjb2BQ+tE15ixfVa0HqDbfZy8GY9j6mIlB3ZqkMhfbovEbJtoX2 MfNlN X-Gm-Gg: Acq92OENkc/b/seqxIOkrT0UrhabbR/tYi/emno6DHgs0CmPTUX5VX+xzrLk/i1c7Y5 FHkZkCA/ny93+fPM0hArcsPJo2ntvX3hCfffaYfCq6woTIn8j1r3tlk60I6bBh3UcJbvLCIdOae u8w1v/1L8eNkI4dtMGa6C2bw9GjGVhdwjCA2ye/6drlbsuqu9eCNY/1fO8L5fy+PpCb6H0j96wM 4X2MUQwoZow+M3Pya17cofda8VgfnpztkLgC8vp2t8irqsHiOZqF0JXtyv2D8ULr1ABBTz3r7ZV EaBffjtVBXwS/phMr3fQiMjrTywk4r3zGJl12pMpvtvNOxFUFma/6gVA3jnY8BxTmEDJ9EIfoMP 5OlB9THYng5MQuEQXUKJ2n5nMNVjCQdaZ+eIYJoPd2QmrklI+z10BtoTrtD2qU1GLEAhaSUamsK +NJNEuS7dyL4BNAgBbHS7CQlDRDaCHk4ETyeXeNgQ8XpJjFvm1G+egD4ly8V+jWFmV13qUFu2dQ uvdixVBApXd X-Received: by 2002:a05:620a:6cc1:b0:910:d1cf:915f with SMTP id af79cd13be357-911cb72a697mr20518585a.9.1778773308288; Thu, 14 May 2026 08:41:48 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-100-36-248-188.washdc.fios.verizon.net. [100.36.248.188]) by smtp.gmail.com with ESMTPSA id af79cd13be357-910bd02f12dsm279596485a.40.2026.05.14.08.41.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 08:41:47 -0700 (PDT) Date: Thu, 14 May 2026 11:41:45 -0400 From: Gregory Price To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, "David Hildenbrand (Arm)" , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Muchun Song , Oscar Salvador , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Hugh Dickins , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Ying Huang , Alistair Popple , Christoph Lameter , David Rientjes , Roman Gushchin , Harry Yoo , Axel Rasmussen , Yuanchu Xie , Wei Xu , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , virtualization@lists.linux.dev, linux-mm@kvack.org, Andrea Arcangeli Subject: Re: [PATCH v7 02/31] mm: page_alloc: propagate PageReported flag across buddy splits Message-ID: References: <20260514104735-mutt-send-email-mst@kernel.org> <20260514113337-mutt-send-email-mst@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260514113337-mutt-send-email-mst@kernel.org> On Thu, May 14, 2026 at 11:34:14AM -0400, Michael S. Tsirkin wrote: > On Thu, May 14, 2026 at 11:32:26AM -0400, Gregory Price wrote: > > > > > > > > Maybe mildly out of scope but worth asking: Are there other flags that > > > > should be retained/propogated on a split? If so, rather than pass > > > > was_reported, should we just take a temporary copy of the page flags and > > > > pass them all in? > > > > > > > > ~Gregory > > > > > > > > > Not that I can see, no. > > > > > > > You do this exact thing again later :] > > > > https://lore.kernel.org/linux-mm/9a22e0f9bbe1278913754db6df76e291a006181a.1778616612.git.mst@redhat.com/ > > > > ~Gregory > > I mean yes, reported and zeroed) Just zeroed does not exist at this > stage in the series. > More of a forward looking question: if we already know we're adding was_reported and was_zeroed, maybe we should just pass the page flags through entirely and let expand() check them instead of passing it through individually. We end up doing something similar with post_alloc_hook later as well, so I'm wondering if there's a general improvement that can be made here. ~Gregory