From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CY3PR05CU001.outbound.protection.outlook.com (mail-westcentralusazon11013001.outbound.protection.outlook.com [40.93.201.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02E5C24DCF6 for ; Thu, 14 May 2026 17:18:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.201.1 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778779140; cv=fail; b=NyYBoXy3CH1SRvWMHmC6/Ot0UuzwLhUiPUgyhTGcIK/IIhGryauSl6826rp+VFlHLsODh/2pMBQC464bAT1bs93jGOkDhN4eqmb/wGu7s/gZrnLU5iV3kjGAwTSi2h6tXml/Q7DDyOt9Rn+5wcZT6rjBixpUhQxXwR91QGTpVSI= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778779140; c=relaxed/simple; bh=TiFUKE39PtPmWSu+FFR4LzyXoMSK7oQVVB58gGUuRW8=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=PyXSrPjiP3aIXmUrCoCnix3vTo9FndQadEGXPTwVaAwjfCZPI8F53BtO+dPGZomfUtEewwGgPlB/TbGQJlZr+z1WdSVugzBaidbw9YQ7onDPyvDsRN00s3j3/zSW4ej/uVjrAHEZT4O96Nn9l6z+QLe8nuiQtiqTdzYyeGefEpw= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=oGQMqxn0; arc=fail smtp.client-ip=40.93.201.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="oGQMqxn0" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EJ1XaMz1ayMxlAB0ya/WLKBzR0+1zPYp+/NBxcJDk0LdPWDzP0cft486rCycVG34kpVIuqEpxJ5A6VuRyNmUJJl4BCCHCqDVUYrW9Fx/y6tb292BL4Qs79jzvIwpuUrLMd9hZDI34Je7vk1exGnoMRI0TZgrzBgXhoguFvg/j9WmBxXVQs96wWVxCvkUVN9mzjXWgBhIJUTOKde79bgQGZX2oeq0OVTXoCt6jT31V8JKvtVCgY4YL6ilmiH5nReDORyUmHMydcNj3VO8YzuatpOx/aT0Qo5Fc2O5m7tvO8qJQeG/W/y3/vITgaYR/UZqzl2RAG5O5af8wH/9dnuw4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8IJbtXAoimo7l1/m/usGUpHfLdM1Rd5nn4nn8ebGDXU=; b=HBam+WBw/na54A/lY3HFYUu+jCF5CU8FU7QZrpgxe/+7nizmYao4yFlIUGiyb0iBJso8gQi6hiR334lmZhKki8QAXsPPkTBAmgpPLWbeuX7Bc80kgULlqFYQVpDroVR8IZV32nh+oElTfkVUiJwBHkkCpxsGQtFl/pwJ6QWzvFr1Nl379wl59GegMZYouH1dgIsjiIvZizBdzGcwF/EdiUvOHS+iwlqFv3Ix30jpG1VOJWyEYWB5HLoN5sCyYSu7I2lPeqK1pUH6MoqkLTnYtbjPD6iW6PiaYhDR0bW/OSOWSSQw7hRN2lc1s66jppWlGvDGp+Nd2AcZ5mufCzuoaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8IJbtXAoimo7l1/m/usGUpHfLdM1Rd5nn4nn8ebGDXU=; b=oGQMqxn0BNoxE/kVhopBJH5+DDSQdRpQyoxB55VgIAvSaEd38LFsUBG5B38ZW4pv2Q5PEARqU/jSWGxnIG3San680iuC3lqtZSUVBhjb0PX/yFoSqocJofjJeYRiUM7vRvf9VXKkQdoWszx/PEVwyJ4tNMYeUjleW1zqv25K7En0I51e3uIYreqgxpuwSMRAg/kxoEW0evQArWqfBliEJvzFs4uCYsFwmlKruOl+GGUs4eEh72ojIyEfV5/KMHIodfnu05z9Oep/oA+5iM6SDU4SRkemUMOSv8fWLRbrUWW+EiDmYErcn0pzLAWNEV/Z1o1nh0jojuV8GMIuUHM7NA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CY8PR12MB8300.namprd12.prod.outlook.com (2603:10b6:930:7d::16) by CH3PR12MB7713.namprd12.prod.outlook.com (2603:10b6:610:14d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9913.11; Thu, 14 May 2026 17:18:44 +0000 Received: from CY8PR12MB8300.namprd12.prod.outlook.com ([fe80::ce75:8187:3ac3:c5de]) by CY8PR12MB8300.namprd12.prod.outlook.com ([fe80::ce75:8187:3ac3:c5de%3]) with mapi id 15.20.9913.009; Thu, 14 May 2026 17:18:44 +0000 Date: Thu, 14 May 2026 13:18:40 -0400 From: Yury Norov To: Yi Sun Cc: yury.norov@gmail.com, mnazarewicz@gmail.com, akpm@linux-foundation.org, mina86@mina86.com, akinobu.mita@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] lib: bitmap: reduce the number of goto again in bitmap_find_next_zero_area_off() Message-ID: References: <20260514090607.231387-1-yi.sun@unisoc.com> <20260514090607.231387-3-yi.sun@unisoc.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260514090607.231387-3-yi.sun@unisoc.com> X-ClientProxiedBy: BY5PR17CA0014.namprd17.prod.outlook.com (2603:10b6:a03:1b8::27) To CY8PR12MB8300.namprd12.prod.outlook.com (2603:10b6:930:7d::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY8PR12MB8300:EE_|CH3PR12MB7713:EE_ X-MS-Office365-Filtering-Correlation-Id: 16da8e0f-4350-40cc-5b77-08deb1dcd9ca X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|1800799024|366016|376014|22082099003|18002099003|56012099003|11063799003|4143699003; X-Microsoft-Antispam-Message-Info: LTaNg90P1RJUDjCqjK2nsyGAoEmG8hXPBTsipVU58jEOgJCghTFOotlyKcLGFXkO9VdNd7+lOlB3H1Wog4u65BJGn2xAox7jt7dTm0wxTeCqdlI3ZOTTKb+LRjkwPWXShauTDcvzF4Kc7lgzhTHaek3IrYf96nYC5tx0goaMfLoZmtSk6C8OBZE+ttSV1tCAb3M+B5OO0+4jWNYV59nnyc374Uut6bhSmY0/1e25S5gQFiWi8SGcIgzPsFu+qQMQa6seCDtRXp4YNZ/Ww/BwMrwdVDHThGrQ965qvf+BChfk8EITMgFVLIEikpOWWHvmuneG8T5Oy0xnSh3RFnlRujsZSAAvT125+KQM8bowpi5EdBQXAeEieN1b4t3egCSczU3C8AyTir9kaettzkKqQ5Kefn3IoiYB/W2H5VENxSLfD5TTOnz+RG2rOfapbEuh+Jia9T/zG0t8KjH5YNbzD7mF3YoJ1cs8YEck1ieBV9YYG6C+QEKsRdGQvOiBCdutjIq3m1l4Atk3BvmrZ24sNFzjvY9glpl1F53CwFYRPq4lFhLyB24ubCqgL07B2j9oobceT7TB2YVCmUrPEXmWjtdqnvbI8vQne1aoZ/bSEbYmRrcTe5qyc345pbWqp2bnqlKzOisyCNwCOVujhmEU3DNhe79OlA+ve1PRYj+Ys8Ri5UXjtn6mADKif4S3X8sC X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY8PR12MB8300.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(1800799024)(366016)(376014)(22082099003)(18002099003)(56012099003)(11063799003)(4143699003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3Jt9QHO1VlHIeaPA6I0wVAN+8xPncTVZNEZFXt69XnCDWTGLYqrQ0wSEFhap?= =?us-ascii?Q?K3AbPP7FtLiVdSApAuo6nP7JF2lJtExL3l0BZqvWN1ru8oprM3EGyRBgRfVS?= =?us-ascii?Q?yc0ZCHMnuV7KWIz2fsPItVtY6nEECE264d2yXP2vvHVatgaF+SzbF2op/krD?= =?us-ascii?Q?CSBnYIiqhUfwMDfrIB9OR/Irl2YliUyhhIS0YYSrgNmDptFvNRSoJlftHlAb?= =?us-ascii?Q?JaTBLgJl99l3tZ5YSipkaqVRITT2jV+YiM8ItXt2JkjMd3OaD4dr/NKrMPF4?= =?us-ascii?Q?E5BNrmXIyitPAQx9jloL9vIbYIrROCRJWUnaYnu74oCfj9Jnh/KPIr0JEnzv?= =?us-ascii?Q?XkDq18W42zaf87MKMkrH0EsCKBDA2XMg7vMWUFEpohqzd7kUXd0g/seHUTOv?= =?us-ascii?Q?qY6yZOgweaAVt2M6wOxjNreaQY8+i7OZTHgFTZno2Xozz62nXyw2jr8nXgN+?= =?us-ascii?Q?7KgTGRWHMGEM+hNQaRiwcltZvav0X2LF/VSvPttYBFRVtaCtWA3/7kb6VnI4?= =?us-ascii?Q?0YVS3KsMOsWjW9u26RADDKtD1ziQxJr+OMFc2Iz5UkARQcH1Zdrgi1T6/2yz?= =?us-ascii?Q?RcQbhso/gFzxb80KDEpl+j+EckyNrNmLbpZXImExI740N7Xin0HmDEZbvSwj?= =?us-ascii?Q?z5alK23OssWS2AnW/tr/+xSf5Z7PsYl/5T4iommSBCS5EaVpIFnSzoSWrbLI?= =?us-ascii?Q?41fmFYZEMOCHOxdZc5K6vjUeYu78uh02nvP4xjipjZQ+AepgDMJO3vf6Zrx+?= =?us-ascii?Q?aK5YYmI383FqEZuflXg518FBijTzMUlXtkfRnYBalItLSW7VJ/FCimBR8GIA?= =?us-ascii?Q?9ilb9igF3XBuLvqusSpjYdP7KyOPg1NnedlCZNDDcC0bbCC3TQ5NUupXMmVx?= =?us-ascii?Q?dbjCi6voywgq8P1mQrI8oFER20kE0qvn5jE5Jn+Cmd+H1d15sE+fSyHDh3Y1?= =?us-ascii?Q?Q4IwqdfR7TH+OYrk3w49r70ZYYmG1ULCEAOyusO5FtDRu4iJDq26m+qPy8Fu?= =?us-ascii?Q?Rextjr4UU2FhphLoX51U9IoX3FxcrJyLpA0AynEUZhpelZUboMjT0sPRQd0g?= =?us-ascii?Q?L8bI6n5mKZCRx5q1A4ctZQQf+X5B5i8Vh2/wi/ZL5m2ocEZefGp++oBbNrTk?= =?us-ascii?Q?KqelD+Iul09j81rNUhe7S8C/btelqOWu3rRYMqBMwHI+e2+cBYsi8DoobGow?= =?us-ascii?Q?UC+d+TPqhtJwSNFdicdwerfh6EgvJvGkRxjHM4vZL9dXTjOBw9I5dnJgOTWp?= =?us-ascii?Q?ifSz3C0AQ0l0SId94in+TK0cWn9TQMo04Jog11s223qoOsYZYTbhdMeapVJu?= =?us-ascii?Q?MjKjgYBT69X+dM6QzRZpgbCd/OuIw9j9cG+iv3XZnTHmRAOYwgS9c1I1FlH9?= =?us-ascii?Q?Ku27+7DSql1t2DCRU/dFzib5ZreknQmVe8Y5jDQQ180+Ccu9tiCyd9/XBpp1?= =?us-ascii?Q?gsD/usRBSq24wsD97EfMDi7Fo2HEPHrq7nBNszWHZ3mXHzkdNcpOtKNJuHHo?= =?us-ascii?Q?dAQlGV91jqtrxI1aUAIivngzjXgK9ZrbpUpWC9IK7wuSAusRdyMNwKQ4jzVd?= =?us-ascii?Q?0E1yUSivbgY9TwaHcufvZlLUYmLXZp27kxeaWSN2nixffOclCGqmFNrz8bS7?= =?us-ascii?Q?H0BJT/1+uXnU6UgSrzjRfgW+K/6K85KEATc3MjjwtnBwWmiCYSk9UTQH0SKn?= =?us-ascii?Q?6R7CdvIZ3IYmWjwJyoC08bbzZVsO0kZ8QSe+5jM58felOKFwEonK8EpxpuXe?= =?us-ascii?Q?OZYTfSZWCIC5M4bcB1J8W3FWuFyLvJdU8WrFQm6T7pvbhUgCn067?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 16da8e0f-4350-40cc-5b77-08deb1dcd9ca X-MS-Exchange-CrossTenant-AuthSource: CY8PR12MB8300.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2026 17:18:43.9785 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7+Z/BPzrFfU7Twwkpp4SqWdXrZ0iKqZI3LSr+s5/sjzUgucoJfMrR20j6fTlHAfaFB+l1LDs6+BvlOBVP3N69w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7713 On Thu, May 14, 2026 at 05:06:07PM +0800, Yi Sun wrote: > Finding a contiguous free region in a highly fragmented > bitmap is not easy and may require many repeated attempts. > Therefore, find_next_bit(map, end, index) is not the optimal choice. > This is because there may be multiple scattered free regions > within the range [index, end) and none of them will meet the length > requirement of @nr. > Instead, it's sufficient to directly find the last bit within > the range [index, end), thus reducing unnecessary "goto again" calls. This is the good place to put your perf numbers. Does it have a real impact, other than the micro-benchmark? > Signed-off-by: Yi Sun There is a for_each_set_bit_range() iterators family. They are similar to the bitmap_find_next_zero_area_off(), and may also benefit from the rework. I think the most questionable part of this work is that you switch a single function to the new API. Can you check the above and other possible candidates please, before we move forward? Thanks, Yury > --- > lib/bitmap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/bitmap.c b/lib/bitmap.c > index b9bfa157e095..9b589643f72a 100644 > --- a/lib/bitmap.c > +++ b/lib/bitmap.c > @@ -442,7 +442,7 @@ unsigned long bitmap_find_next_zero_area_off(unsigned long *map, > end = index + nr; > if (end > size) > return end; > - i = find_next_bit(map, end, index); > + i = find_last_bit_from(map, end, index); > if (i < end) { > start = i + 1; > goto again; > -- > 2.34.1