From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao@kernel.org>
Cc: Wenjie Qi <qwjhust@gmail.com>,
qiwenjie@xiaomi.com, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: fix missing read bio submission on large folio error
Date: Fri, 22 May 2026 04:20:33 +0000 [thread overview]
Message-ID: <ag_ZkRNeMqSf8sSb@google.com> (raw)
In-Reply-To: <39c59d05-c998-456a-afae-1eee7379a04c@kernel.org>
On 05/21, Chao Yu via Linux-f2fs-devel wrote:
> On 5/20/26 17:52, Wenjie Qi wrote:
> > From: Wenjie Qi <qiwenjie@xiaomi.com>
> >
> > f2fs_read_data_large_folio() can keep a read bio across multiple
> > readahead folios. If a later folio hits an error before any of its
> > blocks are added to the bio, folio_in_bio is false and the current error
> > path returns immediately after ending that folio.
> >
> > This can leave the bio accumulated for earlier folios unsubmitted. Those
> > folios then never receive read completion, and readers can wait
> > indefinitely on the locked folios.
> >
> > Route errors through the common out path so any pending bio is submitted
> > before returning. Stop consuming more readahead folios once an error is
> > seen, and only wait on and clear the current folio when it was actually
> > added to the bio.
> >
>
> Cc: stable@kernel.org
>
> > Fixes: a5d8b9d94e18 ("f2fs: fix to unlock folio in f2fs_read_data_large_folio()")
> > Signed-off-by: Wenjie Qi <qiwenjie@xiaomi.com>
>
> Reviewed-by: Chao Yu <chao@kernel.org>
>
> BTW, I can not apply the patch, can you please rebase it to last dev branch?
I applied.
>
> Thanks,
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
prev parent reply other threads:[~2026-05-22 4:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 9:52 [PATCH] f2fs: fix missing read bio submission on large folio error Wenjie Qi
2026-05-21 8:28 ` Chao Yu
2026-05-22 4:20 ` Jaegeuk Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ag_ZkRNeMqSf8sSb@google.com \
--to=jaegeuk@kernel.org \
--cc=chao@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=qiwenjie@xiaomi.com \
--cc=qwjhust@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox