From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A266435975 for ; Fri, 22 May 2026 04:20:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779423636; cv=none; b=QXohHLes+BGdpvYlwb5NWHeYB8RWf5zCuxA3LTYhOoKJ8liWkzM/1UkL2/DhANpDoxIKVyPWxEkX9JASLpNI5F9WQJBizMTSOEnBKcaVNqVan9wM7p3W+cJCf3YnEiSBgjlzW24TYjWNaNrVSCkhpbb/phbFVtTx0EQWMSXBTaU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779423636; c=relaxed/simple; bh=I14NFV5R8J+bWBVrRkZAbLBA2UZs7MCTe5M3zBPEK9w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tlYIziE/nIKnGQiEnmTwOP9OrKshKzvn2aE04BZc48hpaV0rP75T7+gbHKf3Cy4hNR/bHnHuoTnLUWvrJ5jB+SbwOWdFTMlSoeBKtJIBWxvklGSj4995as8hKLV/oxouv55ojcKBKlFUsG69pLlhndl2PvDCF15bXhk8sDtdSWQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dvvB9zuA; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dvvB9zuA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 216531F000E9; Fri, 22 May 2026 04:20:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779423635; bh=AuDebTp9wF0S/Xn282lC6vcJ0n88XySW4ZxE0I84xZc=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=dvvB9zuAFepo3DHpMkWgqI60W2yhMhSg+mzRgM6P7piG79MnWnXXbWceTEI0tWUop AufT/oPAJadaJA7sk2Ta+p66F0bM/gj3OID4REL85XY738izVf+d/RJ3O1XZASEUlb iLJW3ORg4zLDYCqi3su/SJn87hHIQU8Qwb3m5KAY21D45+W+3yZPYkTjnWifpf7OZD 9nznJ2UDG4HnOd+HwNHvk68xlcma439jfJQi8r9UegwSlC/jxmya1rsE5h4Dr6fCpZ SYW2xXSuWX/bMWHBcJEPptwrrABPIFzgn/eO3koct41PLwGxOrhrO5fpHEtaETA0T0 syvx2XA1RNThA== Date: Fri, 22 May 2026 04:20:33 +0000 From: Jaegeuk Kim To: Chao Yu Cc: Wenjie Qi , qiwenjie@xiaomi.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH] f2fs: fix missing read bio submission on large folio error Message-ID: References: <20260520095204.1175117-1-qwjhust@gmail.com> <39c59d05-c998-456a-afae-1eee7379a04c@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <39c59d05-c998-456a-afae-1eee7379a04c@kernel.org> On 05/21, Chao Yu via Linux-f2fs-devel wrote: > On 5/20/26 17:52, Wenjie Qi wrote: > > From: Wenjie Qi > > > > f2fs_read_data_large_folio() can keep a read bio across multiple > > readahead folios. If a later folio hits an error before any of its > > blocks are added to the bio, folio_in_bio is false and the current error > > path returns immediately after ending that folio. > > > > This can leave the bio accumulated for earlier folios unsubmitted. Those > > folios then never receive read completion, and readers can wait > > indefinitely on the locked folios. > > > > Route errors through the common out path so any pending bio is submitted > > before returning. Stop consuming more readahead folios once an error is > > seen, and only wait on and clear the current folio when it was actually > > added to the bio. > > > > Cc: stable@kernel.org > > > Fixes: a5d8b9d94e18 ("f2fs: fix to unlock folio in f2fs_read_data_large_folio()") > > Signed-off-by: Wenjie Qi > > Reviewed-by: Chao Yu > > BTW, I can not apply the patch, can you please rebase it to last dev branch? I applied. > > Thanks, > > > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel