From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from PH7PR06CU001.outbound.protection.outlook.com (mail-westus3azon11010050.outbound.protection.outlook.com [52.101.201.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C9D52FDC30 for ; Fri, 15 May 2026 05:53:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.201.50 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778824412; cv=fail; b=jgQx06DoJJa3ZknVT6P3RZFxevq150B7DkiCl1IbHXyJ8NCCw61BXUYiKLcYHZC56uc4fQMK/s5j7vN23wGPox65QA/I3WGqzPJ4AqOOpgDZ6iSoz6iLLUpg+IpWhsIyhsY2FsTcsV57W0T3x1Wblh9/UvQi+MUSEQrQQoNZ1bQ= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778824412; c=relaxed/simple; bh=Ro1FJQMeBUtxsmDjBIiHMrgpuK9toeRLJce6FOtIvEQ=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=LIhtQYagVXgVYuMgrelqQdLXRJrBpiiNs9HnzWvmrwEsCTah/xkrNo+pAgkrDgJfj8PexDflJGiptf34o/aI6l+AYR0/ijfTZZwgZwUx/7swUmvTSZwSOtdSMo4l1+DH5IOz3rPG/iCyPSb/MNNHHecS5U2bvC0WbXjwIQsSLVI= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=ZBWNs9As; arc=fail smtp.client-ip=52.101.201.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="ZBWNs9As" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hDa+sn6TApuHWwV3PD88Ml64jJFANdVxbSgP8UfEwjsEkWaO4ARnk8ZECkuE2EcrXcqb2mICNq6hmyC8i4WSI3Cd0u4oTjHHDNFfBPTa70fIVmPdVjrXtaChJOZ+h0Nb5+xv5/BDu61Ere6bac7onQf6pf04rSJQXcGaE1kvTZmOxMNom2K/Lbsg8oXhW9QHImJPMvAIEj7GFR1eHmLjDx7kQS6GAaGbUI8jnbOjvcTFQ698k+WWGgViT/lGtvTQT8JpBAibIPpWGqJkoV5rDrguIizqCRihSG/QOr0KjH/jmdoI7NxEhNSJV1xqSOX6y9x2P2dbCjYmzJjzES/o6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vjpWkYhxb+DEFfVJvYG+GQzTfcidF9fWN+TOq/YdmNI=; b=T6xkFIydXdsm71gxqIGrQJRbrzPNzZpew8Piutd8ghSFt8EMP3lbGRlxnDHLPzCyLwTyyq52U/tViJ43Q4BWtzjz4MgCsddEctz0PZ6xi2/v4QClFCO+BPHskdA4+belNyrxZGhFKCyYYVRLCov0X1SoSvwBERJPrMQ3qifUzLTtpJ3+sFoGJheIRtyMJhv+rEWa5Re9N+VjaiFWV+/Rj+caHRqb2mwMRzHPy3ocZb37dRQKtyrimAku2qry+Hm9bLsAGaAOAk+cWn292brh/DoMofdqvzfiLnrhqp2qYjDNXb4VRBbBByMETtXYIT/tSwszrcoTAlBfnkrZdCkJSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vjpWkYhxb+DEFfVJvYG+GQzTfcidF9fWN+TOq/YdmNI=; b=ZBWNs9AszDU9dcSPRjFV23La3clTk3ES9yRDT4G5Gi82EJXd2GcfKx67URQi6tpgnymN7jMrwqoaUFK/9NaEhkROEAiokkoaFw2njL7e6v8VH5Y52Tp7aIS0SmICCvQXzgnJ86t2rBM49Uvcnsei8xn/JY5cuZKarvLSDjxBvg7hMoAIcemaPz0FGMbtzph/JbvM8xwZZftlqY6+dTgqMGLFq0zSO+z0kkg0dKrw0psMPHpfRkxkk/uuXceISH9AfOrDpfj0XXTICgcQivLuMfcX8kVDczwNFCWoEUxsT6aXceepIfspZXhv3v7udDYwi6TuJ4lKIj4mEZWSpoIoQA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB7726.namprd12.prod.outlook.com (2603:10b6:8:130::6) by MW6PR12MB7086.namprd12.prod.outlook.com (2603:10b6:303:238::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.25.18; Fri, 15 May 2026 05:53:27 +0000 Received: from DS0PR12MB7726.namprd12.prod.outlook.com ([fe80::5807:8e24:69b0:f6c0]) by DS0PR12MB7726.namprd12.prod.outlook.com ([fe80::5807:8e24:69b0:f6c0%4]) with mapi id 15.20.9913.009; Fri, 15 May 2026 05:53:27 +0000 Date: Fri, 15 May 2026 15:53:21 +1000 From: Alistair Popple To: liuqiangneo@163.com Cc: jgg@ziepe.ca, leon@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Qiang Liu Subject: Re: [PATCH] lib/test_hmm: fix error path in dmirror_devmem_fault() Message-ID: References: <20260514025328.21175-1-liuqiangneo@163.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260514025328.21175-1-liuqiangneo@163.com> X-ClientProxiedBy: SY5P282CA0031.AUSP282.PROD.OUTLOOK.COM (2603:10c6:10:206::6) To DS0PR12MB7726.namprd12.prod.outlook.com (2603:10b6:8:130::6) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB7726:EE_|MW6PR12MB7086:EE_ X-MS-Office365-Filtering-Correlation-Id: 561f06c9-e38c-4d54-54f3-08deb2464898 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|11063799003|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: RXNL/TUgqQIWsREJGvDBy2GZceac9BOgZIv3eUhQvxJP1h3QM2Uc6UdtxRmEtcjAYjyWL9+vO+mFSXgdDbyRfoPxWmwj3wZy4IBP6ST7mX1tppVQ5XsIDomC9csTBwIGOzW0tlTB492OoCulWDPDtBnY/DtYXb7VLIZMoQx8+8Ej6dAo9mZyHSEFhaTh15AvyCNbMr66w7THBlIbZcgQczOf+uzogN9yks6ytvRYTJOTzGJ/vnmlYMb62LT4WKVOP1QY2GAxOt9OTE5mjoCxvBm7acU+uHGXqO9XZPLsCuMpbXKPES9SUO+risk6iodwKKMtR5Nv6gkDEz0pBtWjxrV28m+ImRCRww9rnWzX/enQ2JBt+rkdnx+SiqiV9PyoVjfYaNox2B53JPGZsw9BfnmbXPmWZzZu9sp6quGItbXbkbGw+dPYbgY2cbqHpKnOFn18W0Ff6V0iZ/RsFxc2F6qUo6oQJqAqjQxxq8E6/R0p2Gw50f3OeRReIyDZdnths21EwVaA5P9FfAiXEZab688NFthuW6YvJLnVUjpDusvvdSLKwFUCiPWaKTimRqqXTbg9CPkt++lmdrtDspKNEbr0XImSQUqGMtrgCoelVU4H2YjuX1+Rtg64G9r+InN8RLoBAFPszFPqW6NbMuOzGcaFXVrCY7KGAyNkbrlYmJ6rhXTL8ppeacpDJOaXroZV X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB7726.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(11063799003)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yTXdW5weQTTQylYFzPDmgkK6ttbG0WIz2HRZsewcxq352XineXEr3fRggQrm?= =?us-ascii?Q?FVDM+3RenUUHoML0CkNXkA8sEXV35Jhld2NPHI/+SQgsuFZxqTMhqc5nGbqj?= =?us-ascii?Q?w9DRtmlaYKzrDzisTH4mcBLiB8sKRIn6Hak8MJURHFA//f0WBWIvWGTdguFl?= =?us-ascii?Q?a1dBFokLWsbqsXFcR+3xn0eRY10iX+lqbJfKFaJm5hDyMC8kB2aQVJN6qnkj?= =?us-ascii?Q?0tIqixAUxa2W+3GNJn637NlXJTEidedAnMpyLpPjZeTsYEaMoQY2YzWjOYjo?= =?us-ascii?Q?s/hiWaGb5kdR//phl6MCmquyQWZIb635jwFeUxFlY1v3ItRMgzySX8ro3ipy?= =?us-ascii?Q?V2JCX9Jce9sj4aTinuo1UBmedfko4e36js8l05wTfkP5WFv+/Rw65bFsyRFb?= =?us-ascii?Q?TZJw+nvLl5LwhKR8lp+hwPz+Jy3nixVzbKsUFW7PBm33sjVpjLgXcnWs05Cb?= =?us-ascii?Q?22AGsmTDXSwGXBMJ8OW7v22lbutfIp0fM/pobt3fcqKF4zabpTY3EN1TbnvK?= =?us-ascii?Q?YELKIqztNpdqaXvO/xQQVxzSsTp+qzlwISK1b3HttvJjesWQGhULG6wLs6G7?= =?us-ascii?Q?V2Tom9lKX+9gwNRwI15fvss6QGjem9/svJypIvvMxWAjT7+3BfTJSxy4tO/s?= =?us-ascii?Q?5/4CddGNscL0JO/QUlH5ZZzcBQi7JOCaOfpwU9VKaXeNI1kl/vdbF7cp9dPz?= =?us-ascii?Q?I73a/6f8k3IeNfBPrDr4qQg9ylcJtZcxSKs0xgoF04aP/aIfe54nleYbpWXE?= =?us-ascii?Q?QlfLioD79Qf6t9GjW3hMj7kSPcG4DPdg1Fe0IXpmjZZr7WxDUsL4AVloUZmn?= =?us-ascii?Q?ls31d1A/Up35/2NU2KkEVHzWTMjrynXfgrUtjnL5LUSWgie6fb5n1A+Bzxqm?= =?us-ascii?Q?OgIgZW9/vHPm//iTPIPRfZZpT4UocNWy1PCZK1e9yIvS0qr/HfwGtJcZda00?= =?us-ascii?Q?tv7I97vc2XVaCi5pOixLIpZU8CtnCN5IPDXVeIkh9FO4C+1prMSEKeztfPd9?= =?us-ascii?Q?7/YeUxTSqto/PjhC9JXXuiNJkaXl/+H2A80MCDoqAUSlxpDb6XPb7Zm4FRxj?= =?us-ascii?Q?wi7qjOPMzP+md81eW1fLhwgNczEsmYKaQKNqB9gxEF1JphAW54K5PeC8qx2X?= =?us-ascii?Q?+FkQDXgpCNuVJRQBAcDGATNMsA/DkIAdiA1hpZaqHLp9ZWvlIRGJlINvoWXN?= =?us-ascii?Q?nu+7Hk6RwQsGM4e2X93gMyhNzMsuKchzwMFbRxYBg4XsRESN5Uab6Wzprtqo?= =?us-ascii?Q?bsIx/QFwqgDg9OzMTgSsG60p+WS7V2LMNtuPv3YW9v6Vk1zmau8M1hVMNXJh?= =?us-ascii?Q?mdwNLJMF5vsVE3/D3o6hg37jeoF5QlZUYz0oPFHtRLVG/CT/CR8PksJdK2fs?= =?us-ascii?Q?gGyNggcLnqJBqBYPyiSi/Plu/dA3h2RBHfZLw3VefmxFolcgZKE56wR9tft1?= =?us-ascii?Q?vTtrcizrrKnRnrfz6u46baO+SsjauyFfj78B2Hzv2/vdotUz5AzyQ636SBfM?= =?us-ascii?Q?sOOknDXX/cHquLa37++3Of4UWcd9Eb2fI//SnPMjJKPGuVp9vgZ5+t4Jcbve?= =?us-ascii?Q?YPxzdK+pBcm8lGD1+iN/5nd9XAuVTU1p6d6fA7PelbM0wlDjF4HyvB0AdQhf?= =?us-ascii?Q?as4cigO76LcCMYu5Nc1m7z7IHjnHoqJ5caDVXz60eOqlrJePwflECKKequqc?= =?us-ascii?Q?80dNDKEQk+eQ+8waM42BOEPnn1nluaaCYy/8dyIDYeteV6V4TB5E6b/Ty6vN?= =?us-ascii?Q?g/90i0rTcQ=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 561f06c9-e38c-4d54-54f3-08deb2464898 X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB7726.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2026 05:53:26.9980 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gZ9qNLgWhIClZjLnBPN2uVZTIAwwrkYzvYaRrBWTw6oj48nSEAZQaitWDQt4QlYuWi3MRXVIK8EI0Z0dp9t0IA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB7086 On 2026-05-14 at 12:53 +1000, liuqiangneo@163.com wrote... > From: Qiang Liu > > Handle migrate_vma_setup() failure via goto err for unified cleanup. In practice migrate_vma_setup() should never fail unless the test is wrong as it just tests some static VMA properties. It might be nice to add a comment to that effect, but the fix looks good so feel free to add: Reviewed-by: Alistair Popple - Alistair > Signed-off-by: Qiang Liu > --- > lib/test_hmm.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/lib/test_hmm.c b/lib/test_hmm.c > index 213504915737..5430ef97bbe0 100644 > --- a/lib/test_hmm.c > +++ b/lib/test_hmm.c > @@ -1679,8 +1679,10 @@ static vm_fault_t dmirror_devmem_fault(struct vm_fault *vmf) > if (order) > args.flags |= MIGRATE_VMA_SELECT_COMPOUND; > > - if (migrate_vma_setup(&args)) > - return VM_FAULT_SIGBUS; > + if (migrate_vma_setup(&args)) { > + ret = VM_FAULT_SIGBUS; > + goto err; > + } > > ret = dmirror_devmem_fault_alloc_and_copy(&args, dmirror); > if (ret) > -- > 2.43.0 > >