From: Yeoreum Yun <yeoreum.yun@arm.com>
To: Leo Yan <leo.yan@arm.com>
Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, suzuki.poulose@arm.com,
mike.leach@arm.com, james.clark@linaro.org,
alexander.shishkin@linux.intel.com, jie.gan@oss.qualcomm.com
Subject: Re: [PATCH v6 02/13] coresight: etm4x: fix underflow for nrseqstate
Date: Fri, 15 May 2026 12:10:45 +0100 [thread overview]
Message-ID: <agb/NdYS/2jXdog0@e129823.arm.com> (raw)
In-Reply-To: <20260505161905.GA3778514@e132581.arm.com>
Hi Leo,
> On Wed, Apr 22, 2026 at 02:21:52PM +0100, Yeoreum Yun wrote:
> > TCRSEQEVR<n> is implemented only when TCRIDR5.NUMSEQSTATE is 0b100,
> > in which case n ranges from 0 to 2; otherwise, TCRIDR5.NUMSEQSTATE is 0b000.
> >
> > Therefore, drvdata->nrseqstate should be checked before entering the loop.
>
> Since TRCSEQEVRn (n=0~2), to avoid confusion, we also need to rename
> ETM_MAX_SEQ_STATES to ETM_MAX_SEQ_TRANSITIONS and define it as 3:
>
> #define ETM_MAX_SEQ_TRANSITIONS 3
>
> Then we don't allocate 4 items but use only 3 of them.
TBH, the number of transition is determinied by the MAX number of
SEQ_STATE that's why I think define the ETM_MAX_SEQ_TRANSITIONS with
#define ETM_MAX_SEQ_TRANSITIONS (ETM_MAX_SEQ_STATE - 1)
and uses ETM_MAX_SEQ_TRANSITIONS for the TCRSEQEVR and seq_ctrl.
Thought?
--
Sincerely,
Yeoreum Yun
next prev parent reply other threads:[~2026-05-15 11:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260422132203.977549-1-yeoreum.yun@arm.com>
[not found] ` <20260422132203.977549-3-yeoreum.yun@arm.com>
2026-05-05 16:19 ` [PATCH v6 02/13] coresight: etm4x: fix underflow for nrseqstate Leo Yan
2026-05-15 11:10 ` Yeoreum Yun [this message]
2026-05-15 13:29 ` Leo Yan
[not found] ` <20260422132203.977549-5-yeoreum.yun@arm.com>
2026-05-06 8:48 ` [PATCH v6 04/13] coresight: etm4x: exclude ss_status from drvdata->config Leo Yan
2026-05-08 15:27 ` Leo Yan
2026-05-09 11:55 ` Yeoreum Yun
2026-05-15 10:05 ` Leo Yan
[not found] ` <20260422132203.977549-8-yeoreum.yun@arm.com>
2026-05-15 8:53 ` [PATCH v6 07/13] coresight: etm4x: fix inconsistencies with sysfs configuration Leo Yan
2026-05-15 10:36 ` Yeoreum Yun
[not found] ` <20260422132203.977549-9-yeoreum.yun@arm.com>
2026-05-15 9:08 ` [PATCH v6 08/13] coresight: etm4x: remove redundant call etm4_enable_hw() with hotplug Leo Yan
2026-05-15 10:51 ` Yeoreum Yun
[not found] ` <20260422132203.977549-10-yeoreum.yun@arm.com>
2026-05-15 9:39 ` [PATCH v6 09/13] coresight: etm4x: missing cscfg_csdev_disable_active_config() in perf enable Leo Yan
2026-05-15 13:35 ` Yeoreum Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agb/NdYS/2jXdog0@e129823.arm.com \
--to=yeoreum.yun@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=james.clark@linaro.org \
--cc=jie.gan@oss.qualcomm.com \
--cc=leo.yan@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@arm.com \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox