From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
Cc: "Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"David Rhodes" <david.rhodes@cirrus.com>,
"Richard Fitzgerald" <rf@opensource.cirrus.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Shenghao Ding" <shenghao-ding@ti.com>,
"Kevin Lu" <kevin-lu@ti.com>, "Baojun Xu" <baojun.xu@ti.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Nuno Sá" <nuno.sa@analog.com>,
"Martin Povišer" <povik+lin@cutebit.org>,
"Support Opensource" <support.opensource@diasemi.com>,
"Nick Li" <nick.li@foursemi.com>,
"M R Swami Reddy" <mr.swami.reddy@ti.com>,
"Vishwas A Deshpande" <vishwas.a.deshpande@ti.com>,
"Peter Rosin" <peda@axentia.se>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Oder Chiou" <oder_chiou@realtek.com>,
"Fabio Estevam" <festevam@gmail.com>,
"Kiseok Jo" <kiseok.jo@irondevice.com>,
"Kevin Cernekee" <cernekee@chromium.org>,
"Steven Eckhoff" <steven.eckhoff.opensource@gmail.com>,
"Kuninori Morimoto" <kuninori.morimoto.gx@renesas.com>,
"Thorsten Blum" <thorsten.blum@linux.dev>,
"Chris Morgan" <macromorgan@hotmail.com>,
"Dan Carpenter" <dan.carpenter@linaro.org>,
"Marco Crivellari" <marco.crivellari@suse.com>,
"Weidong Wang" <wangweidong.a@awinic.com>,
"Aaron Kling" <webgeek1234@gmail.com>,
"Teguh Sobirin" <teguh@sobir.in>,
"Luca Weiss" <luca.weiss@fairphone.com>,
"Bharadwaj Raju" <bharadwaj.raju@machinesoul.in>,
"Hsieh Hung-En" <hungen3108@gmail.com>,
"Binbin Zhou" <zhoubinbin@loongson.cn>,
"Shimrra Shai" <shimrrashai@gmail.com>,
"Zhang Yi" <zhangyi@everest-semi.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Srinivas Kandagatla" <srinivas.kandagatla@oss.qualcomm.com>,
"Qasim Ijaz" <qasdev00@gmail.com>,
"Sharique Mohammad" <sharq0406@gmail.com>,
"Chen Ni" <nichen@iscas.ac.cn>,
"Neo Chang" <YLCHANG2@nuvoton.com>,
"Cezary Rojewski" <cezary.rojewski@intel.com>,
"Cristian Ciocaltea" <cristian.ciocaltea@collabora.com>,
"Kees Cook" <kees@kernel.org>,
"Qianfeng Rong" <rongqianfeng@vivo.com>,
"Tim Bird" <tim.bird@sony.com>,
"Bram Vlerick" <bram.vlerick@openpixelsystems.org>,
"Peter Korsgaard" <peter@korsgaard.com>,
"Linus Walleij" <linusw@kernel.org>,
"Wenyuan Li" <2063309626@qq.com>,
"Bartosz Golaszewski" <brgl@kernel.org>,
"Shengjiu Wang" <shengjiu.wang@nxp.com>,
"Sebastian Krzyszkowiak" <sebastian.krzyszkowiak@puri.sm>,
"Xichao Zhao" <zhao.xichao@vivo.com>,
linux-sound@vger.kernel.org, patches@opensource.cirrus.com,
linux-kernel@vger.kernel.org, asahi@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
"Markus Schneider-Pargmann" <msp@baylibre.com>
Subject: Re: [PATCH v1 2/2] ASoC: Use named initializers for arrays of i2c_device_data
Date: Fri, 15 May 2026 11:18:09 +0100 [thread overview]
Message-ID: <agby4VvKu2XSS2FB@opensource.cirrus.com> (raw)
In-Reply-To: <ae2ff4898eb340bd8bcafb7b75443eb4a0ce3e76.1778692164.git.u.kleine-koenig@baylibre.com>
On Wed, May 13, 2026 at 07:23:04PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> While being less compact, using named initializers allows to more easily
> see which members of the structs are assigned which value without having
> to lookup the declaration of the struct. And it's also more robust
> against changes to the struct definition.
>
> The mentioned robustness is relevant for a planned change to struct
> i2c_device_id that replaces .driver_data by an anonymous union.
>
> While touching all these arrays, unify indention and usage of commas.
>
> This patch doesn't modify the compiled arrays, only their representation
> in source form benefits. The former was confirmed with x86 and arm64
> builds.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> ---
For the Wolfson/Cirrus bits:
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
prev parent reply other threads:[~2026-05-15 10:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 17:23 [PATCH v1 0/2] ASoC: Rework initialization of i2c_device_ids Uwe Kleine-König (The Capable Hub)
2026-05-13 17:23 ` [PATCH v1 1/2] ASoC: Drop empty i2c remove callbacks Uwe Kleine-König (The Capable Hub)
2026-05-15 10:13 ` Charles Keepax
2026-05-13 17:23 ` [PATCH v1 2/2] ASoC: Use named initializers for arrays of i2c_device_data Uwe Kleine-König (The Capable Hub)
2026-05-13 19:00 ` Krzysztof Kozlowski
2026-05-14 5:59 ` Krzysztof Kozlowski
2026-05-15 10:18 ` Charles Keepax [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agby4VvKu2XSS2FB@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=2063309626@qq.com \
--cc=YLCHANG2@nuvoton.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=asahi@lists.linux.dev \
--cc=baojun.xu@ti.com \
--cc=bharadwaj.raju@machinesoul.in \
--cc=bram.vlerick@openpixelsystems.org \
--cc=brgl@kernel.org \
--cc=broonie@kernel.org \
--cc=cernekee@chromium.org \
--cc=cezary.rojewski@intel.com \
--cc=cristian.ciocaltea@collabora.com \
--cc=dan.carpenter@linaro.org \
--cc=david.rhodes@cirrus.com \
--cc=festevam@gmail.com \
--cc=hungen3108@gmail.com \
--cc=kees@kernel.org \
--cc=kevin-lu@ti.com \
--cc=kiseok.jo@irondevice.com \
--cc=krzk@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=macromorgan@hotmail.com \
--cc=marco.crivellari@suse.com \
--cc=matthias.bgg@gmail.com \
--cc=mr.swami.reddy@ti.com \
--cc=msp@baylibre.com \
--cc=nichen@iscas.ac.cn \
--cc=nick.li@foursemi.com \
--cc=nuno.sa@analog.com \
--cc=oder_chiou@realtek.com \
--cc=patches@opensource.cirrus.com \
--cc=peda@axentia.se \
--cc=perex@perex.cz \
--cc=peter@korsgaard.com \
--cc=povik+lin@cutebit.org \
--cc=qasdev00@gmail.com \
--cc=rf@opensource.cirrus.com \
--cc=rongqianfeng@vivo.com \
--cc=sebastian.krzyszkowiak@puri.sm \
--cc=sharq0406@gmail.com \
--cc=shenghao-ding@ti.com \
--cc=shengjiu.wang@nxp.com \
--cc=shimrrashai@gmail.com \
--cc=srinivas.kandagatla@oss.qualcomm.com \
--cc=steven.eckhoff.opensource@gmail.com \
--cc=support.opensource@diasemi.com \
--cc=teguh@sobir.in \
--cc=thorsten.blum@linux.dev \
--cc=tim.bird@sony.com \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=vishwas.a.deshpande@ti.com \
--cc=wangweidong.a@awinic.com \
--cc=webgeek1234@gmail.com \
--cc=zhangyi@everest-semi.com \
--cc=zhao.xichao@vivo.com \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox